Only use str_replace if key contains a space

john-shaffer · john-shaffer · commit b771f34d0247 · 2025-11-17T15:54:05.000-06:00
diff --git a/src/drop-in/object-cache.php b/src/drop-in/object-cache.php
@@ -157,7 +157,7 @@ private function cache_key(
 
             // Unfortunately WordPress uses a lot of keys with spaces,
             // and the memcached text protocol doesn't allow that.
-            if ( ! SNAPCACHE_MEMCACHED_USE_BINARY ) {
+            if ( ! SNAPCACHE_MEMCACHED_USE_BINARY && str_contains( $key, ' ' ) ) {
                 $key = str_replace( ' ', '_', $key );
             }
 

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ private function cache_key(`
`157`	`157`
`158`	`158`	`// Unfortunately WordPress uses a lot of keys with spaces,`
`159`	`159`	`// and the memcached text protocol doesn't allow that.`
`160`		`- if ( ! SNAPCACHE_MEMCACHED_USE_BINARY ) {`
	`160`	`+ if ( ! SNAPCACHE_MEMCACHED_USE_BINARY && str_contains( $key, ' ' ) ) {`
`161`	`161`	`$key = str_replace( ' ', '_', $key );`
`162`	`162`	`}`
`163`	`163`