Alert when page linked to menu item is deleted: refactored to separate action classes: fix bugs + translations

Author: sten

resources/lang/en/filament-flexible-content-block-pages.php

@@ -16,6 +16,11 @@
         'table' => [
             'created_at_col' => 'Created at',
         ],
+        'notifications' => [
+            'used_in_menu' => 'This page is used in the ":menu" menu, in item :menu_item. Please update the menu first and then try deleting this page again.',
+            'used_in_menu_bulk' => 'Page ":page" is used in the ":menu" menu, in item :menu_item. Please update the menu first and then try deleting this page again.',
+        ],
+
     ],
     'redirects' => [
         'redirects_lbl' => 'redirect',

resources/lang/nl/filament-flexible-content-block-pages.php

@@ -18,6 +18,7 @@
         ],
         'notifications' => [
             'used_in_menu' => 'Deze pagina wordt in het ":menu" menu gebruikt, in item :menu_item. Gelieve eerst het menu aan te passen en dan deze pagina opnieuw te verwijderen.',
+            'used_in_menu_bulk' => 'Pagina ":page" wordt in het ":menu" menu gebruikt, in item :menu_item. Gelieve eerst het menu aan te passen en dan deze pagina opnieuw te verwijderen.',
         ],
     ],
     'redirects' => [

src/Actions/LinkedToMenuItemBulkDeleteAction.php

@@ -19,7 +19,7 @@ public function setUp(): void
     {
         parent::setUp();
 
-        $this->action(function (Collection $records, Action $action) {
+        $this->action(function (Collection $records, LinkedToMenuItemBulkDeleteAction $action) {
             $usedInMenu = false;
             foreach ($records as $record) {
                 /** @var Model&HasMenuLabel $record */
@@ -31,16 +31,21 @@ public function setUp(): void
                     $usedInMenu = true;
 
                     Notification::make()
-                        ->title(flexiblePagesTrans('pages.notifications.used_in_menu', [
+                        ->title(flexiblePagesTrans('pages.notifications.used_in_menu_bulk', [
+                            'page' => $record->getMenuLabel(),
                             'menu' => $menuItem->menu->name,
                             'menu_item' => $menuItem->getDisplayLabel(),
                         ]))
                         ->danger()
+                        ->duration(12000)
                         ->send();
                 }
             }
 
-            if (! $usedInMenu) {
+            if ($usedInMenu) {
+                $action->failure();
+            }
+            else {
                 $this->process(static fn (Collection $records) => $records->each(fn (Model&HasMenuLabel $record) => $record->delete()));
                 $action->success();
             }

src/Actions/LinkedToMenuItemDeleteAction.php

@@ -29,6 +29,7 @@ protected function setUp(): void
                         'menu_item' => $menuItem->getDisplayLabel(),
                     ]))
                     ->danger()
+                    ->duration(12000)
                     ->send();
             } else {
                 $record->delete();

src/Resources/PageResource.php

@@ -11,6 +11,7 @@
 use Filament\Tables\Actions\EditAction;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Table;
+use Illuminate\Database\Eloquent\Builder;
 use Statikbe\FilamentFlexibleContentBlockPages\Actions\LinkedToMenuItemBulkDeleteAction;
 use Statikbe\FilamentFlexibleContentBlockPages\Facades\FilamentFlexibleContentBlockPages;
 use Statikbe\FilamentFlexibleContentBlockPages\Resources\PageResource\Pages\CreatePage;
@@ -167,7 +168,7 @@ protected static function getAdvancedTabFields(): array
                 ->searchable(['title', 'code', 'slug', 'intro']);
         }
 
-        if (! empty($gridFields)) {
+        if (!empty($gridFields)) {
             $fields[] = Grid::make()->schema($gridFields);
         }
 
@@ -197,8 +198,11 @@ public static function table(Table $table): Table
                 LinkedToMenuItemBulkDeleteAction::make(),
             ])
             ->recordUrl(
-                fn ($record): string => static::getUrl('edit', ['record' => $record])
-            );
+                fn($record): string => static::getUrl('edit', ['record' => $record])
+            )
+            ->modifyQueryUsing(function (Builder $query) {
+                $query->with(['menuItem']);
+            });
     }
 
     public static function getRelations(): array