Refactor menu item icon handling.

Author: sten

src/Form/Fields/Types/AbstractMenuItemType.php

@@ -4,20 +4,6 @@
 
 abstract class AbstractMenuItemType
 {
-    protected ?string $icon = null;
-
-    public function getIcon(): ?string
-    {
-        return $this->icon;
-    }
-
-    public function icon(?string $icon): static
-    {
-        $this->icon = $icon;
-
-        return $this;
-    }
-
     abstract public function getAlias(): string;
 
     public function isUrlType(): bool

src/Form/Fields/Types/LinkableMenuItemType.php

@@ -18,14 +18,6 @@ class LinkableMenuItemType extends AbstractMenuItemType
     public function __construct(string $model)
     {
         $this->model = $model;
-        $this->icon = 'heroicon-o-link';
-
-        // Set icon based on model if it has a getMorphClass method
-        $modelInstance = app($model);
-        if (method_exists($modelInstance, 'getMorphClass')) {
-            $morphClass = $modelInstance->getMorphClass();
-            $this->icon = $this->getIconForMorphClass($morphClass);
-        }
     }
 
     public static function make(string $model): static
@@ -122,26 +114,6 @@ protected function getHelperText(): string
         ]);
     }
 
-    protected function getIconForMorphClass(string $morphClass): string
-    {
-        // Check config for exact morph class match
-        $configuredIcons = FilamentFlexibleContentBlockPages::config()
-            ->getMenuModelIcons();
-
-        if (isset($configuredIcons[$morphClass])) {
-            return $configuredIcons[$morphClass];
-        }
-
-        // Fallback to pattern matching for backwards compatibility
-        foreach ($configuredIcons as $pattern => $icon) {
-            if (str_contains($morphClass, $pattern)) {
-                return $icon;
-            }
-        }
-
-        // Final fallback to default icon
-        return 'heroicon-o-link';
-    }
 
     public function isModelType(): bool
     {

src/Form/Fields/Types/RouteMenuItemType.php

@@ -9,11 +9,6 @@ class RouteMenuItemType extends AbstractMenuItemType
 {
     const TYPE_ROUTE = 'route';
 
-    public function __construct()
-    {
-        $this->icon = 'heroicon-o-map';
-    }
-
     public static function make(?string $model = null): static
     {
         return new static;

src/Form/Fields/Types/UrlMenuItemType.php

@@ -8,11 +8,6 @@ class UrlMenuItemType extends AbstractMenuItemType
 {
     const TYPE_URL = 'url';
 
-    public function __construct()
-    {
-        $this->icon = 'heroicon-o-link';
-    }
-
     public static function make(?string $model = null): static
     {
         return new static;