Make Page form more UX friendly by moving rarely used fields to advanced tab

Fix phpstan errors

Author: sten

resources/lang/en/filament-flexible-content-block-pages.php

@@ -11,6 +11,7 @@
             'content' => 'Content',
             'seo' => 'Search engine optimization',
             'overview' => 'Overview',
+            'advanced' => 'Advanced',
         ],
         'table' => [
             'created_at_col' => 'Created at',

resources/lang/nl/filament-flexible-content-block-pages.php

@@ -11,6 +11,7 @@
             'content' => 'Inhoud',
             'seo' => 'Search engine optimalisatie',
             'overview' => 'Overzicht',
+            'advanced' => 'Geavanceerd',
         ],
         'table' => [
             'created_at_col' => 'Aangemaakt op',

src/Commands/SeedDefaultsCommand.php

@@ -65,9 +65,18 @@ public function seedSettings(): void
         }
     }
 
+    /**
+     * Set a translated field value for all given locales.
+     * 
+     * @param Model $model Model that uses HasTranslations trait
+     * @param string $field
+     * @param string $value
+     * @param array<string> $locales
+     */
     private function setTranslatedField(Model $model, string $field, string $value, array $locales)
     {
         foreach ($locales as $locale) {
+            /** @phpstan-ignore-next-line */
             $model->setTranslation($field, $locale, $value);
         }
     }

src/FilamentFlexibleContentBlockPagesServiceProvider.php

@@ -11,7 +11,6 @@
 use Statikbe\FilamentFlexibleContentBlockPages\Components\LanguageSwitch;
 use Statikbe\FilamentFlexibleContentBlockPages\Components\Menu;
 use Statikbe\FilamentFlexibleContentBlockPages\Components\MenuItem;
-use Statikbe\FilamentFlexibleContentBlockPages\Livewire\MenuTreeItem;
 
 class FilamentFlexibleContentBlockPagesServiceProvider extends PackageServiceProvider
 {
@@ -48,8 +47,5 @@ public function packageBooted()
     {
         // add morph map
         Relation::morphMap(\Statikbe\FilamentFlexibleContentBlockPages\Facades\FilamentFlexibleContentBlockPages::config()->getMorphMap());
-
-        // Register Livewire components
-        Livewire::component('filament-flexible-content-block-pages::menu-tree-item', MenuTreeItem::class);
     }
 }

src/Form/Fields/Types/LinkableMenuItemType.php

@@ -3,7 +3,9 @@
 namespace Statikbe\FilamentFlexibleContentBlockPages\Form\Fields\Types;
 
 use Closure;
+use phpDocumentor\Reflection\Types\ClassString;
 use Statikbe\FilamentFlexibleContentBlockPages\Models\Contracts\HasMenuLabel;
+use Statikbe\FilamentFlexibleContentBlocks\Models\Contracts\Linkable;
 
 class LinkableMenuItemType extends AbstractMenuItemType
 {
@@ -13,7 +15,7 @@ class LinkableMenuItemType extends AbstractMenuItemType
 
     protected int $searchResultLimit = 50;
 
-    public function __construct(string $model)
+    final public function __construct(string $model)
     {
         $this->model = $model;
     }
@@ -56,6 +58,8 @@ public function getSearchResults(string $search): array
             return [];
         }
 
+        /** @var class-string<HasMenuLabel> $modelClass */
+        /** @phpstan-ignore-next-line */
         $results = $modelClass::searchForMenuItems($search)
             ->limit($this->searchResultLimit)
             ->get();

src/Form/Fields/Types/RouteMenuItemType.php

@@ -9,6 +9,8 @@ class RouteMenuItemType extends AbstractMenuItemType
 {
     const TYPE_ROUTE = 'route';
 
+    final public function __construct() {}
+
     public static function make(?string $model = null): static
     {
         return new static;
@@ -32,7 +34,7 @@ public function getRouteField(): Select
     public function getRouteOptions(): array
     {
         $routes = [];
-        $routeCollection = Route::getRoutes();
+        $routeCollection = Route::getRoutes()->getRoutes();
 
         foreach ($routeCollection as $route) {
             $name = $route->getName();

src/Form/Fields/Types/UrlMenuItemType.php

@@ -8,7 +8,9 @@ class UrlMenuItemType extends AbstractMenuItemType
 {
     const TYPE_URL = 'url';
 
-    public static function make(?string $model = null): static
+    final public function __construct() {}
+
+    public static function make(): static
     {
         return new static;
     }

src/Form/Forms/MenuItemForm.php

@@ -121,10 +121,12 @@ protected static function getLinkableField(): Select
                 $type = static::getTypeByAlias($linkType);
 
                 if ($type && $type->isModelType()) {
+                    /** @var LinkableMenuItemType $type */
                     $modelClass = $type->getModel();
 
                     // Use the model's searchForMenuItems scope if it implements HasMenuLabel
                     if (is_subclass_of($modelClass, HasMenuLabel::class)) {
+                        /** @phpstan-ignore-next-line */
                         $results = $modelClass::searchForMenuItems($search)
                             ->limit(50)
                             ->get();
@@ -142,6 +144,7 @@ protected static function getLinkableField(): Select
                 $type = static::getTypeByAlias($linkType);
 
                 if ($type && $type->isModelType() && $value) {
+                    /** @var LinkableMenuItemType $type */
                     $record = app($type->getModel())::find($value);
                     if ($record && $record instanceof HasMenuLabel) {
                         return $record->getMenuLabel();
@@ -157,6 +160,7 @@ protected static function getLinkableField(): Select
                 $type = static::getTypeByAlias($linkType);
 
                 if ($type && $type->isModelType()) {
+                    /** @var LinkableMenuItemType $type */
                     $modelLabel = static::getModelLabelFromResource($type->getModel());
 
                     return flexiblePagesTrans('menu_items.form.linkable_help', [
@@ -252,6 +256,7 @@ protected static function getTypeLabel(AbstractMenuItemType $type): string
         }
 
         // Get translated model label from Filament resource
+        /** @var LinkableMenuItemType $type */
         return Str::ucfirst(static::getModelLabelFromResource($type->getModel()));
     }
 

src/Http/Controllers/PageController.php

@@ -194,7 +194,7 @@ function () use ($seoMedia, $conversion) {
                         'height' => $image->getHeight(),
                     ];
                 });
-        } catch (CouldNotLoadImage $exception) {
+        } catch (CouldNotLoadImage $exception) { // @phpstan-ignore-line
             return [];
         }
     }

src/Models/Concerns/HasTitleMenuLabelTrait.php

@@ -7,28 +7,26 @@ trait HasTitleMenuLabelTrait
     /**
      * Get the display label for menu items.
      * This implementation uses the 'title' field with locale support.
+     * Assumes the model uses Spatie Laravel Translatable trait.
      */
     public function getMenuLabel(?string $locale = null): string
     {
         $locale = $locale ?: app()->getLocale();
 
-        // Check if the model uses translations (like Spatie Laravel Translatable)
-        if (method_exists($this, 'getTranslation')) {
-            $title = $this->getTranslation('title', $locale);
-            if (empty($title)) {
-                // Fallback to the configured fallback locale
-                $title = $this->getTranslation('title', config('app.fallback_locale', 'en'));
-            }
-
-            return $title ?: 'Untitled';
+        // Get translated title (assumes HasTranslations trait is used)
+        $title = $this->getTranslation('title', $locale);
+        if (empty($title)) {
+            // Fallback to the configured fallback locale
+            $title = $this->getTranslation('title', config('app.fallback_locale', 'en'));
         }
 
-        return $this->title ?: 'Untitled';
+        return $title ?: 'Untitled';
     }
 
     /**
      * Scope to search for models that can be used in menu items.
      * This implementation searches in common searchable fields.
+     * Assumes the model uses Spatie Laravel Translatable trait.
      */
     public function scopeSearchForMenuItems($query, string $search)
     {
@@ -39,8 +37,7 @@ public function scopeSearchForMenuItems($query, string $search)
             $searchableFields = ['name', 'intro', 'description', 'overview_title'];
             foreach ($searchableFields as $field) {
                 if (in_array($field, $this->getFillable()) ||
-                    (method_exists($this, 'getTranslatableAttributes') &&
-                     in_array($field, $this->getTranslatableAttributes()))) {
+                    in_array($field, $this->getTranslatableAttributes())) {
                     $query->orWhere($field, 'like', "%{$search}%");
                 }
             }