Skip to content

Commit 7b7652c

Browse files
committed
Fix translatable label bug
1 parent 0313e8a commit 7b7652c

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/Resources/MenuResource/Pages/ManageMenuItems.php

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,6 @@ public function createMenuItem(array $data): void
669669
'menu_id' => $this->record->id,
670670
'parent_id' => $data['parent_id'] ?? null,
671671
'link_type' => $data['link_type'],
672-
'label' => $data['label'],
673672
'use_model_title' => $data['use_model_title'] ?? false,
674673
'url' => $data['url'] ?? null,
675674
'route' => $data['route'] ?? null,
@@ -680,6 +679,11 @@ public function createMenuItem(array $data): void
680679
'is_visible' => $data['is_visible'] ?? true,
681680
]);
682681

682+
// Handle translatable label field separately
683+
if (isset($data['label'])) {
684+
$menuItem->label = $data['label'];
685+
}
686+
683687
// Handle nested set positioning
684688
if ($data['parent_id']) {
685689
$parent = $this->getMenuItemSecurely($data['parent_id']);
@@ -730,7 +734,6 @@ public function updateMenuItem(int $itemId, array $data): void
730734
// Update the menu item
731735
$item->update([
732736
'link_type' => $data['link_type'],
733-
'label' => $data['label'],
734737
'use_model_title' => $data['use_model_title'] ?? false,
735738
'url' => $data['url'] ?? null,
736739
'route' => $data['route'] ?? null,
@@ -741,6 +744,12 @@ public function updateMenuItem(int $itemId, array $data): void
741744
'is_visible' => $data['is_visible'] ?? true,
742745
]);
743746

747+
// Handle translatable label field separately
748+
if (isset($data['label'])) {
749+
$item->label = $data['label'];
750+
$item->save();
751+
}
752+
744753
Notification::make()
745754
->title(flexiblePagesTrans('menu_items.messages.item_updated'))
746755
->success()

0 commit comments

Comments
 (0)