Fix missing SEO Image url exception

Author: sten

README.md

@@ -215,6 +215,8 @@ TODO
 - tag controller
 - sitemap implementation
 - asset manager install in panel
+- orm listeners for linkable models that are in a menu to avoid accidental deletion.
+- frontend caching for menus
 
 ## Changelog
 

src/Http/Controllers/PageController.php

@@ -10,6 +10,7 @@
 use Illuminate\Support\Facades\Auth;
 use Illuminate\Support\Facades\Cache;
 use Mcamara\LaravelLocalization\Facades\LaravelLocalization;
+use Spatie\Image\Exceptions\CouldNotLoadImage;
 use Spatie\Image\Image;
 use Spatie\MediaLibrary\MediaCollections\Models\Media;
 use Statikbe\FilamentFlexibleContentBlockPages\Facades\FilamentFlexibleContentBlockPages;
@@ -168,32 +169,34 @@ protected function setSEOImage(Page $page)
             }
         }
 
-        if ($seoUrl && $imageDimensions) {
+        if ($seoUrl && ! empty($imageDimensions)) {
             SEOTools::opengraph()->addImage($seoUrl, $imageDimensions);
             SEOTools::twitter()->addValue('image', $seoUrl);
         }
     }
 
     /**
      * Get the dimensions of an image with the given path. Uses cache so the image file does not need to be read each time.
-     *
-     * @return array|mixed
      */
-    protected function getSEOImageDimensions(Media $seoMedia, string $conversion)
+    protected function getSEOImageDimensions(Media $seoMedia, string $conversion): array
     {
         $cacheKey = sprintf(self::CACHE_SEO_IMAGE_DIMENSIONS, $seoMedia->uuid);
 
-        return Cache::remember($cacheKey,
-            self::CACHE_SEO_IMAGE_TTL,
-            function () use ($seoMedia, $conversion) {
-                $filePath = $seoMedia->getPath($conversion);
-                $image = Image::load($filePath);
-
-                return [
-                    'width' => $image->getWidth(),
-                    'height' => $image->getHeight(),
-                ];
-            });
+        try {
+            return Cache::remember($cacheKey,
+                self::CACHE_SEO_IMAGE_TTL,
+                function () use ($seoMedia, $conversion) {
+                    $filePath = $seoMedia->getPath($conversion);
+                    $image = Image::load($filePath);
+
+                    return [
+                        'width' => $image->getWidth(),
+                        'height' => $image->getHeight(),
+                    ];
+                });
+        } catch (CouldNotLoadImage $exception) {
+            return [];
+        }
     }
 
     private function getSettingsTitle(): string