ResolveXrefs now reports every error in a document

Author: daveaglick

RELEASE.md

@@ -1,5 +1,6 @@
 # 1.0.0-alpha.9
 
+- Fixed xref resolution to report all errors in a given document at once.
 - Changed the xref space placeholder character to a dash to match/roundtrip automatic file name titles.
 - Removed the `ChildPages` shortcode (it should really be part of the theme).
 

src/Statiq.Web/Modules/ResolveXrefs.cs

@@ -37,6 +37,7 @@ public class ResolveXrefs : Module
             {
                 // Find and replace "xref:" in links
                 bool modifiedDocument = false;
+                bool errors = false;
                 foreach (IElement element in htmlDocument
                     .GetElementsByTagName("a")
                     .Where(x => x.HasAttribute("href")))
@@ -58,13 +59,20 @@ public class ResolveXrefs : Module
                         }
                         else
                         {
+                            // Continue processing so we can report all the failures in a given document
                             input.LogError(error);
-                            return null;
+                            errors = true;
                         }
                         modifiedDocument = true;
                     }
                 }
 
+                // Exit if there were errors
+                if (errors)
+                {
+                    return null;
+                }
+
                 // Return a new document with the replacements if we performed any
                 if (modifiedDocument)
                 {