fix: add reports informer to ensure correct metrics (#1592)

Author: erikgb

internal/controller/stas/scan_job_controller.go

@@ -8,7 +8,6 @@ import (
 	"slices"
 	"strings"
 
-	openreportsv1alpha1 "github.com/openreports/reports-api/apis/openreports.io/v1alpha1"
 	batchv1 "k8s.io/api/batch/v1"
 	corev1 "k8s.io/api/core/v1"
 	eventsv1 "k8s.io/api/events/v1"
@@ -66,8 +65,7 @@ func (r *ScanJobReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				inNamespacePredicate(r.ScanJobNamespace),
 				jobIsFinished,
 				ignoreDeletionPredicate(),
-										)).
-		Watches(&openreportsv1alpha1.Report{}, handler.Funcs{}). // Watches reports with empty handler to ensure informer creation for metrics collection
+			)).
 		Complete(r.reconcile())
 	if err != nil {
 		return err

internal/operator/operator.go

@@ -262,6 +262,14 @@ func (o Operator) Start(cfg config.Config) error {
 		return fmt.Errorf("unable to set up ready check: %w", err)
 	}
 
+	ctx := ctrl.SetupSignalHandler()
+
+	// We need to create an informer for reports to ensure all reports are available in cache to
+	// serve custom image scanner metrics.
+	if _, err := mgr.GetCache().GetInformer(ctx, &openreportsv1alpha1.Report{}); err != nil {
+		return fmt.Errorf("failed to create reports informer: %w", err)
+	}
+
 	if err = (&metrics.ImageMetricsCollector{
 		Reader: mgr.GetCache(),
 		Config: cfg,
@@ -272,7 +280,7 @@ func (o Operator) Start(cfg config.Config) error {
 
 	ctrl.Log.Info("starting manager")
 
-	if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
+	if err := mgr.Start(ctx); err != nil {
 		return fmt.Errorf("problem running manager: %w", err)
 	}