fix: only process stable/current pods (#1289)

Author: erikgb

internal/controller/stas/predicates.go

@@ -8,7 +8,11 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	eventsv1 "k8s.io/api/events/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+	kstatus "sigs.k8s.io/cli-utils/pkg/kstatus/status"
+	ctrl "sigs.k8s.io/controller-runtime"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/event"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
@@ -49,6 +53,24 @@ func podContainerStatusImagesChanged() predicate.Predicate {
 	}
 }
 
+func isKStatusCurrent() predicate.Predicate {
+	return predicate.NewPredicateFuncs(func(object client.Object) bool {
+		m, err := runtime.DefaultUnstructuredConverter.ToUnstructured(object)
+		if err != nil {
+			ctrl.Log.Error(err, "Failed to convert object to unstructured")
+			return false
+		}
+
+		res, err := kstatus.Compute(&unstructured.Unstructured{Object: m})
+		if err != nil {
+			ctrl.Log.Error(err, "Failed to compute KStatus")
+			return false
+		}
+
+		return res.Status == kstatus.CurrentStatus
+	})
+}
+
 func ignoreCreationPredicate() predicate.Predicate {
 	return predicate.Funcs{
 		CreateFunc: func(e event.CreateEvent) bool {

internal/controller/stas/workload_controller.go

@@ -78,6 +78,7 @@ func (r *PodReconciler) SetupWithManager(mgr ctrl.Manager) error {
 				podContainerStatusImagesChanged(),
 				predicate.Or(controllerInKinds(groupKinds...), noController),
 				ignoreDeletionPredicate(),
+				isKStatusCurrent(),
 			)).
 		WithEventFilter(predicate.And(predicates...)).
 		Watches(&stasv1alpha1.ContainerImageScan{},