Skip to content

Commit 245bf5f

Browse files
authored
Fix VC does not send "Eth-Consensus-Version" header with publishBlindedBlockV2() call. (#7140)
1 parent 77cfa78 commit 245bf5f

File tree

2 files changed

+10
-71
lines changed

2 files changed

+10
-71
lines changed

beacon_chain/spec/eth2_apis/rest_beacon_calls.nim

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -325,41 +325,6 @@ proc publishSszBlindedBlock*(
325325
blck, restContentType = $OctetStreamMediaType,
326326
extraHeaders = @[("eth-consensus-version", consensus)])
327327

328-
proc publishBlindedBlockV2*(
329-
broadcast_validation: Option[BroadcastValidationType],
330-
body: phase0.SignedBeaconBlock
331-
): RestPlainResponse {.rest, endpoint: "/eth/v2/beacon/blinded_blocks",
332-
meth: MethodPost.}
333-
## https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlindedBlock
334-
335-
proc publishBlindedBlockV2*(
336-
broadcast_validation: Option[BroadcastValidationType],
337-
body: altair.SignedBeaconBlock
338-
): RestPlainResponse {.rest, endpoint: "/eth/v2/beacon/blinded_blocks",
339-
meth: MethodPost.}
340-
## https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlindedBlock
341-
342-
proc publishBlindedBlockV2*(
343-
broadcast_validation: Option[BroadcastValidationType],
344-
body: bellatrix_mev.SignedBlindedBeaconBlock
345-
): RestPlainResponse {.rest, endpoint: "/eth/v2/beacon/blinded_blocks",
346-
meth: MethodPost.}
347-
## https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlindedBlock
348-
349-
proc publishBlindedBlockV2*(
350-
broadcast_validation: Option[BroadcastValidationType],
351-
body: capella_mev.SignedBlindedBeaconBlock
352-
): RestPlainResponse {.rest, endpoint: "/eth/v2/beacon/blinded_blocks",
353-
meth: MethodPost.}
354-
## https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlindedBlock
355-
356-
proc publishBlindedBlockV2*(
357-
broadcast_validation: Option[BroadcastValidationType],
358-
body: deneb_mev.SignedBlindedBeaconBlock
359-
): RestPlainResponse {.rest, endpoint: "/eth/v2/beacon/blinded_blocks",
360-
meth: MethodPost.}
361-
## https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlindedBlock
362-
363328
proc publishBlindedBlockV2*(
364329
broadcast_validation: Option[BroadcastValidationType],
365330
body: electra_mev.SignedBlindedBeaconBlock
@@ -374,7 +339,7 @@ proc publishBlindedBlockV2*(
374339
meth: MethodPost.}
375340
## https://ethereum.github.io/beacon-APIs/#/Beacon/publishBlindedBlock
376341

377-
proc publishBlindedBlockV2*(
342+
proc publishJsonBlindedBlockV2*(
378343
client: RestClientRef,
379344
broadcast_validation: Option[BroadcastValidationType],
380345
blck: ForkySignedBlindedBeaconBlock

beacon_chain/validator_client/api.nim

Lines changed: 9 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# beacon_chain
2-
# Copyright (c) 2021-2024 Status Research & Development GmbH
2+
# Copyright (c) 2021-2025 Status Research & Development GmbH
33
# Licensed and distributed under either of
44
# * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
55
# * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
@@ -2734,26 +2734,13 @@ proc publishBlindedBlockV2*(
27342734
ViableNodeStatus,
27352735
{BeaconNodeRole.BlockProposalPublish}):
27362736
case data.kind
2737-
of ConsensusFork.Phase0:
2738-
publishBlindedBlockV2(it, some(broadcast_validation),
2739-
data.phase0Data)
2740-
of ConsensusFork.Altair:
2741-
publishBlindedBlockV2(it, some(broadcast_validation),
2742-
data.altairData)
2743-
of ConsensusFork.Bellatrix:
2744-
publishBlindedBlockV2(it, some(broadcast_validation),
2745-
data.bellatrixData)
2746-
of ConsensusFork.Capella:
2747-
publishBlindedBlockV2(it, some(broadcast_validation),
2748-
data.capellaData)
2749-
of ConsensusFork.Deneb:
2750-
publishBlindedBlockV2(it, some(broadcast_validation),
2751-
data.denebData)
2737+
of ConsensusFork.Phase0 .. ConsensusFork.Deneb:
2738+
raiseAssert "Unable to publish block of that kind"
27522739
of ConsensusFork.Electra:
2753-
publishBlindedBlockV2(it, some(broadcast_validation),
2740+
publishJsonBlindedBlockV2(it, some(broadcast_validation),
27542741
data.electraData)
27552742
of ConsensusFork.Fulu:
2756-
publishBlindedBlockV2(it, some(broadcast_validation),
2743+
publishJsonBlindedBlockV2(it, some(broadcast_validation),
27572744
data.fuluData)
27582745
do:
27592746
if apiResponse.isErr():
@@ -2793,26 +2780,13 @@ proc publishBlindedBlockV2*(
27932780
ViableNodeStatus,
27942781
{BeaconNodeRole.BlockProposalPublish}):
27952782
case data.kind
2796-
of ConsensusFork.Phase0:
2797-
publishBlindedBlockV2(it, some(broadcast_validation),
2798-
data.phase0Data)
2799-
of ConsensusFork.Altair:
2800-
publishBlindedBlockV2(it, some(broadcast_validation),
2801-
data.altairData)
2802-
of ConsensusFork.Bellatrix:
2803-
publishBlindedBlockV2(it, some(broadcast_validation),
2804-
data.bellatrixData)
2805-
of ConsensusFork.Capella:
2806-
publishBlindedBlockV2(it, some(broadcast_validation),
2807-
data.capellaData)
2808-
of ConsensusFork.Deneb:
2809-
publishBlindedBlockV2(it, some(broadcast_validation),
2810-
data.denebData)
2783+
of ConsensusFork.Phase0 .. ConsensusFork.Deneb:
2784+
raiseAssert "Unable to publish block of that kind"
28112785
of ConsensusFork.Electra:
2812-
publishBlindedBlockV2(it, some(broadcast_validation),
2786+
publishJsonBlindedBlockV2(it, some(broadcast_validation),
28132787
data.electraData)
28142788
of ConsensusFork.Fulu:
2815-
publishBlindedBlockV2(it, some(broadcast_validation),
2789+
publishJsonBlindedBlockV2(it, some(broadcast_validation),
28162790
data.fuluData)
28172791
do:
28182792
if apiResponse.isErr():

0 commit comments

Comments
 (0)