Skip to content

Commit 2545d1d

Browse files
authored
remove incorrect block gossip validation condition (#4044)
* remove incorrect block gossip validation condition * clarify explanation
1 parent d7e9c33 commit 2545d1d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

beacon_chain/gossip_processing/gossip_validation.nim

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,12 @@ template validateBeaconBlockBellatrix(
210210
quarantine[].addUnviable(signed_beacon_block.root)
211211
return errReject("BeaconBlock: mismatched execution payload timestamp")
212212

213-
if signed_beacon_block.message.parent_root in dag.optimisticRoots:
214-
# Definitely don't mark this as unviable.
215-
# [REJECT] The block's parent (defined by `block.parent_root`) passes all
216-
# validation (excluding execution node verification of the
217-
# `block.body.execution_payload`).
218-
return errReject("BeaconBlock: execution payload would build on optimistic parent")
213+
# The condition:
214+
# [REJECT] The block's parent (defined by `block.parent_root`) passes all
215+
# validation (excluding execution node verification of the
216+
# `block.body.execution_payload`).
217+
# cannot occur here, because Nimbus's optimistic sync waits for either
218+
# `ACCEPTED` or `SYNCING` from the EL to get this far.
219219

220220
# https://github.com/ethereum/consensus-specs/blob/v1.1.9/specs/phase0/p2p-interface.md#beacon_block
221221
# https://github.com/ethereum/consensus-specs/blob/v1.2.0-rc.3/specs/bellatrix/p2p-interface.md#beacon_block

0 commit comments

Comments
 (0)