simplify column quarantine check (#7076)

* simplify column quarantine check

* lint

Author: agnxsh

beacon_chain/consensus_object_pools/data_column_quarantine.nim

@@ -1,5 +1,5 @@
 # beacon_chain
-# Copyright (c) 2018-2024 Status Research & Development GmbH
+# Copyright (c) 2018-2025 Status Research & Development GmbH
 # Licensed and distributed under either of
 #   * MIT license (license terms in the root directory or at https://opensource.org/licenses/MIT).
 #   * Apache v2 license (license terms in the root directory or at https://www.apache.org/licenses/LICENSE-2.0).
@@ -131,21 +131,12 @@ func hasMissingDataColumns*(quarantine: DataColumnQuarantine,
 
   # This method shall be actively used by the `RequestManager` to
   # root request columns over RPC.
-  var col_counter = 0
-  for idx in quarantine.custody_columns:
-    let dc_identifier =
-      DataColumnIdentifier(
-        block_root: blck.root,
-        index: idx)
-    if dc_identifier notin quarantine.data_columns:
-      inc col_counter
-  if quarantine.supernode and col_counter != NUMBER_OF_COLUMNS:
-    return false
-  elif quarantine.supernode == false and
-      col_counter != max(SAMPLES_PER_SLOT, CUSTODY_REQUIREMENT):
-    return false
+  let collected_columns =
+    quarantine.gatherDataColumns(blck.root)
+  if collected_columns.len == quarantine.custody_columns.len:
+    true
   else:
-    return true
+    false
 
 func hasEnoughDataColumns*(quarantine: DataColumnQuarantine,
     blck: fulu.SignedBeaconBlock): bool =
@@ -157,21 +148,18 @@ func hasEnoughDataColumns*(quarantine: DataColumnQuarantine,
   # check it, and thereby check column reconstructability, right from
   # gossip validation, consequently populating the quarantine with
   # rest of the data columns.
+  let
+    collectedColumns = quarantine.gatherDataColumns(blck.root)
   if quarantine.supernode:
-    let
-      collectedColumns = quarantine.gatherDataColumns(blck.root)
     if collectedColumns.len >= (quarantine.custody_columns.len div 2):
-      return true
+      true
+    else:
+      false
   else:
-    for i in quarantine.custody_columns:
-      let dc_identifier =
-        DataColumnIdentifier(
-          block_root: blck.root,
-          index: i)
-      if dc_identifier notin quarantine.data_columns:
-        return false
-      else:
-        return true
+    if collectedColumns.len == quarantine.custody_columns.len:
+      true
+    else:
+      false
 
 func dataColumnFetchRecord*(quarantine: DataColumnQuarantine,
                             blck: fulu.SignedBeaconBlock):