Skip to content

Commit ff823f4

Browse files
authored
avoid building main binaries twice (#4092)
we can just build everything with trace logging
1 parent ee1465e commit ff823f4

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -209,22 +209,13 @@ jobs:
209209
run: |
210210
scripts/setup_scenarios.sh fixturesCache
211211
212-
- name: Smoke test the Beacon Node and Validator Client with all tracing enabled
212+
- name: Build binaries (with trace logging enabled)
213213
run: |
214214
if [[ "${{ matrix.branch }}" == "version-1-6" ]]; then
215215
# change to "|| true" to hide the CI failures in GitHub's UI (escape hatch if a blocker is detected in 1.6)
216-
${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE nimbus_beacon_node nimbus_validator_client || false
216+
${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE || false
217217
else
218-
${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE nimbus_beacon_node nimbus_validator_client
219-
fi
220-
221-
- name: Build all tools
222-
run: |
223-
if [[ "${{ matrix.branch }}" == "version-1-6" ]]; then
224-
# change to "|| true" to hide the CI failures in GitHub's UI (escape hatch if a blocker is detected in 1.6)
225-
${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} || false
226-
else
227-
${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }}
218+
${make_cmd} -j ${ncpu} V=1 NIM_COMMIT=${{ matrix.branch }} LOG_LEVEL=TRACE
228219
fi
229220
# The Windows image runs out of disk space, so make some room
230221
rm -rf nimcache

0 commit comments

Comments
 (0)