e2e: fixes for unpin messages and community logo

Author: yevh-berdnyk

test/appium/tests/deep_links/test_deep_and_universal_links.py

@@ -78,7 +78,10 @@ def test_links_deep_links_profile(self):
     def test_deep_links_communities(self):
         closed_community_name, snt_community_name = "closed community", "SNT community"
         self.sign_in.reopen_app(sign_in=True, user_name=self.username)
-        self.home.navigate_to_communities_view()
+        if self.home.communities_tab.is_element_displayed():
+            self.home.communities_tab.click()
+        else:
+            self.home.navigate_to_communities_view()
         self.home.create_community(community_type="closed")
         if not self.community_view.community_options_button.is_element_displayed():
             self.home.get_chat(closed_community_name, community=True).click()

test/appium/tests/private_chats/test_group_chat.py

@@ -357,8 +357,6 @@ def _check_messages(index):
         self.errors.verify_no_errors()
 
     @marks.testrail_id(702732)
-    @marks.xfail(
-        reason="Can not unpin messages from pinned messages menu - https://github.com/status-im/status-mobile/issues/22497")
     def test_group_chat_pin_messages(self):
         [self.homes[i].navigate_back_to_home_view() for i in range(3)]
         [self.homes[i].get_chat(self.chat_name).click() for i in range(3)]
@@ -410,8 +408,8 @@ def test_group_chat_pin_messages(self):
         self.chats[0].view_pinned_messages_button.click_until_presence_of_element(self.chats[0].pinned_messages_list)
         if self.chats[0].pinned_messages_list.message_element_by_text(self.message_4).is_element_displayed():
             self.errors.append(self.chats[0], "Can pin more than 3 messages")
-        self.chats[0].tap_by_coordinates(500, 100)
-        self.chats[0].pin_message(self.message_2, action='unpin-from-chat')
+        self.chats[0].pinned_messages_list.message_element_by_text(self.message_2).long_press_without_release()
+        self.chats[0].element_by_translation_id('unpin-from-chat').click()
         self.chats[0].pin_message(self.message_4, 'pin-to-chat')
         for chat in self.chats[0], self.chats[1]:
             if not chat.chat_element_by_text(self.message_4).pinned_by_label.is_element_displayed(30):

test/appium/tests/private_chats/test_one_to_one_chat.py

@@ -186,10 +186,8 @@ def test_1_1_chat_emoji_send_reply_and_open_link(self):
 
         self.errors.verify_no_errors()
 
-    # @marks.smoke # ToDo: return to the smoke suite when https://github.com/status-im/status-mobile/issues/22497 is fixed
+    @marks.smoke
     @marks.testrail_id(702731)
-    @marks.xfail(
-        reason="Can not unpin messages from pinned messages menu - https://github.com/status-im/status-mobile/issues/22497")
     def test_1_1_chat_pin_messages(self):
         self.home_1.just_fyi("Check that Device1 can pin own message in 1-1 chat")
         self.chat_2.navigate_to_chats_view()
@@ -243,10 +241,9 @@ def test_1_1_chat_pin_messages(self):
                 or self.chat_1.pinned_messages_list.message_element_by_text(self.message_4).is_element_displayed():
             self.errors.append(self.chat_1, "Can pin more than 3 messages in chat")
         else:
-            unpin_element = self.chat_1.element_by_translation_id('unpin-from-chat')
             self.chat_1.pinned_messages_list.message_element_by_text(self.message_2).long_press_without_release()
             self.home_1.just_fyi("Unpin one message so that another could be pinned")
-            unpin_element.click_until_absense_of_element(desired_element=unpin_element)
+            self.chat_1.element_by_translation_id('unpin-from-chat').click()
             self.chat_1.pin_message(self.message_4, 'pin-to-chat')
             for chat in self.chat_1, self.chat_2:
                 if not chat.chat_element_by_text(self.message_4).pinned_by_label.is_element_displayed(30):
@@ -263,9 +260,8 @@ def test_1_1_chat_pin_messages(self):
         self.chat_1.tap_by_coordinates(500, 100)
         self.chat_1.view_pinned_messages_button.click_until_presence_of_element(self.chat_1.pinned_messages_list)
         pinned_message = self.chat_1.pinned_messages_list.message_element_by_text(self.message_4)
-        unpin_element = self.chat_1.element_by_translation_id("unpin-from-chat")
         pinned_message.long_press_without_release()
-        unpin_element.click_until_absense_of_element(unpin_element)
+        self.chat_1.element_by_translation_id("unpin-from-chat").click()
         try:
             self.chat_2.chat_element_by_text(self.message_4).pinned_by_label.wait_for_invisibility_of_element(60)
         except TimeoutException:

test/appium/views/chat_view.py

@@ -325,7 +325,8 @@ def __init__(self, driver):
         self.close_community_view_button = Button(self.driver, accessibility_id="back-button")
         self.community_title = Text(self.driver, accessibility_id="community-title")
         self.community_logo = BaseElement(
-            self.driver, xpath="//*[@content-desc='community-title']/preceding-sibling::*/android.widget.ImageView")
+            self.driver,
+            xpath="//*[*[*[@content-desc='community-title']]]/following-sibling::*/android.widget.ImageView")
         self.community_description_text = Text(self.driver, accessibility_id="community-description-text")
         self.community_status_joined = Text(self.driver, accessibility_id="status-tag-positive")
         self.community_status_pending = Text(self.driver, accessibility_id="status-tag-pending")