e2e: fixes for pinning messages tests

Author: yevh-berdnyk

test/appium/tests/communities/test_community.py

@@ -230,6 +230,7 @@ def test_restore_multiaccount_with_waku_backup_remove_profile_switch(self):
 
         self.home.just_fyi("Check that can remove user from logged out state")
         self.home.reopen_app(sign_in=False)
+        self.sign_in.show_profiles_button.click_if_shown()
         user_card = self.sign_in.get_user_profile_by_name(username=recover_user_name)
         user_card.open_user_options()
         self.sign_in.remove_profile_button.click()
@@ -954,7 +955,7 @@ def test_community_mentions_push_notification(self):
         self.device_2.just_fyi("Sender checks the reaction for a message with a mention")
         try:
             self.channel_2.chat_element_by_text(self.username_1).emojis_below_message(
-                emoji="sad").wait_for_element_text(1)
+                emoji="sad").wait_for_element_text(text=1, wait_time=60)
         except (Failed, NoSuchElementException):
             self.errors.append(self.channel_2, "Message reaction is not shown for the sender")
 
@@ -1013,7 +1014,7 @@ def test_community_markdown_support(self):
                     self.channel_2,
                     '%s is not displayed with markdown in community channel for the sender \n' % message)
 
-            if not self.channel_1.chat_element_by_text(message).is_element_displayed():
+            if not self.channel_1.chat_element_by_text(message).is_element_displayed(60):
                 self.errors.append(
                     self.channel_1,
                     '%s is not displayed with markdown in community channel for the recipient \n' % message)
@@ -1034,7 +1035,7 @@ def test_community_markdown_support(self):
                 self.errors.append(
                     self.chat_1, '%s is not displayed with markdown in 1-1 chat for the sender (device 1) \n' % message)
 
-            if not self.chat_2.chat_element_by_text(message).is_element_displayed(30):
+            if not self.chat_2.chat_element_by_text(message).is_element_displayed(60):
                 self.errors.append(
                     self.chat_2,
                     '%s is not displayed with markdown in 1-1 chat for the recipient (device 2) \n' % message)

test/appium/tests/private_chats/test_group_chat.py

@@ -125,9 +125,9 @@ def test_group_chat_reactions(self):
         def _check_reactions_count(chat_view_index):
             self.chats[chat_view_index].just_fyi("Checking reactions count for each group member and admin")
             chat_element = self.chats[chat_view_index].chat_element_by_text(message)
-            chat_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(2)
-            chat_element.emojis_below_message(emoji="love").wait_for_element_text(1)
-            chat_element.emojis_below_message(emoji="laugh").wait_for_element_text(1)
+            chat_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(text=2, wait_time=60)
+            chat_element.emojis_below_message(emoji="love").wait_for_element_text(text=1, wait_time=60)
+            chat_element.emojis_below_message(emoji="laugh").wait_for_element_text(text=1, wait_time=60)
 
         self.loop.run_until_complete(run_in_parallel((
             (_check_reactions_count, {'chat_view_index': 0}),
@@ -181,9 +181,9 @@ def _check_reactions_count_after_change(chat_view_index):
                 "Checking reactions count for each group member and admin after they were changed")
             chat_element = self.chats[chat_view_index].chat_element_by_text(message)
             try:
-                chat_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(1)
-                chat_element.emojis_below_message(emoji="love").wait_for_element_text(1)
-                chat_element.emojis_below_message(emoji="sad").wait_for_element_text(2)
+                chat_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(text=1, wait_time=60)
+                chat_element.emojis_below_message(emoji="love").wait_for_element_text(text=1, wait_time=60)
+                chat_element.emojis_below_message(emoji="sad").wait_for_element_text(text=2, wait_time=60)
             except (Failed, NoSuchElementException):
                 self.errors.append(self.chats[chat_view_index],
                                    "Incorrect reactions count for %s after changing the reactions" % self.usernames[
@@ -203,9 +203,9 @@ def _check_reactions_count_after_change(chat_view_index):
         self.chats[0].just_fyi("Admin checks reactions count after relogin")
         message_element = self.chats[0].chat_element_by_text(message)
         try:
-            message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(1)
-            message_element.emojis_below_message(emoji="love").wait_for_element_text(1)
-            message_element.emojis_below_message(emoji="sad").wait_for_element_text(2)
+            message_element.emojis_below_message(emoji="thumbs-up").wait_for_element_text(text=1, wait_time=60)
+            message_element.emojis_below_message(emoji="love").wait_for_element_text(text=1, wait_time=60)
+            message_element.emojis_below_message(emoji="sad").wait_for_element_text(text=2, wait_time=60)
         except (Failed, NoSuchElementException):
             self.errors.append(self.chats[0], "Incorrect reactions count after relogin")
 
@@ -349,7 +349,7 @@ def _proceed_to_chat(index):
         def _check_messages(index):
             self.chats[index].just_fyi("Check that messages are shown for user %s" % self.usernames[index])
             for message_text in (message_1, message_2):
-                if not self.chats[index].chat_element_by_text(message_text).is_element_displayed(30):
+                if not self.chats[index].chat_element_by_text(message_text).is_element_displayed(60):
                     self.errors.append(self.chats[index], '%s if not shown for device %s' % (message_text, index))
 
         self.loop.run_until_complete(run_in_parallel((
@@ -361,6 +361,8 @@ def _check_messages(index):
         self.errors.verify_no_errors()
 
     @marks.testrail_id(702732)
+    @marks.xfail(
+        reason="Can not unpin messages from pinned messages menu - https://github.com/status-im/status-mobile/issues/22497")
     def test_group_chat_pin_messages(self):
         [self.homes[i].navigate_back_to_home_view() for i in range(3)]
         [self.homes[i].get_chat(self.chat_name).click() for i in range(3)]
@@ -372,6 +374,7 @@ def test_group_chat_pin_messages(self):
         self.chats[0].send_message(self.message_1)
         self.chats[0].pin_message(self.message_1, "pin-to-chat")
         for chat in self.chats[0], self.chats[1]:
+            chat.chat_element_by_text(self.message_1).wait_for_visibility_of_element(60)
             if not chat.chat_element_by_text(self.message_1).pinned_by_label.is_element_displayed(30):
                 self.errors.append(chat, "Message 1 is not pinned in group chat!")
 
@@ -401,17 +404,18 @@ def test_group_chat_pin_messages(self):
             self.chats[0].send_message(message)
             self.chats[0].pin_message(message, 'pin-to-chat')
             for chat in self.chats[0], self.chats[1]:
+                chat.chat_element_by_text(message).wait_for_visibility_of_element(60)
                 if not chat.chat_element_by_text(message).pinned_by_label.is_element_displayed(30):
                     self.errors.append(chat, "%s is not pinned in group chat!" % message)
 
         self.chats[0].just_fyi("Check that a user can not pin more than 3 messages")
         self.chats[0].send_message(self.message_4)
         self.chats[0].pin_message(self.message_4, 'pin-to-chat')
         self.chats[0].view_pinned_messages_button.click_until_presence_of_element(self.chats[0].pinned_messages_list)
-        unpin_element = self.chats[0].element_by_translation_id('unpin-from-chat')
-        self.chats[0].pinned_messages_list.message_element_by_text(self.message_2).long_press_without_release()
-        unpin_element.click_until_absense_of_element(desired_element=unpin_element)
-        self.chats[0].chat_element_by_text(self.message_4).click()
+        if self.chats[0].pinned_messages_list.message_element_by_text(self.message_4).is_element_displayed():
+            self.errors.append(self.chats[0], "Can pin more than 3 messages")
+        self.chats[0].tap_by_coordinates(500, 100)
+        self.chats[0].pin_message(self.message_2, action='unpin-from-chat')
         self.chats[0].pin_message(self.message_4, 'pin-to-chat')
         for chat in self.chats[0], self.chats[1]:
             if not chat.chat_element_by_text(self.message_4).pinned_by_label.is_element_displayed(30):
@@ -438,7 +442,7 @@ def _check_pinned_messages(index):
                 else:
                     self.errors.append(self.chats[index],
                                        "Message '%s' is missed on Pinned messages list for user %s" % (
-                                           message, self.usernames[index])
+                                           message_text, self.usernames[index])
                                        )
 
         self.loop.run_until_complete(run_in_parallel((

test/appium/tests/private_chats/test_one_to_one_chat.py

@@ -47,7 +47,7 @@ def prepare_devices(self):
             "Message 1", "Message 2", "Message 3", "Message 4"
 
     @marks.smoke
-    @marks.xfail(reason="Might fail from time to time as reaction are set too slowly") # TODO: needs investigation
+    @marks.xfail(reason="Might fail from time to time as reaction are set too slowly")  # TODO: needs investigation
     @marks.testrail_id(702730)
     def test_1_1_chat_message_reaction(self):
         message_from_sender = "Message sender"
@@ -186,25 +186,28 @@ def test_1_1_chat_emoji_send_reply_and_open_link(self):
 
         self.errors.verify_no_errors()
 
-    @marks.smoke
+    # @marks.smoke # ToDo: return to the smoke suite when https://github.com/status-im/status-mobile/issues/22497 is fixed
     @marks.testrail_id(702731)
+    @marks.xfail(
+        reason="Can not unpin messages from pinned messages menu - https://github.com/status-im/status-mobile/issues/22497")
     def test_1_1_chat_pin_messages(self):
         self.home_1.just_fyi("Check that Device1 can pin own message in 1-1 chat")
         self.chat_2.navigate_back_to_home_view()
         self.home_2.chats_tab.click()
         self.home_2.get_chat(self.username_1).click()
         self.chat_1.send_message(self.message_1)
         self.chat_1.send_message(self.message_2)
-        self.chat_1.chat_element_by_text(self.message_1).wait_for_status_to_be("Delivered")
-        self.chat_1.pin_message(self.message_1, 'pin-to-chat')
+        self.chat_1.chat_element_by_text(self.message_1).wait_for_status_to_be(expected_status="Delivered", timeout=60)
+        self.chat_1.pin_message(self.message_1, action='pin-to-chat')
         if not self.chat_1.chat_element_by_text(self.message_1).pinned_by_label.is_element_displayed():
             self.drivers[0].fail("Message is not pinned!")
 
         self.home_1.just_fyi("Check that Device2 can pin Device1 message in 1-1 chat and two pinned "
                              "messages are in Device1 profile")
-        self.chat_2.pin_message(self.message_2, 'pin-to-chat')
+        self.chat_2.pin_message(self.message_2, action='pin-to-chat')
         for chat_number, chat in enumerate([self.chat_1, self.chat_2]):
             chat.pinned_messages_count.wait_for_element_text(text="2",
+                                                             wait_time=60,
                                                              message="Pinned messages count is not 2 as expected!")
 
             chat.just_fyi("Check pinned messages are visible in Pinned panel for user %s" % (chat_number + 1))
@@ -232,8 +235,8 @@ def test_1_1_chat_pin_messages(self):
         self.home_1.just_fyi("Check that Device1 can not pin more than 3 messages and 'Unpin' dialog appears")
         for message in (self.message_3, self.message_4):
             self.chat_1.send_message(message)
-            self.chat_1.chat_element_by_text(message).wait_for_status_to_be("Delivered")
-            self.chat_1.pin_message(message, 'pin-to-chat')
+            self.chat_1.chat_element_by_text(message).wait_for_status_to_be(expected_status="Delivered", timeout=60)
+            self.chat_1.pin_message(message, action='pin-to-chat')
         # if not self.chat_1.pin_limit_popover.is_element_displayed():
         #     self.errors.append("Pin limit popover is not displayed when pinning more than 3 messages")
         self.chat_1.view_pinned_messages_button.click_until_presence_of_element(self.chat_1.pinned_messages_list)
@@ -250,30 +253,28 @@ def test_1_1_chat_pin_messages(self):
                 if not chat.chat_element_by_text(self.message_4).pinned_by_label.is_element_displayed(30):
                     self.errors.append(chat, "Message 4 is not pinned in chat after unpinning previous one")
 
-        self.home_1.just_fyi("Check pinned messages are visible in Pinned panel for both users")
         for chat_number, chat in enumerate([self.chat_1, self.chat_2]):
+            chat.just_fyi("Check pinned messages are visible in Pinned panel for user %s" % (chat_number + 1))
             count = chat.pinned_messages_count.text
             if count != '3':
                 self.errors.append(chat,
                                    "Pinned messages count is %s but should be 3 for user %s" % (count, chat_number + 1))
 
         self.home_1.just_fyi("Unpin one message and check it's unpinned for another user")
-        self.chat_2.tap_by_coordinates(500, 100)
-
+        self.chat_1.tap_by_coordinates(500, 100)
         self.chat_1.view_pinned_messages_button.click_until_presence_of_element(self.chat_1.pinned_messages_list)
         pinned_message = self.chat_1.pinned_messages_list.message_element_by_text(self.message_4)
-
         unpin_element = self.chat_1.element_by_translation_id("unpin-from-chat")
         pinned_message.long_press_without_release()
         unpin_element.click_until_absense_of_element(unpin_element)
-        # try:
-        #     self.chat_2.chat_element_by_text(self.message_4).pinned_by_label.wait_for_invisibility_of_element()
-        # except TimeoutException:
-        #     self.errors.append("Message_4 is not unpinned!")
+        try:
+            self.chat_2.chat_element_by_text(self.message_4).pinned_by_label.wait_for_invisibility_of_element(60)
+        except TimeoutException:
+            self.errors.append(self.chat_2, "'%s' is not unpinned!" % self.message_4)
 
         for chat_number, chat in enumerate([self.chat_1, self.chat_2]):
             try:
-                chat.pinned_messages_count.wait_for_element_text(text='2', wait_time=20)
+                chat.pinned_messages_count.wait_for_element_text(text='2', wait_time=60)
             except Failed:
                 self.errors.append(
                     chat, "Pinned messages count is not 2 after unpinning the last pinned message for user %s" % (

test/appium/views/chat_view.py

@@ -332,7 +332,9 @@ def __init__(self, driver):
 
     def join_community(self, password=common_password, open_community=True):
         self.driver.info("Joining community")
-        ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
+        chat_element = ChatView(self.driver).chat_element_by_text("https://status.app/c/")
+        chat_element.wait_for_visibility_of_element(60)
+        chat_element.click_on_link_inside_message_body()
         self.join_button.wait_and_click(120)
         self.slide_to_request_to_join_button.swipe_right_on_element(width_percentage=16)
         self.password_input.send_keys(password)
@@ -649,7 +651,10 @@ def send_message(self, message: str = 'test message', wait_chat_input_sec=5):
     def pin_message(self, message, action="pin"):
         self.driver.info("Looking for message '%s' pin" % message)
         element = self.element_by_translation_id(action)
-        self.chat_element_by_text(message).long_press_without_release()
+        self.chat_element_by_text(message).long_press_until_element_is_shown(element)
+        if not element.is_element_displayed():
+            self.driver.fail(
+                "Device %s: Action '%s' is not displayed for the message '%s'" % (self.driver.number, action, message))
         element.click_until_absense_of_element(element)
 
     def edit_message_in_chat(self, message_to_edit, message_to_update):

test/appium/views/sign_in_view.py

@@ -103,6 +103,7 @@ def recover_access(self, passphrase: str, password: str = common_password, enabl
                 self.create_profile_button.click()
                 self.maybe_later_button.wait_and_click()
             else:
+                self.show_profiles_button.click_if_shown()
                 self.plus_profiles_button.click()
                 self.create_new_profile_button.click()
             self.use_recovery_phrase_button.click()
@@ -122,6 +123,7 @@ def sync_profile(self, sync_code: str, first_user: bool = True):
             self.log_in_button.click()
             self.maybe_later_button.click()
         else:
+            self.show_profiles_button.click_if_shown()
             self.plus_profiles_button.click()
             self.sync_or_recover_new_profile_button.click()
         self.log_in_by_syncing_button.click()
@@ -134,6 +136,7 @@ def sync_profile(self, sync_code: str, first_user: bool = True):
 
     def sign_in(self, user_name, password=common_password):
         self.driver.info("## Sign in (password: %s)" % password, device=False)
+        self.show_profiles_button.click_if_shown()
         self.get_user_profile_by_name(user_name).click()
         self.password_input.wait_for_visibility_of_element(10)
         self.password_input.send_keys(password)