Skip to content

Commit e121caa

Browse files
[#22385] fix: tx setting current value as a range (#22568)
* [#22385] fix: tx setting current value as a range * [#22385] fix: priority fee value issue for custom settings * [#22385] fix: max priority fee be the same as desktop
1 parent 54d6978 commit e121caa

File tree

5 files changed

+23
-13
lines changed

5 files changed

+23
-13
lines changed

src/status_im/contexts/wallet/common/transaction_settings/max_fee/view.cljs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,11 @@
2929
[]
3030
(let [network-base-fee (rf/sub [:wallet/tx-settings-network-base-fee-route])
3131
max-base-fee (rf/sub [:wallet/tx-settings-max-base-fee])
32-
priority-fee (rf/sub [:wallet/tx-settings-priority-fee])
32+
priority-fee (rf/sub [:wallet/tx-settings-custom-priority-fee])
3333
conditions (partial hint-and-status network-base-fee priority-fee)]
3434
[transaction-settings/custom-setting-screen
3535
{:screen-title (i18n/label :t/max-base-fee)
36-
:token-sybmol :gwei
36+
:token-symbol :gwei
3737
:conditions-fn conditions
3838
:current max-base-fee
3939
:info-title (i18n/label :t/max-base-fee)

src/status_im/contexts/wallet/common/transaction_settings/priority_fee/view.cljs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
[utils.re-frame :as rf]))
77

88
(defn hint-and-status
9-
[priority-fee spectrum max-base-fee entered-value]
9+
[spectrum max-base-fee entered-value]
1010
(let [upper-limit-exceeded? (> entered-value (:high spectrum))
1111
lower-limit-exceeded? (< entered-value (:low spectrum))]
1212
(cond
@@ -19,20 +19,19 @@
1919
:status :warning}
2020
lower-limit-exceeded? {:hint-text (i18n/label :t/priority-fee-lower spectrum)
2121
:status :warning}
22-
:else {:hint-text (i18n/label :t/priority-fee-current
23-
{:current priority-fee})
22+
:else {:hint-text (i18n/label :t/priority-fee-current spectrum)
2423
:status :default})))
2524

2625
(defn view
2726
[]
28-
(let [priority-fee (rf/sub [:wallet/tx-settings-priority-fee])
27+
(let [priority-fee (rf/sub [:wallet/tx-settings-custom-priority-fee])
2928
max-base-fee (rf/sub [:wallet/tx-settings-max-base-fee])
3029
spectrum {:low (rf/sub [:wallet/tx-settings-suggested-min-priority-fee])
3130
:high (rf/sub [:wallet/tx-settings-suggested-max-priority-fee])}
32-
conditions (partial hint-and-status priority-fee spectrum max-base-fee)]
31+
conditions (partial hint-and-status spectrum max-base-fee)]
3332
[transaction-settings/custom-setting-screen
3433
{:screen-title (i18n/label :t/priority-fee)
35-
:token-sybmol :gwei
34+
:token-symbol :gwei
3635
:conditions-fn conditions
3736
:current priority-fee
3837
:info-title (i18n/label :t/priority-fee)

src/status_im/contexts/wallet/common/transaction_settings/view.cljs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
(defn custom-settings-sheet
1313
[_]
1414
(let [max-base-fee (rf/sub [:wallet/tx-settings-max-base-fee])
15-
priority-fee (rf/sub [:wallet/tx-settings-priority-fee])
15+
priority-fee (rf/sub [:wallet/tx-settings-custom-priority-fee])
1616
max-gas-amount (rf/sub [:wallet/tx-settings-gas-amount])
1717
nonce (rf/sub [:wallet/tx-settings-nonce])
1818
account-color (rf/sub [:wallet/current-viewing-account-color])

src/status_im/subs/wallet/wallet.cljs

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -977,6 +977,18 @@
977977
(fn [[gas-fees value-set-by-user]]
978978
(or value-set-by-user (:tx-priority-fee gas-fees))))
979979

980+
(rf/reg-sub
981+
:wallet/tx-settings-custom-priority-fee
982+
:<- [:wallet/tx-settings-fee-mode]
983+
:<- [:wallet/tx-settings-gas-fees]
984+
:<- [:wallet/tx-settings-priority-fee-user]
985+
:<- [:wallet/tx-settings-suggested-min-priority-fee]
986+
(fn [[fee-mode gas-fees value-set-by-user min-priority-fee]]
987+
(cond
988+
value-set-by-user value-set-by-user
989+
(= :tx-fee-mode/custom fee-mode) (:tx-priority-fee gas-fees)
990+
:else min-priority-fee)))
991+
980992
(rf/reg-sub
981993
:wallet/tx-settings-gas-amount
982994
:<- [:wallet/tx-settings-gas-amount-route]
@@ -1000,9 +1012,8 @@
10001012
(rf/reg-sub
10011013
:wallet/tx-settings-suggested-max-priority-fee
10021014
:<- [:wallet/tx-settings-gas-fees]
1003-
:<- [:wallet/tx-settings-max-base-fee]
1004-
(fn [[gas-fees max-base-fee]]
1005-
(min max-base-fee (:suggested-max-priority-fee gas-fees))))
1015+
(fn [gas-fees]
1016+
(:suggested-max-priority-fee gas-fees)))
10061017

10071018
(rf/reg-sub
10081019
:wallet/tx-settings-suggested-min-priority-fee

translations/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2096,7 +2096,7 @@
20962096
"principles": "Principles",
20972097
"priority": "Priority",
20982098
"priority-fee": "Priority fee",
2099-
"priority-fee-current": "Current: {{current}}",
2099+
"priority-fee-current": "Current: {{low}} - {{high}}",
21002100
"priority-fee-higher": "Higher than necessary: {{low}} - {{high}}",
21012101
"priority-fee-higher-max-base": "Higher than max base fee: {{max-base-fee}}",
21022102
"priority-fee-lower": "Lower than suggested: {{low}} - {{high}}",

0 commit comments

Comments
 (0)