fix React has detected a change in the order of Hooks (#22446)

Author: Parveshdhull

src/legacy/status_im/ui/screens/communities/members.cljs

@@ -111,32 +111,31 @@
 
 (defn view
   []
-  (let [{:keys [community-id]} (quo.context/use-screen-params)]
+  (let [{:keys [community-id]} (quo.context/use-screen-params)
+        my-public-key (rf/sub [:multiaccount/public-key])
+        {:keys [permissions
+                can-manage-users?
+                admin]}
+        (rf/sub [:communities/community community-id])
+        sorted-members (rf/sub [:communities/sorted-community-members
+                                community-id])]
     (rn/use-mount
      #(rf/dispatch [:community/fetch-requests-to-join community-id]))
-    (fn []
-      (let [my-public-key (rf/sub [:multiaccount/public-key])
-            {:keys [permissions
-                    can-manage-users?
-                    admin]}
-            (rf/sub [:communities/community community-id])
-            sorted-members (rf/sub [:communities/sorted-community-members
-                                    community-id])]
-        [:<>
-         [topbar/topbar
-          {:title    (i18n/label :t/community-members-title)
-           :subtitle (str (count sorted-members))}]
-         [header community-id]
-         (when (and can-manage-users? (= constants/community-on-request-access (:access permissions)))
-           [requests-to-join community-id])
-         [rn/flat-list
-          {:data        sorted-members
-           :render-data {:community-id      community-id
-                         :my-public-key     my-public-key
-                         :can-kick-users?   (and can-manage-users?
-                                                 (not= (:access permissions)
-                                                       constants/community-no-membership-access))
-                         :can-manage-users? can-manage-users?
-                         :admin?            admin}
-           :key-fn      identity
-           :render-fn   render-member}]]))))
+    [:<>
+     [topbar/topbar
+      {:title    (i18n/label :t/community-members-title)
+       :subtitle (str (count sorted-members))}]
+     [header community-id]
+     (when (and can-manage-users? (= constants/community-on-request-access (:access permissions)))
+       [requests-to-join community-id])
+     [rn/flat-list
+      {:data        sorted-members
+       :render-data {:community-id      community-id
+                     :my-public-key     my-public-key
+                     :can-kick-users?   (and can-manage-users?
+                                             (not= (:access permissions)
+                                                   constants/community-no-membership-access))
+                     :can-manage-users? can-manage-users?
+                     :admin?            admin}
+       :key-fn      identity
+       :render-fn   render-member}]]))

src/status_im/common/emoji_picker/view.cljs

@@ -170,8 +170,7 @@
 
 (defn view
   [_]
-  (let [{:keys [on-select]}       (quo.context/use-screen-params)
-        scroll-ref                (atom nil)
+  (let [scroll-ref                (atom nil)
         set-scroll-ref            #(reset! scroll-ref %)
         search-text               (reagent/atom "")
         filtered-data             (reagent/atom nil)
@@ -197,14 +196,15 @@
                                       :active-category                active-category
                                       :should-update-active-category? (nil? @filtered-data)}))]
     (fn [sheet-opts]
-      [sheet-view
-       (assoc sheet-opts
-              :search-active?            (pos? (count @search-text))
-              :on-change-text            on-change-text
-              :clear-states              clear-states
-              :filtered-data             @filtered-data
-              :set-scroll-ref            set-scroll-ref
-              :on-select                 on-select
-              :on-viewable-items-changed on-viewable-items-changed
-              :active-category           active-category
-              :scroll-ref                scroll-ref)])))
+      (let [{:keys [on-select]} (quo.context/use-screen-params)]
+        [sheet-view
+         (assoc sheet-opts
+                :search-active?            (pos? (count @search-text))
+                :on-change-text            on-change-text
+                :clear-states              clear-states
+                :filtered-data             @filtered-data
+                :set-scroll-ref            set-scroll-ref
+                :on-select                 on-select
+                :on-viewable-items-changed on-viewable-items-changed
+                :active-category           active-category
+                :scroll-ref                scroll-ref)]))))

src/status_im/common/lightbox/view.cljs

@@ -138,17 +138,11 @@
          :transparent?          transparent?
          :bottom-text-component bottom-text-component}])]))
 
-(defn- f-lightbox
-  []
-  (let [{:keys [images index bottom-text-component on-options-press]}
-        (quo.context/use-screen-params)
-        props
-        (utils/init-props)
-        state
-        (utils/init-state images index)
-        handle-items-changed
-        (fn [e]
-          (on-viewable-items-changed e props state))]
+(defn- lightbox-internal
+  [{:keys [images index bottom-text-component on-options-press]}]
+  (let [props                (utils/init-props)
+        state                (utils/init-state images index)
+        handle-items-changed (fn [e] (on-viewable-items-changed e props state))]
     (fn []
       (let [animations (utils/init-animations (count images) index)
             derived    (utils/init-derived-animations animations)]
@@ -170,4 +164,5 @@
 
 (defn lightbox
   []
-  [:f> f-lightbox])
+  (let [screen-params (quo.context/use-screen-params)]
+    [lightbox-internal screen-params]))

src/status_im/contexts/profile/edit/modal/view.cljs

@@ -187,10 +187,9 @@
         (and new-picture? acceptable-name?)
         (and new-name? valid-name?))))
 
-(defn view
-  []
-  (let [{:keys [pending-event]}        (quo.context/use-screen-params)
-        {initial-display-name :display-name
+(defn view-internal
+  [{:keys [pending-event]}]
+  (let [{initial-display-name :display-name
          initial-color        :customization-color
          [initial-image]      :images} (rf/sub [:profile/profile])
         top                            (safe-area/get-top)
@@ -265,3 +264,8 @@
             :scroll-y     @scroll-y
             :on-submit    update-profile
             :disabled?    disabled?}]]]))))
+
+(defn view
+  []
+  (let [screen-params (quo.context/use-screen-params)]
+    [view-internal screen-params]))

src/status_im/contexts/wallet/add_account/add_address_to_watch/confirm_address/view.cljs

@@ -16,15 +16,15 @@
 
 (defn view
   []
-  (let [{:keys [address]} (quo.context/use-screen-params)
-        placeholder       (i18n/label :t/default-watched-address-placeholder)
+  (let [placeholder       (i18n/label :t/default-watched-address-placeholder)
         account-name      (reagent/atom "")
         account-color     (reagent/atom (rand-nth colors/account-colors))
         account-emoji     (reagent/atom (emoji-picker.utils/random-emoji))
         name-error        (reagent/atom nil)
         emoji-color-error (reagent/atom nil)]
     (fn []
-      (let [accounts-names             (rf/sub [:wallet/accounts-names])
+      (let [{:keys [address]}          (quo.context/use-screen-params)
+            accounts-names             (rf/sub [:wallet/accounts-names])
             accounts-emojis-and-colors (rf/sub [:wallet/accounts-emojis-and-colors])
             on-change-name             (fn [new-name]
                                          (reset! account-name new-name)

src/status_im/contexts/wallet/add_account/create_account/new_keypair/confirm_backup/view.cljs

@@ -116,25 +116,20 @@
                                         (on-try-again)))}
        :blur?            shell?}]]))
 
-(defn view
-  []
-  (let [random-indices         (random-selection)
-        quiz-index             (reagent/atom 0)
-        incorrect-count        (reagent/atom 0)
-        show-error?            (reagent/atom false)
-        {:keys [on-success
-                on-try-again
-                masked-seed-phrase
-                back-button?
-                theme shell?]} (quo.context/use-screen-params)
-        unmasked-seed-phrase   (security/safe-unmask-data masked-seed-phrase)
-        random-phrase          (reagent/atom [])]
+(defn- view-internal
+  [{:keys [on-success on-try-again masked-seed-phrase back-button? theme shell?]}]
+  (let [random-indices  (random-selection)
+        quiz-index      (reagent/atom 0)
+        incorrect-count (reagent/atom 0)
+        show-error?     (reagent/atom false)
+        random-phrase   (reagent/atom [])]
     (fn []
       (rn/use-mount
        (fn []
          (native-module/get-random-mnemonic #(reset! random-phrase (string/split % #"\s")))))
       (when-not (empty? @random-phrase)
-        (let [current-word-index            (get random-indices
+        (let [unmasked-seed-phrase          (security/safe-unmask-data masked-seed-phrase)
+              current-word-index            (get random-indices
                                                  (min @quiz-index (dec questions-count)))
               current-word                  (get unmasked-seed-phrase current-word-index)
               [options-row-0 options-row-1] (random-words-with-string @random-phrase current-word)
@@ -217,3 +212,8 @@
              {:on-press on-button-press
               :options  options-row-1
               :shell?   shell?}]]])))))
+
+(defn view
+  []
+  (let [screen-params (quo.context/use-screen-params)]
+    [view-internal screen-params]))