Refactor BulkInsertObjectStore::hasRaisedTimeout to avoid that some to avoid a huge delay (around 30 seconds) from reading objects from the queue and writing objects into the database

Author: nook24

bin/StatusengineWorker.php

@@ -52,14 +52,7 @@
 
 if ($Config->isRedisEnabled() || $Config->storeLiveDateInArchive()) {
     for ($i = 0; $i < $Config->getNumberOfServicestatusWorkers(); $i++) {
-        $Syslog->info('Fork new service status worker');
-        $ServicestatusChild = new Statusengine\ServicestatusChild(
-            $Config,
-            $ParentPid,
-            $Syslog
-        );
-        $servicestatusChildPid = $ServicestatusChild->fork();
-        $pids[] = $servicestatusChildPid;
+        $pids[] = $ChildFactory->forkServicestatusChild();
     }
 }
 

src/Backends/MySQL/MySQL.php

@@ -230,6 +230,17 @@ public function deleteNodeByName($nodeName) {
     }
 
     public function dispatch() {
+            /*$bt = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
+
+            if($bt[3]['function'] === 'forkServicestatusChild'){
+              // echo "============ START ========== \n";
+              // foreach($bt as $line){
+              //     printf("File: %s Line: %s function: %s\n", $line['file'], $line['line'], $line['function']);
+              // }
+              // echo "============ END ========== \n\n";
+            }*/
+
+
         if ($this->BulkInsertObjectStore->hasRaisedTimeout()) {
             try {
                 $type = $this->BulkInsertObjectStore->getStoredType();

src/BulkInsertObjectStore.php

@@ -38,7 +38,7 @@ class BulkInsertObjectStore {
     /**
      * @var int
      */
-    private $lastAction;
+    private $lastFlush;
 
     /**
      * @var int
@@ -66,13 +66,12 @@ public function __construct($maxDelay, $maxObjects) {
 
         $this->maxObjects = $maxObjects;
         $this->maxDelay = $maxDelay;
-        $this->lastAction = 0;
+        $this->lastFlush = 0;
     }
 
     public function addObject($object) {
         $this->objects[] = $object;
         $this->objectCount++;
-        $this->lastAction = time();
     }
 
     /**
@@ -89,7 +88,7 @@ public function getObjects() {
     public function reset() {
         $this->objects = [];
         $this->objectCount = 0;
-        $this->lastAction = time();
+        $this->lastFlush = time();
     }
 
     /**
@@ -107,11 +106,12 @@ public function getStoredType(){
      * @return bool
      */
     public function hasRaisedTimeout() {
-        if ($this->objectCount >= $this->maxObjects || time() - $this->lastAction > $this->maxDelay) {
-            if ($this->objectCount > 0) {
+        if ($this->objectCount > 0) {
+            if ($this->objectCount >= $this->maxObjects || (time() - $this->lastFlush) > $this->maxDelay) {
                 return true;
             }
         }
+
         return false;
     }