chore(lint): add report-unused-disable-directives

Author: staylor

__tests__/api/htmlAttributes.test.js

@@ -3,7 +3,7 @@ import { Helmet } from '../../src';
 import { HELMET_ATTRIBUTE } from '../../src/constants';
 import { render } from './utils';
 
-/* eslint-disable max-nested-callbacks, jsx-a11y/html-has-lang */
+/* eslint-disable jsx-a11y/html-has-lang */
 
 Helmet.defaultProps.defer = false;
 

package.json

@@ -60,7 +60,7 @@
   },
   "scripts": {
     "clean": "rimraf lib",
-    "lint": "eslint .",
+    "lint": "eslint . --report-unused-disable-directives",
     "lint-fix": "eslint . --fix",
     "test": "NODE_ENV=test BABEL_ENV=test jest",
     "test-watch": "yarn test --watch",

src/Provider.js

@@ -37,7 +37,6 @@ export default class Provider extends Component {
 
   value = {
     setHelmet: serverState => {
-      // eslint-disable-next-line react/prop-types
       this.props.context.helmet = serverState;
     },
     helmetInstances: {
@@ -56,7 +55,6 @@ export default class Provider extends Component {
     super(props);
 
     if (!Provider.canUseDOM) {
-      // eslint-disable-next-line no-param-reassign
       props.context.helmet = mapStateOnServer({
         baseTag: [],
         bodyAttributes: {},

src/constants.js

@@ -45,7 +45,6 @@ export const REACT_TAG_MAP = {
 };
 
 export const HTML_TAG_MAP = Object.keys(REACT_TAG_MAP).reduce((obj, key) => {
-  // eslint-disable-next-line no-param-reassign
   obj[REACT_TAG_MAP[key]] = key;
   return obj;
 }, {});

src/index.js

@@ -28,7 +28,7 @@ export class Helmet extends Component {
    * @param {Object} titleAttributes: {"itemprop": "name"}
    * @param {String} titleTemplate: "MySite.com - %s"
    */
-  /* eslint-disable react/prop-types, react/forbid-prop-types, react/require-default-props */
+  /* eslint-disable react/forbid-prop-types, react/require-default-props */
   static propTypes = {
     base: PropTypes.object,
     bodyAttributes: PropTypes.object,
@@ -171,7 +171,6 @@ export class Helmet extends Component {
       const { children: nestedChildren, ...childProps } = child.props;
       // convert React props to HTML attributes
       const newChildProps = Object.keys(childProps).reduce((obj, key) => {
-        // eslint-disable-next-line no-param-reassign
         obj[HTML_TAG_MAP[key] || key] = childProps[key];
         return obj;
       }, {});
@@ -185,7 +184,6 @@ export class Helmet extends Component {
 
       switch (type) {
         case TAG_NAMES.FRAGMENT:
-          // eslint-disable-next-line no-param-reassign
           newProps = this.mapChildrenToProps(nestedChildren, newProps);
           break;
 
@@ -203,7 +201,6 @@ export class Helmet extends Component {
           break;
 
         default:
-          // eslint-disable-next-line no-param-reassign
           newProps = this.mapObjectTypeChildren({
             child,
             newProps,

src/server.js

@@ -69,7 +69,6 @@ const generateTagsAsString = (type, tags, encode) =>
 
 const convertElementAttributesToReactProps = (attributes, initProps = {}) =>
   Object.keys(attributes).reduce((obj, key) => {
-    // eslint-disable-next-line no-param-reassign
     obj[REACT_TAG_MAP[key] || key] = attributes[key];
     return obj;
   }, initProps);