fix: fix methods, add tests

Author: justinph

__tests__/server/server.test.js

@@ -100,6 +100,11 @@ describe('server', () => {
 
       expect(styleComponent).toEqual(isArray);
       expect(styleComponent).toHaveLength(0);
+
+      expect(head.priority).toBeDefined();
+      expect(head.priority.toString).toBeDefined();
+      expect(head.priority.toString()).toEqual('');
+      expect(head.priority.toComponent).toBeDefined();
     });
 
     it('does not render undefined attribute values', () => {
@@ -214,6 +219,11 @@ describe('server', () => {
 
       expect(styleComponent).toEqual(isArray);
       expect(styleComponent).toHaveLength(0);
+
+      expect(head.priority).toBeDefined();
+      expect(head.priority.toString).toBeDefined();
+      expect(head.priority.toString()).toEqual('');
+      expect(head.priority.toComponent).toBeDefined();
     });
 
     it('does not render undefined attribute values', () => {
@@ -229,5 +239,57 @@ describe('server', () => {
 
       expect(script.toString()).toMatchSnapshot();
     });
+
+    it('prioritizes SEO tags when asked to', () => {
+      const context = {};
+      render(
+        <Helmet prioritizeSeoTags>
+          <link rel="notImportant" href="https://www.chipotle.com" />
+          <link rel="canonical" href="https://www.tacobell.com" />
+          <meta property="og:title" content="A very important title" />
+        </Helmet>,
+        context
+      );
+
+      expect(context.helmet.priority.toString()).toContain(
+        'rel="canonical" href="https://www.tacobell.com"'
+      );
+      expect(context.helmet.link.toString()).not.toContain(
+        'rel="canonical" href="https://www.tacobell.com"'
+      );
+
+      expect(context.helmet.priority.toString()).toContain(
+        'property="og:title" content="A very important title"'
+      );
+      expect(context.helmet.meta.toString()).not.toContain(
+        'property="og:title" content="A very important title"'
+      );
+    });
+
+    it('does not prioritize SEO unless asked to', () => {
+      const context = {};
+      render(
+        <Helmet>
+          <link rel="notImportant" href="https://www.chipotle.com" />
+          <link rel="canonical" href="https://www.tacobell.com" />
+          <meta property="og:title" content="A very important title" />
+        </Helmet>,
+        context
+      );
+
+      expect(context.helmet.priority.toString()).not.toContain(
+        'rel="canonical" href="https://www.tacobell.com"'
+      );
+      expect(context.helmet.link.toString()).toContain(
+        'rel="canonical" href="https://www.tacobell.com"'
+      );
+
+      expect(context.helmet.priority.toString()).not.toContain(
+        'property="og:title" content="A very important title"'
+      );
+      expect(context.helmet.meta.toString()).toContain(
+        'property="og:title" content="A very important title"'
+      );
+    });
   });
 });

src/server.js

@@ -175,8 +175,9 @@ const mapStateOnServer = props => {
   let { linkTags, metaTags, scriptTags } = props;
   let priorityMethods = {
     toComponent: () => {},
-    toString: () => {},
+    toString: () => '',
   };
+  console.log('prioritizeSeoTags', prioritizeSeoTags);
   if (prioritizeSeoTags) {
     ({ priorityMethods, linkTags, metaTags, scriptTags } = getPriorityMethods(props));
   }

src/utils.js

@@ -171,10 +171,17 @@ const getTagsFromPropsList = (tagName, primaryAttributes, propsList) => {
     .reverse();
 };
 
-const getAnyTrueFromPropsList = (propsList, checkedTag) =>
-  propsList.reduce((accumulator, currentPropList) =>
-    currentPropList[checkedTag] ? true : accumulator
-  );
+const getAnyTrueFromPropsList = (propsList, checkedTag) => {
+  if (Array.isArray(propsList) && propsList.length) {
+    for (let index = 0; index < propsList.length; index += 1) {
+      const prop = propsList[index];
+      if (prop[checkedTag]) {
+        return true;
+      }
+    }
+  }
+  return false;
+};
 
 const reducePropsToState = propsList => ({
   baseTag: getBaseTagFromPropsList([TAG_PROPERTIES.HREF], propsList),
@@ -208,9 +215,7 @@ const reducePropsToState = propsList => ({
   styleTags: getTagsFromPropsList(TAG_NAMES.STYLE, [TAG_PROPERTIES.CSS_TEXT], propsList),
   title: getTitleFromPropsList(propsList),
   titleAttributes: getAttributesFromPropsList(ATTRIBUTE_NAMES.TITLE, propsList),
-  prioritizeSeoTags:
-    propsList.prioritizeSeoTags &&
-    getAnyTrueFromPropsList(propsList, HELMET_PROPS.PRIORITIZE_SEO_TAGS),
+  prioritizeSeoTags: getAnyTrueFromPropsList(propsList, HELMET_PROPS.PRIORITIZE_SEO_TAGS),
 });
 
 export const flattenArray = possibleArray =>