fix(shell): prevent activating the window

Author: std-microblock

src/shell/contextmenu/hooks.cc

@@ -56,8 +56,6 @@ void mb_shell::context_menu_hooks::install_common_hook() {
       auto hook = SetWindowsHookExW(
           WH_KEYBOARD,
           [](int nCode, WPARAM wParam, LPARAM lParam) -> LRESULT {
-            std::println("Keyboard hook called: nCode={}, wParam={}", nCode,
-                         wParam);
             if (nCode == HC_ACTION) {
               PostMessageW(window, lParam == WM_KEYDOWN ? WM_KEYDOWN : WM_KEYUP,
                            wParam, lParam);
@@ -66,6 +64,10 @@ void mb_shell::context_menu_hooks::install_common_hook() {
             return CallNextHookEx(NULL, nCode, wParam, lParam);
           },
           NULL, thread_id_orig);
+        
+      SetWindowLongPtrW(window, GWL_EXSTYLE,
+                        GetWindowLongPtrW(window, GWL_EXSTYLE) |
+                            WS_EX_NOACTIVATE | WS_EX_TOOLWINDOW);
 
       menu_render.rt->start_loop();
       UnhookWindowsHookEx(hook);

src/shell/contextmenu/menu_render.cc

@@ -21,12 +21,13 @@ menu_render menu_render::create(int x, int y, menu menu) {
   }
 
   static auto rt = []() {
+    static window_proc_hook glfw_proc_hook;
     auto rt = std::make_shared<ui::render_target>();
     rt->transparent = true;
     rt->no_activate = true;
     rt->capture_all_input = true;
     rt->decorated = false;
-    rt->topmost = false;
+    rt->topmost = true;
     rt->vsync = config::current->context_menu.vsync;
 
     if (config::current->avoid_resize_ui) {
@@ -39,6 +40,18 @@ menu_render menu_render::create(int x, int y, menu menu) {
                   MB_ICONERROR);
     }
 
+    glfw_proc_hook.install(rt->hwnd());
+    SetCapture((HWND)rt->hwnd());
+    glfw_proc_hook.hooks.push_back([](void *hwnd, void *original_proc,
+                                      size_t msg, size_t wparam,
+                                      size_t lparam) -> std::optional<int> {
+      if (msg == WM_MOUSEACTIVATE) {
+        return MA_NOACTIVATE;
+      }
+
+      return std::nullopt;
+    });
+
     nvgCreateFont(rt->nvg, "main",
                   config::current->font_path_main.string().c_str());
     nvgCreateFont(rt->nvg, "fallback",
@@ -65,17 +78,15 @@ menu_render menu_render::create(int x, int y, menu menu) {
          monitor_info.rcMonitor.top, monitor_info.rcMonitor.right,
          monitor_info.rcMonitor.bottom);
 
-  rt->set_position(monitor_info.rcMonitor.left + 1, monitor_info.rcMonitor.top + 1);
+  rt->set_position(monitor_info.rcMonitor.left + 1,
+                   monitor_info.rcMonitor.top + 1);
   if (!config::current->avoid_resize_ui)
-    rt->resize(
-        monitor_info.rcMonitor.right - monitor_info.rcMonitor.left - 2,
-        monitor_info.rcMonitor.bottom - monitor_info.rcMonitor.top - 2);
+    rt->resize(monitor_info.rcMonitor.right - monitor_info.rcMonitor.left - 2,
+               monitor_info.rcMonitor.bottom - monitor_info.rcMonitor.top - 2);
 
   glfwMakeContextCurrent(rt->window);
   glfwSwapInterval(config::current->context_menu.vsync ? 1 : 0);
 
-  
-
   rt->show();
   auto menu_wid = std::make_shared<mouse_menu_widget_main>(
       menu,
@@ -89,7 +100,7 @@ menu_render menu_render::create(int x, int y, menu menu) {
                 js::js_menu_context::$from_window(menu.parent_window));
           })
           .get();
-          
+
   js::menu_info_basic_js menu_info{
       .menu = std::make_shared<js::menu_controller>(menu_wid->menu_wid),
       .context = current_js_context};

src/shell/window_proc_hook.cc

@@ -18,10 +18,10 @@ void window_proc_hook::install(void *hwnd) {
         SetWindowLongPtrW((HWND)hwnd, GWLP_WNDPROC,
                           (LONG_PTR)this->original_proc);
 
-        bool callOriginal = true;
+        std::optional<int> callOriginal = std::nullopt;
         for (auto &f : this->hooks) {
-          callOriginal =
-              callOriginal && f(hwnd, this->original_proc, msg, wp, lp);
+          if (!callOriginal)
+            callOriginal = f(hwnd, this->original_proc, msg, wp, lp);
         }
 
         while (!this->tasks.empty()) {
@@ -32,8 +32,9 @@ void window_proc_hook::install(void *hwnd) {
         SetWindowLongPtrW((HWND)hwnd, GWLP_WNDPROC,
                           (LONG_PTR)this->hooked_proc);
 
-        return callOriginal &&
-               CallWindowProcW((WNDPROC)this->original_proc, hwnd, msg, wp, lp);
+        return callOriginal ? *callOriginal
+                            : CallWindowProcW((WNDPROC)this->original_proc,
+                                              hwnd, msg, wp, lp);
       });
 
   SetWindowLongPtrW((HWND)hwnd, GWLP_WNDPROC, (LONG_PTR)this->hooked_proc);

src/shell/window_proc_hook.h

@@ -12,7 +12,7 @@ namespace mb_shell {
         void* hooked_proc = nullptr;
         bool installed = false;
 
-        std::vector<std::function<bool(void*, void*, size_t, size_t, size_t)>> hooks;
+        std::vector<std::function<std::optional<int>(void*, void*, size_t, size_t, size_t)>> hooks;
         std::queue<std::function<void()>> tasks;
 
         void send_null();

src/ui/ui.cc

@@ -131,7 +131,6 @@ std::expected<bool, std::string> render_target::init() {
   if (capture_all_input) {
     // retrieve all mouse messages
     SetCapture(h);
-    SetFocus(h);
   }
 
   if (topmost) {