fix(shell): leak fs.watch as a temporary solution of crash

Author: std-microblock

scripts/bindgen/quickjs-types.txt

@@ -17,7 +17,7 @@ declare module "mshell" {
 // helper to access field based on dot path
 type FieldPath<T, K extends string> = K extends keyof T ? T[K] : K extends `${infer K1}.${infer K2}` ? K1 extends keyof T ? FieldPath<T[K1], K2> : never : never;
 
-declare function plugin<T = object>(import_meta: { name: string; url: string }, default_config?: T): {
+declare function plugin<T = object>(import_meta: { url: string }, default_config?: T): {
     i18n: {
         define(lang: string, data: { [key: string]: string }): void;
         t(key: string): string;
@@ -34,4 +34,6 @@ declare function plugin<T = object>(import_meta: { name: string; url: string },
         all(): T;
     };
     log(...args: any[]): void;
-};
+};
+
+declare type ShellPluginHelper = ReturnType<typeof plugin>;

src/shell/script/binding_types.cc

@@ -1054,10 +1054,6 @@ fs::watch(std::string path, std::function<void(std::string, int)> callback) {
     } catch (std::exception &e) {
       std::cerr << "Error in file watch callback: " << e.what() << std::endl;
     }
-
-    if (*dispose) {
-      delete fw;
-    }
   });
 
   return [dispose] { *dispose = true; };