fix: remove hacky reset_fons_cache (桌面上 Shift + 鼠标右键 崩溃

Fixes #289)

Author: std-microblock

src/shell/contextmenu/hooks.cc

@@ -33,12 +33,6 @@ mb_shell::track_popup_menu(mb_shell::menu menu, int x, int y,
             menu_render.rt->last_time = menu_render.rt->clock.now();
             perf.end("menu_render::create");
 
-            // If holds Shift key when opening the menu, refresh the font cache
-            if (GetKeyState(VK_SHIFT) & 0x8000) {
-                std::println("Refreshing font cache...");
-                menu_render.reset_fons_cache();
-            }
-
             static HWND window = nullptr;
             window = (HWND)menu_render.rt->hwnd();
             // set keyboard hook to handle keyboard input

src/shell/contextmenu/menu_render.cc

@@ -99,7 +99,8 @@ menu_render menu_render::create(int x, int y, menu menu, bool run_js) {
     js::menu_info_basic_js menu_info{
         .menu = std::make_shared<js::menu_controller>(menu_wid->menu_wid),
         .context = current_js_context,
-        .screenside_button = std::make_shared<js::screenside_button_controller>(menu_wid),
+        .screenside_button =
+            std::make_shared<js::screenside_button_controller>(menu_wid),
     };
 
     if (run_js) {
@@ -142,48 +143,4 @@ menu_render &menu_render::operator=(menu_render &&t) {
     selected_menu = std::move(t.selected_menu);
     return *this;
 }
-// struct NVGcontext {
-// 	NVGparams params;
-// 	float* commands;
-// 	int ccommands;
-// 	int ncommands;
-// 	float commandx, commandy;
-// 	NVGstate states[NVG_MAX_STATES];
-// 	int nstates;
-// 	NVGpathCache* cache;
-// 	float tessTol;
-// 	float distTol;
-// 	float fringeWidth;
-// 	float devicePxRatio;
-// 	struct FONScontext* fs;
-// 	int fontImages[NVG_MAX_FONTIMAGES];
-// 	int fontImageIdx;
-// 	int drawCallCount;
-// 	int fillTriCount;
-// 	int strokeTriCount;
-// 	int textTriCount;
-// };
-// HACK: By finding the third readable pointer from NVGcontext, we can get the FONScontext
-struct FONScontext;
-extern "C" int fonsResetAtlas(FONScontext* stash, int width, int height);
-void menu_render::reset_fons_cache() {
-    if (!rt)
-        return;
-    auto nvg = rt->nvg;
-    char* ptr = reinterpret_cast<char *>(nvg);
-    size_t offset = sizeof(NVGparams) + sizeof(float *);
-    int ptr_count = 0;
-    for (size_t i = 0; i < 1024; i += 4) {
-        void **p = reinterpret_cast<void **>(ptr + offset + i);
-        if (is_memory_readable(*p)) {
-            ptr_count++;
-            if (ptr_count == 2) {
-                auto fons = reinterpret_cast<struct FONScontext *>(*p);
-                fonsResetAtlas(fons, 512, 512);
-                return;
-            }
-        }
-    }
-
-}
 }; // namespace mb_shell

src/shell/contextmenu/menu_render.h

@@ -20,7 +20,6 @@ struct menu_render {
     const menu_render &operator=(const menu_render &) = delete;
     menu_render(menu_render &&t);
     menu_render &operator=(menu_render &&t);
-    void reset_fons_cache();
     static menu_render create(int x, int y, menu menu, bool run_js = true);
 };
 } // namespace mb_shell