Core/Database: Add Empty and CancelAll functions to AsyncCallbackProcessor and enable callback concept check

(cherry picked from commit b4f7948)

Author: Shauren

src/common/Utilities/AsyncCallbackProcessor.h

@@ -15,17 +15,13 @@
  * with this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-#ifndef AsyncCallbackProcessor_h__
-#define AsyncCallbackProcessor_h__
+#ifndef TRINITYCORE_ASYNC_CALLBACK_PROCESSOR_H
+#define TRINITYCORE_ASYNC_CALLBACK_PROCESSOR_H
 
-#include "Define.h"
-#include <algorithm>
+#include "AsyncCallbackProcessorFwd.h"
 #include <vector>
 
-//template <class T>
-//concept AsyncCallback = requires(T t) { { t.InvokeIfReady() } -> std::convertible_to<bool> };
-
-template<typename T> // requires AsyncCallback<T>
+template<AsyncCallback T>
 class AsyncCallbackProcessor
 {
 public:
@@ -34,8 +30,7 @@ class AsyncCallbackProcessor
 
     T& AddCallback(T&& query)
     {
-        _callbacks.emplace_back(std::move(query));
-        return _callbacks.back();
+        return _callbacks.emplace_back(std::move(query));
     }
 
     void ProcessReadyCallbacks()
@@ -45,19 +40,29 @@ class AsyncCallbackProcessor
 
         std::vector<T> updateCallbacks{ std::move(_callbacks) };
 
-        updateCallbacks.erase(std::remove_if(updateCallbacks.begin(), updateCallbacks.end(), [](T& callback)
+        std::erase_if(updateCallbacks, [](T& callback)
         {
-            return callback.InvokeIfReady();
-        }), updateCallbacks.end());
+            return InvokeAsyncCallbackIfReady(callback);
+        });
 
         _callbacks.insert(_callbacks.end(), std::make_move_iterator(updateCallbacks.begin()), std::make_move_iterator(updateCallbacks.end()));
     }
 
+    bool Empty() const
+    {
+        return _callbacks.empty();
+    }
+
+    void CancelAll()
+    {
+        _callbacks.clear();
+    }
+
 private:
     AsyncCallbackProcessor(AsyncCallbackProcessor const&) = delete;
     AsyncCallbackProcessor& operator=(AsyncCallbackProcessor const&) = delete;
 
     std::vector<T> _callbacks;
 };
 
-#endif // AsyncCallbackProcessor_h__
+#endif // TRINITYCORE_ASYNC_CALLBACK_PROCESSOR_H

src/common/Utilities/AsyncCallbackProcessorFwd.h

@@ -0,0 +1,29 @@
+/*
+ * This file is part of the TrinityCore Project. See AUTHORS file for Copyright information
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+ * more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef TRINITYCORE_ASYNC_CALLBACK_PROCESSOR_FWD_H
+#define TRINITYCORE_ASYNC_CALLBACK_PROCESSOR_FWD_H
+
+#include <concepts>
+
+template <typename T>
+concept AsyncCallback = requires(T& t) { { InvokeAsyncCallbackIfReady(t) } -> std::convertible_to<bool>; };
+
+template<AsyncCallback T>
+class AsyncCallbackProcessor;
+
+#endif // TRINITYCORE_ASYNC_CALLBACK_PROCESSOR_FWD_H

src/server/database/Database/DatabaseEnvFwd.h

@@ -18,6 +18,7 @@
 #ifndef DatabaseEnvFwd_h__
 #define DatabaseEnvFwd_h__
 
+#include "AsyncCallbackProcessorFwd.h"
 #include <future>
 #include <memory>
 
@@ -48,9 +49,7 @@ using PreparedQueryResultFuture = std::future<PreparedQueryResult>;
 using PreparedQueryResultPromise = std::promise<PreparedQueryResult>;
 
 class QueryCallback;
-
-template<typename T>
-class AsyncCallbackProcessor;
+bool InvokeAsyncCallbackIfReady(QueryCallback& callback);
 
 using QueryCallbackProcessor = AsyncCallbackProcessor<QueryCallback>;
 
@@ -63,6 +62,7 @@ template<typename T>
 class Transaction;
 
 class TransactionCallback;
+bool InvokeAsyncCallbackIfReady(TransactionCallback& callback);
 
 template<typename T>
 using SQLTransaction = std::shared_ptr<Transaction<T>>;
@@ -83,6 +83,7 @@ using LoginDatabaseQueryHolder = SQLQueryHolder<LoginDatabaseConnection>;
 using WorldDatabaseQueryHolder = SQLQueryHolder<WorldDatabaseConnection>;
 
 class SQLQueryHolderCallback;
+bool InvokeAsyncCallbackIfReady(SQLQueryHolderCallback& callback);
 
 // mysql
 struct MySQLHandle;

src/server/database/Database/QueryCallback.h

@@ -66,4 +66,6 @@ class TC_DATABASE_API QueryCallback
     std::queue<QueryCallbackData, std::list<QueryCallbackData>> _callbacks;
 };
 
+inline bool InvokeAsyncCallbackIfReady(QueryCallback& callback) { return callback.InvokeIfReady(); }
+
 #endif // _QUERY_CALLBACK_H

src/server/database/Database/QueryHolder.h

@@ -85,4 +85,6 @@ class TC_DATABASE_API SQLQueryHolderCallback
     std::function<void(SQLQueryHolderBase const&)> m_callback;
 };
 
+inline bool InvokeAsyncCallbackIfReady(SQLQueryHolderCallback& callback) { return callback.InvokeIfReady(); }
+
 #endif

src/server/database/Database/Transaction.h

@@ -120,4 +120,6 @@ class TC_DATABASE_API TransactionCallback
     std::function<void(bool)> m_callback;
 };
 
+inline bool InvokeAsyncCallbackIfReady(TransactionCallback& callback) { return callback.InvokeIfReady(); }
+
 #endif