Skip to content

Commit 0258691

Browse files
chore: address commit comments for betaprime/mode
PR-URL: #5080 Closes: #5071 Reviewed-by: Philipp Burckhardt <[email protected]>
1 parent f9789d4 commit 0258691

File tree

6 files changed

+8
-14
lines changed

6 files changed

+8
-14
lines changed

lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ Returns the mode of a beta prime distribution with first shape parameter `alpha`
176176

177177
```c
178178
double y = stdlib_base_dists_betaprime_mode( 1.0, 2.0 );
179-
//returns ~0.0
179+
//returns 0.0
180180
```
181181

182182
The function accepts the following arguments:
@@ -228,7 +228,7 @@ int main( void ) {
228228
alpha = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
229229
beta = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
230230
y = stdlib_base_dists_betaprime_mode( alpha, beta );
231-
printf( "α: %1f, β: %1f, Mode(X;α,β): %lf\n", alpha, beta, y );
231+
printf( "α: %lf, β: %lf, Mode(X;α,β): %lf\n", alpha, beta, y );
232232
}
233233
}
234234
```

lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/benchmark/benchmark.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,9 @@ bench( pkg, function benchmark( b ) {
4040

4141
len = 100;
4242
alpha = new Float64Array( len );
43-
for ( i = 0; i < len; i++ ) {
44-
alpha[ i ] = uniform( EPS, 10.0 );
45-
}
4643
beta = new Float64Array( len );
4744
for ( i = 0; i < len; i++ ) {
45+
alpha[ i ] = uniform( EPS, 10.0 );
4846
beta[ i ] = uniform( EPS, 10.0 );
4947
}
5048

lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/benchmark/benchmark.native.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4949

5050
len = 100;
5151
alpha = new Float64Array( len );
52-
for ( i = 0; i < len; i++ ) {
53-
alpha[ i ] = uniform( EPS, 10.0 );
54-
}
5552
beta = new Float64Array( len );
5653
for ( i = 0; i < len; i++ ) {
54+
alpha[ i ] = uniform( EPS, 10.0 );
5755
beta[ i ] = uniform( EPS, 10.0 );
5856
}
5957

lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/benchmark/c/benchmark.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ static double benchmark( void ) {
102102

103103
for ( i = 0; i < 100; i++ ) {
104104
alpha[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
105-
}
106-
for ( i = 0; i < 100; i++ ) {
107105
beta[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
108106
}
109107

lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/examples/c/example.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ int main( void ) {
3636
alpha = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
3737
beta = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
3838
y = stdlib_base_dists_betaprime_mode( alpha, beta );
39-
printf( "α: %1f, β: %1f, Mode(X;α,β): %lf\n", alpha, beta, y );
39+
printf( "α: %lf, β: %lf, Mode(X;α,β): %lf\n", alpha, beta, y );
4040
}
4141
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/src/main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@
2424
* @param x input value
2525
* @param alpha first shape parameter
2626
* @param beta second shape parameter
27-
* @returns mode
27+
* @return mode
2828
*
2929
* @example
3030
* double y = stdlib_base_dists_betaprime_mode( 1.0, 2.0 );
31-
* // returns ~0.0
31+
* // returns 0.0
3232
*/
33-
double stdlib_base_dists_betaprime_mode( double alpha, const double beta ) {
33+
double stdlib_base_dists_betaprime_mode( const double alpha, const double beta ) {
3434
if ( alpha <= 0.0 || beta <= 0.0 ) {
3535
return 0.0 / 0.0;
3636
}

0 commit comments

Comments
 (0)