Skip to content

Commit 094e87a

Browse files
committed
chore: stuff from code review
1 parent de7abd0 commit 094e87a

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/src/main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,14 @@
2626
#include "stdlib/math/base/special/lnf.h"
2727
#include <stdint.h>
2828

29-
#define SQRT5 2.23606797749979
30-
#define LN_PHI 0.48121182506
29+
const float SQRT5 = 2.23606797749979;
30+
const float LN_PHI = 0.48121182506;
3131

3232
/**
3333
* Computes the nth non-Fibonacci number in single-precision floating-point format.
3434
*
3535
* @param x input value
36-
* @return output value
36+
* @return output value
3737
*
3838
* @example
3939
* float y = stdlib_base_nonfibonaccif( 2 );

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/test/test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,32 +42,32 @@ tape( 'main export is a function', function test( t ) {
4242

4343
tape( 'if provided `NaN`, the function returns `NaN`', function test( t ) {
4444
var n = nonfibonaccif( NaN );
45-
t.strictEqual( isnanf( n ), true, 'returns NaN when provided a NaN' );
45+
t.strictEqual( isnanf( n ), true, 'returns expected value when provided a NaN' );
4646
t.end();
4747
});
4848

4949
tape( 'if provided `+infinity`, the function returns `NaN`', function test( t ) {
5050
var n = nonfibonaccif( PINF );
51-
t.strictEqual( isnanf( n ), true, 'returns NaN' );
51+
t.strictEqual( isnanf( n ), true, 'returns expected value' );
5252
t.end();
5353
});
5454

5555
tape( 'if provided a number less than 1, the function returns `NaN`', function test( t ) {
5656
var n;
5757
var i;
5858

59-
t.strictEqual( isnanf( nonfibonaccif( -3.14 ) ), true, 'returns NaN' );
59+
t.strictEqual( isnanf( nonfibonaccif( -3.14 ) ), true, 'returns expected value' );
6060

6161
for ( i = 0; i > -100; i-- ) {
6262
n = nonfibonaccif( i );
63-
t.strictEqual( isnanf( n ), true, 'returns NaN when provided ' + i );
63+
t.strictEqual( isnanf( n ), true, 'returns expected value when provided ' + i );
6464
}
6565
t.end();
6666
});
6767

6868
tape( 'if provided a non-integer, the function returns `NaN`', function test( t ) {
6969
var n = nonfibonaccif( 3.14 );
70-
t.strictEqual( isnanf( n ), true, 'returns NaN' );
70+
t.strictEqual( isnanf( n ), true, 'returns expected value' );
7171
t.end();
7272
});
7373

lib/node_modules/@stdlib/math/base/special/nonfibonaccif/test/test.native.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,33 +51,33 @@ tape( 'main export is a function', opts, function test( t ) {
5151

5252
tape( 'if provided `NaN`, the function returns `NaN`', opts, function test( t ) {
5353
var n = nonfibonacci( NaN );
54-
t.strictEqual( isnan( n ), true, 'returns NaN when provided a NaN' );
54+
t.strictEqual( isnan( n ), true, 'returns expected value when provided a NaN' );
5555
t.end();
5656
});
5757

5858
tape( 'if provided `+infinity`, the function returns `NaN`', opts, function test( t ) {
5959
var n = nonfibonacci( PINF );
60-
t.strictEqual( isnan( n ), true, 'returns NaN' );
60+
t.strictEqual( isnan( n ), true, 'returns expected value' );
6161
t.end();
6262
});
6363

6464
tape( 'if provided a number less than 1, the function returns `NaN`', opts, function test( t ) {
6565
var n;
6666
var i;
6767

68-
t.strictEqual( isnan( nonfibonacci( -3.14 ) ), true, 'returns NaN' );
68+
t.strictEqual( isnan( nonfibonacci( -3.14 ) ), true, 'returns expected value' );
6969

7070
for ( i = 0; i > -100; i-- ) {
7171
n = nonfibonacci( i );
72-
t.strictEqual( isnan( n ), true, 'returns NaN when provided ' + i );
72+
t.strictEqual( isnan( n ), true, 'returns expected value when provided ' + i );
7373
}
7474
t.end();
7575
});
7676

7777
tape( 'if provided a non-integer, the function returns `NaN`', opts, function test( t ) {
7878
var n = nonfibonacci( 3.14 );
7979

80-
t.strictEqual( isnan( n ), true, 'returns NaN' );
80+
t.strictEqual( isnan( n ), true, 'returns expected value' );
8181
t.end();
8282
});
8383

0 commit comments

Comments
 (0)