refactor: move _history and create accessor for count

Signed-off-by: Snehil Shah <[email protected]>

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Signed-off-by: Snehil Shah <[email protected]>

Author: Snehil-Shah

lib/node_modules/@stdlib/repl/base/ctor/README.md

@@ -92,6 +92,36 @@ var ws = repl.currentWorkspace;
 repl.close();
 ```
 
+#### REPL.prototype.quiet
+
+Boolean indicating whether log information, confirmation messages, and other possible REPL diagnostics should be silenced.
+
+```javascript
+// Create a new REPL:
+var repl = new REPL();
+
+// Check if the REPL is quiet:
+var out = repl.quiet;
+
+// Close the REPL:
+repl.close();
+```
+
+#### REPL.prototype.count
+
+Command count.
+
+```javascript
+// Create a new REPL:
+var repl = new REPL();
+
+// Get command count:
+var cnt = repl.count;
+
+// Close the REPL:
+repl.close();
+```
+
 ### Methods
 
 #### REPL.prototype.isMultilineInput( input )
@@ -453,25 +483,6 @@ var d = repl.clearWorkspace( 'base' );
 repl.close();
 ```
 
-#### REPL.prototype.clearHistory()
-
-Clears a REPL's history.
-
-```javascript
-// Create a new REPL:
-var repl = new REPL();
-
-// ...
-
-// Clear the REPL history:
-repl.clearHistory();
-
-// ...
-
-// Close the REPL:
-repl.close();
-```
-
 #### REPL.prototype.reset()
 
 Resets a REPL.

lib/node_modules/@stdlib/repl/base/ctor/lib/main.js

@@ -155,9 +155,6 @@ function REPL( options ) {
 	// Initialize an internal command queue:
 	setNonEnumerableReadOnly( this, '_queue', fifo() );
 
-	// Initialize a strided internal buffer for storing the command history:
-	setNonEnumerableReadOnly( this, '_history', [] );
-
 	// Initialize a executed command counter:
 	setNonEnumerable( this, '_count', -1 );
 
@@ -257,13 +254,10 @@ function REPL( options ) {
 	* @param {*} res - result
 	* @param {boolean} silent - boolean indicating whether the command output should be silenced
 	*/
-	function onCommand( cmd, success ) {
+	function onCommand() {
 		self._count += 1;
 		debug( 'Command count: %d', self._count );
 
-		// Update the internal command history buffer: [..., <id>, <cmd>, <success>, ...]
-		self._history.push( self._count, cmd, success );
-
 		// TODO: if successful and if necessary, (asynchronously?) write the command to a history file (question: do we only want to write successful commands to the history file? maybe we need to option for limiting to successful commands?)
 
 		// TODO: if necessary, (asynchronously?) write the command and result to a log file (JSON serialization?)
@@ -296,6 +290,48 @@ setReadOnlyAccessor( REPL.prototype, 'currentWorkspace', function get() {
 	return this._currentWorkspace;
 });
 
+/**
+* Boolean indicating whether log information, confirmation messages, and other possible REPL diagnostics should be silenced.
+*
+* @name quiet
+* @memberof REPL.prototype
+* @type {boolean}
+*
+* @example
+* // Create a new REPL:
+* var repl = new REPL();
+*
+* // Check if the REPL is quiet:
+* var out = repl.quiet;
+*
+* // Close the REPL:
+* repl.close();
+*/
+setReadOnlyAccessor( REPL.prototype, 'quiet', function get() {
+	return this._quiet;
+});
+
+/**
+* Command count.
+*
+* @name count
+* @memberof REPL.prototype
+* @type {number}
+*
+* @example
+* // Create a new REPL:
+* var repl = new REPL();
+*
+* // Get command count:
+* var cnt = repl.count;
+*
+* // Close the REPL:
+* repl.close();
+*/
+setReadOnlyAccessor( REPL.prototype, 'count', function get() {
+	return this._count;
+});
+
 /**
 * Checks if the given input is a possible multi-line command.
 *
@@ -1328,34 +1364,6 @@ setNonEnumerableReadOnly( REPL.prototype, 'clearWorkspace', function clearWorksp
 	return d;
 });
 
-/**
-* Clears a REPL's history.
-*
-* @name clearHistory
-* @memberof REPL.prototype
-* @type {Function}
-* @returns {REPL} REPL instance
-*
-* @example
-* // Create a new REPL:
-* var repl = new REPL();
-*
-* // ...
-*
-* // Clear the REPL history:
-* repl.clearHistory();
-*
-* // ...
-*
-* // Close the REPL:
-* repl.close();
-*/
-setNonEnumerableReadOnly( REPL.prototype, 'clearHistory', function clearHistory() {
-	debug( 'Resetting REPL history...' );
-	this._history.length = 0;
-	return this;
-});
-
 /**
 * Resets a REPL.
 *
@@ -1388,9 +1396,6 @@ setNonEnumerableReadOnly( REPL.prototype, 'reset', function onReset() {
 	// Reset the command queue:
 	this._queue.clear();
 
-	// Clear the command history:
-	this.clearHistory();
-
 	// Reset the execution context:
 	this.resetContext();
 

lib/node_modules/@stdlib/repl/lib/display_prompt.js

@@ -47,7 +47,7 @@ function displayPrompt( repl, preserveCursor ) {
 	}
 	len = repl._cmd.length;
 	if ( len === 0 ) {
-		if ( repl._padding && repl._count >= 0 ) {
+		if ( repl._padding && repl.count >= 0 ) {
 			repl._ostream.write( repeat( '\n', repl._padding ) );
 		}
 		repl._rli.setPrompt( repl._prompt() );

lib/node_modules/@stdlib/repl/lib/eager_evaluator.js

@@ -323,7 +323,7 @@ setNonEnumerableReadOnly( EagerEvaluator.prototype, 'onKeypress', function onKey
 		res = res.slice( 0, index ) + '...';
 	}
 	cursorPosition = this._rli.cursor;
-	pre = replace( this._repl._outputPrompt, '%d', ( this._repl._count+1 ).toString() );
+	pre = replace( this._repl._outputPrompt, '%d', ( this._repl.count+1 ).toString() );
 	this._repl._ostream.write( '\n' + ANSI_GRAY + pre + res + ANSI_RESET );
 	readline.moveCursor( this._repl._ostream, 0, -1 );
 	readline.cursorTo( this._repl._ostream, cursorPosition + this._repl.promptLength() );

lib/node_modules/@stdlib/repl/lib/log.js

@@ -34,7 +34,7 @@
 * @param {string} msg - message
 */
 function log( repl, msg ) {
-	if ( repl._quiet === false ) {
+	if ( repl.quiet === false ) {
 		repl._ostream.write( msg+'\n' );
 	}
 }

lib/node_modules/@stdlib/repl/lib/main.js

@@ -209,6 +209,9 @@ function REPL( options ) {
 	// Initialize an internal buffer for storing the current command:
 	setNonEnumerableReadOnly( this, '_cmd', [] );
 
+	// Initialize a strided internal buffer for storing the command history:
+	setNonEnumerableReadOnly( this, '_history', [] );
+
 	// Initialize a strided internal buffer for storing user-defined documentation:
 	setNonEnumerableReadOnly( this, '_userdocs', [] );
 
@@ -469,10 +472,13 @@ function REPL( options ) {
 		var pre;
 		var tmp;
 
+		// Update the internal command history buffer: [..., <id>, <cmd>, <success>, ...]
+		self._history.push( self.count, cmd, success );
+
 		if ( success === false ) {
 			self._ostream.write( 'Error: '+res.message+'\n' );
 		} else if ( !silent && res !== void 0 ) {
-			pre = replace( self._outputPrompt, '%d', self._count.toString() );
+			pre = replace( self._outputPrompt, '%d', self.count.toString() );
 
 			if ( isndarrayLike( res ) ) {
 				tmp = res.toString(); // FIXME: this is a hack in order to avoid printing private ndarray properties in the REPL, as done by the built-in `util.inspect`. Ideally, we'd roll our own inspector which specifically accommodates stdlib's ndarray and other specialized classes.
@@ -521,7 +527,7 @@ setNonEnumerableReadOnly( REPL.prototype, '_displayPrompt', function showPrompt(
 * @returns {string} command prompt
 */
 setNonEnumerableReadOnly( REPL.prototype, '_prompt', function prompt() {
-	return inputPrompt( this._inputPrompt, this._count );
+	return inputPrompt( this._inputPrompt, this.count );
 });
 
 /**
@@ -1094,6 +1100,9 @@ setNonEnumerableReadOnly( REPL.prototype, 'reset', function onReset() {
 	// Call the parent method:
 	BaseREPL.prototype.reset.call( this );
 
+	// Clear the command history:
+	this.clearHistory();
+
 	// Clear any command which has been buffered but not yet executed:
 	this.clearCommand();
 
@@ -1134,6 +1143,34 @@ setNonEnumerableReadOnly( REPL.prototype, 'clearUserDocs', function clearUserDoc
 	return this;
 });
 
+/**
+* Clears a REPL's history.
+*
+* @name clearHistory
+* @memberof REPL.prototype
+* @type {Function}
+* @returns {REPL} REPL instance
+*
+* @example
+* // Create a new REPL:
+* var repl = new REPL();
+*
+* // ...
+*
+* // Clear the REPL history:
+* repl.clearHistory();
+*
+* // ...
+*
+* // Close the REPL:
+* repl.close();
+*/
+setNonEnumerableReadOnly( REPL.prototype, 'clearHistory', function clearHistory() {
+	debug( 'Resetting REPL history...' );
+	this._history.length = 0;
+	return this;
+});
+
 /**
 * Clears the entire REPL screen and scrollback history.
 *