refactor: resolve error constructor and add todos

Author: kgryte

lib/node_modules/@stdlib/ndarray/fancy/lib/error_constructor.js

@@ -22,7 +22,6 @@
 
 var slice = require( '@stdlib/ndarray/base/slice' );
 var errMessage = require( './error_message.js' );
-var errConstructor = require( './error_constructor.js' );
 
 
 // MAIN //
@@ -39,18 +38,16 @@ var errConstructor = require( './error_constructor.js' );
 * @throws {RangeError} number of slice dimensions must match the number of array dimensions
 * @returns {FancyArray} result
 */
-function getSlice( target, property, receiver, prop2slice ) { // eslint-disable-line stdlib/jsdoc-require-throws-tags
+function getSlice( target, property, receiver, prop2slice ) {
 	var strict;
-	var E;
 	var s;
 
 	strict = false; // TODO: support strict mode
 	s = prop2slice( target, property, strict );
 	try {
 		return slice( receiver, s, strict, false );
 	} catch ( err ) {
-		E = errConstructor( err );
-		throw new E( errMessage( err.message ) );
+		throw new err.constructor( errMessage( err.message ) );
 	}
 }
 

lib/node_modules/@stdlib/ndarray/fancy/lib/get_slice.js

@@ -58,7 +58,7 @@ function prop2slice( target, property ) {
 	// Case: slice
 	if ( ch === 'S' ) {
 		// Convert the string to a slice object:
-		s = str2slice( property );
+		s = str2slice( prop );
 		if ( s === null ) {
 			throw new Error( format( 'invalid operation. Unsupported slice operation. Value: `%s`.', property ) );
 		}
@@ -104,7 +104,7 @@ function prop2slice( target, property ) {
 		s = new MultiSlice();
 	}
 	// Case: non-empty string
-	else {
+	else { // FIXME: need to gracefully handle non-existent properties
 		throw new Error( format( 'invalid operation. Unsupported slice operation. Value: `%s`.', property ) );
 	}
 	return s;

lib/node_modules/@stdlib/ndarray/fancy/lib/prop2slice.0d.js

@@ -57,7 +57,7 @@ function prop2slice( target, property, strict ) {
 	// Case: slice
 	if ( ch === 'S' ) {
 		// Convert the string to a slice object:
-		s = str2slice( property );
+		s = str2slice( prop );
 		if ( s === null ) {
 			throw new Error( format( 'invalid operation. Unsupported slice operation. Value: `%s`.', property ) );
 		}
@@ -81,7 +81,7 @@ function prop2slice( target, property, strict ) {
 		s = new MultiSlice( s );
 	}
 	// Case: subsequence string
-	else if ( prop.length > 0 ) {
+	else if ( prop.length > 0 ) { // FIXME: need to gracefully handle non-existent properties
 		shape = target.shape;
 		s = seq2multislice( prop, shape, true );
 		if ( s.code ) {

lib/node_modules/@stdlib/ndarray/fancy/lib/prop2slice.1d.js

@@ -86,7 +86,7 @@ function prop2slice( target, property, strict ) {
 	// Case: array syntax (e.g., [ Slice(0,10,1), null, Slice(4,null,-1) ]) or Slice or integer or arbitrary string (where the latter three are not valid for >2d arrays)
 	else {
 		s = sargs2multislice( prop );
-		if ( s === null ) {
+		if ( s === null ) { // FIXME: need to gracefully handle non-existent properties
 			throw new Error( format( 'invalid operation. Unsupported slice operation. Value: `%s`.', property ) );
 		}
 	}

lib/node_modules/@stdlib/ndarray/fancy/lib/prop2slice.nd.js

@@ -38,7 +38,6 @@ var complexDataType = require( '@stdlib/complex/dtype' );
 var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
 var format = require( '@stdlib/string/format' );
 var errMessage = require( './error_message.js' );
-var errConstructor = require( './error_constructor.js' );
 
 
 // FUNCTIONS //
@@ -75,11 +74,10 @@ function options( dtype ) {
 * @throws {TypeError} target array must have a supported data type
 * @returns {boolean} boolean indicating whether assignment succeeded
 */
-function setSlice( target, property, value, receiver, prop2slice ) { // eslint-disable-line stdlib/jsdoc-require-throws-tags
+function setSlice( target, property, value, receiver, prop2slice ) {
 	var strict;
 	var vdt;
 	var dt;
-	var E;
 	var s;
 
 	if ( !isndarrayLike( value ) ) {
@@ -89,15 +87,15 @@ function setSlice( target, property, value, receiver, prop2slice ) { // eslint-d
 		if ( dt === 'generic' ) {
 			value = scalar2ndarray( value, options( dt ) );
 		}
-		// If the input value is real-valued number, we need to inspect the value to determine whether we can safely cast the value to the target array data type...
+		// If the input value is a real-valued number, we need to inspect the value to determine whether we can safely cast the value to the target array data type...
 		else if ( isNumber( value ) ) {
-			// If the target array has a floating-point data type, we can just go ahead and cast the input scalar to the target array data type...
+			// If the target array has a floating-point data type, we can just go ahead and cast the input scalar to the target array data type, as number literals are, by default, double-precision floating-point values and casting to lower-precision floating-point is allowed...
 			if ( isFloatingDataType( dt ) ) {
 				value = scalar2ndarray( value, options( dt ) );
 			}
 			// If the target array has an unsigned integer data type, then the assigned value must be a compatible nonnegative integer value...
 			else if ( isUnsignedIntegerDataType( dt ) ) {
-				vdt = minDataType( value );
+				vdt = minDataType( value ); // note: we rely on data type resolution to handle the case where `value` is a non-integer value. In that case, `vdt` will resolve to a floating-point data type and `isSafeCast` will evaluate to `false`
 				if ( isSafeCast( vdt, dt ) ) {
 					value = scalar2ndarray( value, options( dt ) );
 				} else {
@@ -160,8 +158,7 @@ function setSlice( target, property, value, receiver, prop2slice ) { // eslint-d
 		sliceAssign( value, receiver, s, strict );
 		return true;
 	} catch ( err ) {
-		E = errConstructor( err );
-		throw new E( errMessage( err.message ) );
+		throw new err.constructor( errMessage( err.message ) );
 	}
 }