chore: apply review changes

Author: headlessNode

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/README.md

@@ -97,7 +97,7 @@ The function has the following additional parameters:
 
 -   **offsetX**: starting index for `x`.
 
-While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the sum of every other value in `x` starting from the second value:
+While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to calculate the sum of every other element starting from the second element:
 
 ```javascript
 var Float64Array = require( '@stdlib/array/float64' );

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/benchmark/benchmark.js

@@ -32,6 +32,19 @@ var dnansumkbn2 = require( './../lib/dnansumkbn2.js' );
 
 // FUNCTIONS //
 
+/**
+* Returns a random number.
+*
+* @private
+* @returns {number} random number
+*/
+function rand() {
+	if ( bernoulli( 0.7 ) > 0 ) {
+		return uniform( -100.0, 100.0 );
+	}
+	return NaN;
+}
+
 /**
 * Creates a benchmark function.
 *
@@ -40,16 +53,9 @@ var dnansumkbn2 = require( './../lib/dnansumkbn2.js' );
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x = filledarrayBy( len, 'float64', clbk );
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
-	function clbk() {
-		if ( bernoulli( 0.7 ) > 0 ) {
-			return uniform( -10.0, 10.0 );
-		}
-		return NaN;
-	}
-
 	function benchmark( b ) {
 		var v;
 		var i;

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/benchmark/benchmark.native.js

@@ -41,6 +41,19 @@ var opts = {
 
 // FUNCTIONS //
 
+/**
+* Returns a random number.
+*
+* @private
+* @returns {number} random number
+*/
+function rand() {
+	if ( bernoulli( 0.7 ) > 0 ) {
+		return uniform( -100.0, 100.0 );
+	}
+	return NaN;
+}
+
 /**
 * Creates a benchmark function.
 *
@@ -49,16 +62,9 @@ var opts = {
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x = filledarrayBy( len, 'float64', clbk );
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
-	function clbk() {
-		if ( bernoulli( 0.7 ) > 0 ) {
-			return uniform( -10.0, 10.0 );
-		}
-		return NaN;
-	}
-
 	function benchmark( b ) {
 		var v;
 		var i;

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/benchmark/benchmark.ndarray.js

@@ -32,6 +32,19 @@ var dnansumkbn2 = require( './../lib/ndarray.js' );
 
 // FUNCTIONS //
 
+/**
+* Returns a random number.
+*
+* @private
+* @returns {number} random number
+*/
+function rand() {
+	if ( bernoulli( 0.7 ) > 0 ) {
+		return uniform( -100.0, 100.0 );
+	}
+	return NaN;
+}
+
 /**
 * Creates a benchmark function.
 *
@@ -40,16 +53,9 @@ var dnansumkbn2 = require( './../lib/ndarray.js' );
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x = filledarrayBy( len, 'float64', clbk );
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
-	function clbk() {
-		if ( bernoulli( 0.7 ) > 0 ) {
-			return uniform( -10.0, 10.0 );
-		}
-		return NaN;
-	}
-
 	function benchmark( b ) {
 		var v;
 		var i;

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/benchmark/benchmark.ndarray.native.js

@@ -41,6 +41,19 @@ var opts = {
 
 // FUNCTIONS //
 
+/**
+* Returns a random number.
+*
+* @private
+* @returns {number} random number
+*/
+function rand() {
+	if ( bernoulli( 0.7 ) > 0 ) {
+		return uniform( -100.0, 100.0 );
+	}
+	return NaN;
+}
+
 /**
 * Creates a benchmark function.
 *
@@ -49,16 +62,9 @@ var opts = {
 * @returns {Function} benchmark function
 */
 function createBenchmark( len ) {
-	var x = filledarrayBy( len, 'float64', clbk );
+	var x = filledarrayBy( len, 'float64', rand );
 	return benchmark;
 
-	function clbk() {
-		if ( bernoulli( 0.7 ) > 0 ) {
-			return uniform( -10.0, 10.0 );
-		}
-		return NaN;
-	}
-
 	function benchmark( b ) {
 		var v;
 		var i;

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/lib/dnansumkbn2.js

@@ -46,9 +46,8 @@ var ndarray = require( './ndarray.js' );
 * var Float64Array = require( '@stdlib/array/float64' );
 *
 * var x = new Float64Array( [ 1.0, -2.0, NaN, 2.0 ] );
-* var N = x.length;
 *
-* var v = dnansumkbn2( N, x, 1 );
+* var v = dnansumkbn2( x.length, x, 1 );
 * // returns 1.0
 */
 function dnansumkbn2( N, x, strideX ) {

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/lib/dnansumkbn2.native.js

@@ -37,9 +37,8 @@ var addon = require( './../src/addon.node' );
 * var Float64Array = require( '@stdlib/array/float64' );
 *
 * var x = new Float64Array( [ 1.0, -2.0, NaN, 2.0 ] );
-* var N = x.length;
 *
-* var v = dnansumkbn2( N, x, 1 );
+* var v = dnansumkbn2( x.length, x, 1 );
 * // returns 1.0
 */
 function dnansumkbn2( N, x, strideX ) {

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/lib/index.js

@@ -38,7 +38,7 @@
 *
 * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0, NaN, NaN ] );
 *
-* var v = dnansumkbn2.ndarray( 5, x, 2, 1 );
+* var v = dnansumkbn2.ndarray( x.length, x, 2, 1 );
 * // returns 5.0
 */
 

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/lib/ndarray.js

@@ -71,8 +71,7 @@ function dnansumkbn2( N, x, strideX, offsetX ) {
 		if ( isnan( x[ ix ] ) ) {
 			return sum;
 		}
-		sum = x[ ix ] * N;
-		return sum;
+		return x[ ix ] * N;
 	}
 	ccs = 0.0; // second order correction term for lost low order bits
 	cs = 0.0; // first order correction term for lost low order bits

lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/src/main.c

@@ -80,8 +80,7 @@ double API_SUFFIX(stdlib_strided_dnansumkbn2_ndarray)( const CBLAS_INT N, const
 		if ( stdlib_base_is_nan( X[ ix ] ) ) {
 			return sum;
 		}
-		sum = X[ ix ] * N;
-		return sum;
+		return X[ ix ] * N;
 	}
 	ccs = 0.0; // second order correction term for lost lower order bits
 	cs = 0.0; // first order correction term for lost low order bits