Apply suggestions from code review

Signed-off-by: Athan <[email protected]>

Author: kgryte

lib/node_modules/@stdlib/blas/base/igamax/README.md

@@ -45,9 +45,9 @@ The function has the following parameters:
 
 -   **N**: number of indexed elements.
 -   **x**: input array.
--   **strideX**: index increment for `x`.
+-   **strideX**: stride length for `x`.
 
-The `N` and `strideX` parameters determine which elements in `x` are accessed at runtime. For example, to traverse every other value,
+The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to traverse every other value,
 
 ```javascript
 var x = [ -2.0, 1.0, 3.0, -5.0, 4.0, 0.0, -1.0, -3.0 ];
@@ -87,7 +87,7 @@ The function has the following additional parameters:
 
 -   **offsetX**: starting index.
 
-While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the `offset` parameter supports indexing semantics based on a starting index. For example, to start from the second index,
+While [`typed array`][mdn-typed-array] views mandate a view offset based on the underlying buffer, the offset parameter supports indexing semantics based on a starting index. For example, to start from the second index,
 
 ```javascript
 var x = [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ];

lib/node_modules/@stdlib/blas/base/igamax/docs/repl.txt

@@ -2,8 +2,8 @@
 {{alias}}( N, x, strideX )
     Finds the index of the first element having the maximum absolute value.
 
-    The `N` and `strideX` parameters determine which elements in `x` are
-    accessed at runtime.
+    The `N` and stride parameters determine which elements in the strided array
+    are accessed at runtime.
 
     Indexing is relative to the first index. To introduce an offset, use typed
     array views.
@@ -16,10 +16,10 @@
         Number of indexed elements.
 
     x: Array<number>|TypedArray
-        First input array.
+        Input array.
 
     strideX: integer
-        Index increment for `x`.
+        Stride length for `x`.
 
     Returns
     -------
@@ -33,7 +33,7 @@
     > var idx = {{alias}}( x.length, x, 1 )
     3
 
-    // Using `N` and `strideX` parameters:
+    // Using `N` and stride parameters:
     > x = [ -2.0, 1.0, 3.0, -5.0 ];
     > idx = {{alias}}( 2, x, 2 )
     1
@@ -50,19 +50,19 @@
     alternative indexing semantics.
 
     While typed array views mandate a view offset based on the underlying
-    buffer, the `offsetX` parameter supports indexing semantics based on a
-    starting index.
+    buffer, the offset parameter supports indexing semantics based on a starting
+    index.
 
     Parameters
     ----------
     N: integer
         Number of indexed elements.
 
     x: Array<number>|TypedArray
-        First input array.
+        Input array.
 
     strideX: integer
-        Index increment for `x`.
+        Stride length for `x`.
 
     offsetX: integer
         Starting index of `x`.
@@ -79,7 +79,7 @@
     > var idx = {{alias}}.ndarray( x.length, x, 1, 0 )
     3
 
-    // Using an index offset:
+    // Using an offset:
     > x = [ 1.0, -2.0, 3.0, -4.0, 5.0, -6.0 ];
     > idx = {{alias}}.ndarray( 3, x, 2, 1 )
     2

lib/node_modules/@stdlib/blas/base/igamax/lib/accessors.js

@@ -47,8 +47,8 @@ var abs = require( '@stdlib/math/base/special/abs' );
 * // returns 4
 */
 function igamax( N, x, strideX, offsetX ) {
-	var dmax;
 	var xbuf;
+	var max;
 	var idx;
 	var get;
 	var ix;
@@ -61,17 +61,14 @@ function igamax( N, x, strideX, offsetX ) {
 	// Cache references to element accessors:
 	get = x.accessors[ 0 ];
 
+	max = abs( get( xbuf, offsetX ) );
 	idx = 0;
-	if ( N === 1 ) {
-		return idx;
-	}
-	dmax = abs( get( xbuf, offsetX ) );
 	ix = offsetX + strideX;
 	for ( i = 1; i < N; i++ ) {
 		v = abs( get( xbuf, ix ) );
-		if ( v > dmax ) {
+		if ( v > max ) {
 			idx = i;
-			dmax = v;
+			max = v;
 		}
 		ix += strideX;
 	}

lib/node_modules/@stdlib/blas/base/igamax/lib/ndarray.js

@@ -43,7 +43,7 @@ var accessors = require( './accessors.js' );
 * // returns 4
 */
 function igamax( N, x, strideX, offsetX ) {
-	var smax;
+	var max;
 	var idx;
 	var ix;
 	var ox;
@@ -53,21 +53,21 @@ function igamax( N, x, strideX, offsetX ) {
 	if ( N < 1 ) {
 		return -1;
 	}
+	if ( N === 1 ) {
+		return 0;
+	}
 	ox = arraylike2object( x );
 	if ( ox.accessorProtocol ) {
 		return accessors( N, ox, strideX, offsetX );
 	}
+	max = abs( x[ offsetX ] );
 	idx = 0;
-	if ( N === 1 ) {
-		return idx;
-	}
-	smax = abs( x[ offsetX ] );
 	ix = offsetX + strideX;
 	for ( i = 1; i < N; i++ ) {
 		v = abs( x[ ix ] );
-		if ( v > smax ) {
+		if ( v > max ) {
 			idx = i;
-			smax = v;
+			max = v;
 		}
 		ix += strideX;
 	}