Skip to content

Commit 17ac94a

Browse files
chore: refactor cabsf and cabs2f
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 5e11a37 commit 17ac94a

File tree

8 files changed

+40
-28
lines changed

8 files changed

+40
-28
lines changed

lib/node_modules/@stdlib/math/base/special/cabs/benchmark/c/native/benchmark.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ static double benchmark( void ) {
108108

109109
t = tic();
110110
for ( i = 0; i < ITERATIONS; i++ ) {
111-
z = stdlib_complex128( re[ i % 100 ], im[ i % 100 ] );
111+
z = stdlib_complex128( re[ i%100 ], im[ i%100 ] );
112112
y = stdlib_base_cabs( z );
113113
if ( y != y ) {
114114
printf( "should not return NaN\n" );

lib/node_modules/@stdlib/math/base/special/cabs2/benchmark/c/native/benchmark.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ static double benchmark( void ) {
108108

109109
t = tic();
110110
for ( i = 0; i < ITERATIONS; i++ ) {
111-
z = stdlib_complex128( re[ i % 100 ], im[ i % 100 ] );
111+
z = stdlib_complex128( re[ i%100 ], im[ i%100 ] );
112112
y = stdlib_base_cabs2( z );
113113
if ( y != y ) {
114114
printf( "should not return NaN\n" );

lib/node_modules/@stdlib/math/base/special/cabs2f/benchmark/c/benchmark.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,19 +99,22 @@ float cabs2f( float complex z ) {
9999
* @return elapsed time in seconds
100100
*/
101101
static double benchmark( void ) {
102+
double re[ 100 ];
103+
double im[ 100 ];
102104
float complex z;
103105
double elapsed;
104106
double t;
105-
float re;
106-
float im;
107107
float y;
108108
int i;
109109

110+
for ( i = 0; i < 100; i++ ) {
111+
re[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
112+
im[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
113+
}
114+
110115
t = tic();
111116
for ( i = 0; i < ITERATIONS; i++ ) {
112-
re = ( 1000.0f*rand_float() ) - 500.0f;
113-
im = ( 1000.0f*rand_float() ) - 500.0f;
114-
z = re + im*I;
117+
z = re[ i%100 ] + im[ i%100 ]*I;
115118
y = cabs2f( z );
116119
if ( y != y ) {
117120
printf( "should not return NaN\n" );

lib/node_modules/@stdlib/math/base/special/cabs2f/benchmark/c/native/benchmark.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,19 +91,22 @@ static float rand_float( void ) {
9191
* @return elapsed time in seconds
9292
*/
9393
static double benchmark( void ) {
94+
double re[ 100 ];
95+
double im[ 100 ];
9496
float complex z;
9597
double elapsed;
9698
double t;
97-
float re;
98-
float im;
9999
float y;
100100
int i;
101101

102+
for ( i = 0; i < 100; i++ ) {
103+
re[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
104+
im[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
105+
}
106+
102107
t = tic();
103108
for ( i = 0; i < ITERATIONS; i++ ) {
104-
re = ( 1000.0f*rand_float() ) - 500.0f;
105-
im = ( 1000.0f*rand_float() ) - 500.0f;
106-
z = re + im*I;
109+
z = re[ i%100 ] + im[ i%100 ]*I;
107110
y = stdlib_base_cabs2f( z );
108111
if ( y != y ) {
109112
printf( "should not return NaN\n" );

lib/node_modules/@stdlib/math/base/special/cabs2f/test/test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,13 @@ tape( 'if either the real or imaginary component is `NaN`, the function returns
7171
var v;
7272

7373
v = cabs2f( new Complex64( NaN, 3.0 ) );
74-
t.strictEqual( isnanf( v ), true, 'returns NaN' );
74+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
7575

7676
v = cabs2f( new Complex64( 5.0, NaN ) );
77-
t.strictEqual( isnanf( v ), true, 'returns NaN' );
77+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
7878

7979
v = cabs2f( new Complex64( NaN, NaN ) );
80-
t.strictEqual( isnanf( v ), true, 'returns NaN' );
80+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
8181

8282
t.end();
8383
});

lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/benchmark.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,19 +89,22 @@ static float rand_float( void ) {
8989
* @return elapsed time in seconds
9090
*/
9191
static double benchmark( void ) {
92+
double re[ 100 ];
93+
double im[ 100 ];
9294
float complex z;
9395
double elapsed;
9496
double t;
95-
float re;
96-
float im;
9797
float y;
9898
int i;
9999

100+
for ( i = 0; i < 100; i++ ) {
101+
re[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
102+
im[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
103+
}
104+
100105
t = tic();
101106
for ( i = 0; i < ITERATIONS; i++ ) {
102-
re = ( 1000.0f*rand_float() ) - 500.0f;
103-
im = ( 1000.0f*rand_float() ) - 500.0f;
104-
z = re + im*I;
107+
z = re[ i%100 ] + im[ i%100 ]*I;
105108
y = cabsf( z );
106109
if ( y != y ) {
107110
printf( "should not return NaN\n" );

lib/node_modules/@stdlib/math/base/special/cabsf/benchmark/c/native/benchmark.c

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,19 +91,22 @@ static float rand_float( void ) {
9191
* @return elapsed time in seconds
9292
*/
9393
static double benchmark( void ) {
94+
double re[ 100 ];
95+
double im[ 100 ];
9496
float complex z;
9597
double elapsed;
9698
double t;
97-
float re;
98-
float im;
9999
float y;
100100
int i;
101101

102+
for ( i = 0; i < 100; i++ ) {
103+
re[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
104+
im[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
105+
}
106+
102107
t = tic();
103108
for ( i = 0; i < ITERATIONS; i++ ) {
104-
re = ( 1000.0f*rand_float() ) - 500.0f;
105-
im = ( 1000.0f*rand_float() ) - 500.0f;
106-
z = re + im*I;
109+
z = re[ i%100 ] + im[ i%100 ]*I;
107110
y = stdlib_base_cabsf( z );
108111
if ( y != y ) {
109112
printf( "should not return NaN\n" );

lib/node_modules/@stdlib/math/base/special/cabsf/test/test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,13 @@ tape( 'if either the real or imaginary component is `NaN`, the function returns
7171
var v;
7272

7373
v = cabsf( new Complex64( NaN, 3.0 ) );
74-
t.strictEqual( isnanf( v ), true, 'returns NaN' );
74+
t.strictEqual( isnanf( v ), true, 'expected value' );
7575

7676
v = cabsf( new Complex64( 5.0, NaN ) );
77-
t.strictEqual( isnanf( v ), true, 'returns NaN' );
77+
t.strictEqual( isnanf( v ), true, 'expected value' );
7878

7979
v = cabsf( new Complex64( NaN, NaN ) );
80-
t.strictEqual( isnanf( v ), true, 'returns NaN' );
80+
t.strictEqual( isnanf( v ), true, 'expected value' );
8181

8282
t.end();
8383
});

0 commit comments

Comments
 (0)