Skip to content

Commit 1bbdc5f

Browse files
chore: changes as per code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 5edec09 commit 1bbdc5f

File tree

5 files changed

+14
-6
lines changed

5 files changed

+14
-6
lines changed

lib/node_modules/@stdlib/stats/base/dists/geometric/median/examples/c/example.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "stdlib/stats/base/dists/geometric/median.h"
2020
#include <stdlib.h>
2121
#include <stdio.h>
22-
#include <math.h>
2322

2423
static double random_uniform( const double min, const double max ) {
2524
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );

lib/node_modules/@stdlib/stats/base/dists/geometric/median/lib/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ var log2 = require( '@stdlib/math/base/special/log2' );
5252
function median( p ) {
5353
if (
5454
isnan( p ) ||
55-
p <= 0.0 ||
55+
p < 0.0 ||
5656
p > 1.0
5757
) {
5858
return NaN;

lib/node_modules/@stdlib/stats/base/dists/geometric/median/lib/native.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var addon = require( './../src/addon.node' );
2828
/**
2929
* Returns the median of a geometric distribution.
3030
*
31+
* @private
3132
* @param {Probability} p - success probability
3233
* @returns {NonNegativeInteger} median
3334
*

lib/node_modules/@stdlib/stats/base/dists/geometric/median/manifest.json

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@
3939
"libpath": [],
4040
"dependencies": [
4141
"@stdlib/math/base/napi/unary",
42-
"@stdlib/math/base/assert/is-nan"
42+
"@stdlib/math/base/assert/is-nan",
43+
"@stdlib/math/base/special/ceil",
44+
"@stdlib/math/base/special/log2"
4345
]
4446
},
4547
{
@@ -54,7 +56,9 @@
5456
"libraries": [],
5557
"libpath": [],
5658
"dependencies": [
57-
"@stdlib/math/base/assert/is-nan"
59+
"@stdlib/math/base/assert/is-nan",
60+
"@stdlib/math/base/special/ceil",
61+
"@stdlib/math/base/special/log2"
5862
]
5963
},
6064
{
@@ -69,7 +73,9 @@
6973
"libraries": [],
7074
"libpath": [],
7175
"dependencies": [
72-
"@stdlib/math/base/assert/is-nan"
76+
"@stdlib/math/base/assert/is-nan",
77+
"@stdlib/math/base/special/ceil",
78+
"@stdlib/math/base/special/log2"
7379
]
7480
}
7581
]

lib/node_modules/@stdlib/stats/base/dists/geometric/median/src/main.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@
1818

1919
#include "stdlib/stats/base/dists/geometric/median.h"
2020
#include "stdlib/math/base/assert/is_nan.h"
21+
#include "stdlib/math/base/special/ceil.h"
22+
#include "stdlib/math/base/special/log2.h"
2123
#include <math.h>
2224

2325
/**
@@ -38,5 +40,5 @@ double stdlib_base_dists_geometric_median( const double p ) {
3840
) {
3941
return 0.0 / 0.0; // NaN
4042
}
41-
return ceil( -1.0 / ( log2( 1.0 - p ) ) ) - 1.0;
43+
return stdlib_base_ceil( -1.0 / ( stdlib_base_log2( 1.0 - p ) ) ) - 1.0;
4244
}

0 commit comments

Comments
 (0)