refactor: apply suggestions from code review

Author: headlessNode

lib/node_modules/@stdlib/ndarray/base/nullary-strided1d-dispatch-factory/benchmark/benchmark.assign.js

@@ -25,7 +25,6 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' );
 var pow = require( '@stdlib/math/base/special/pow' );
 var dtypes = require( '@stdlib/array/dtypes' );
 var uniform = require( '@stdlib/random/array/uniform' );
-var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
 var ndarray = require( '@stdlib/ndarray/base/ctor' );
 var gsorthp = require( '@stdlib/blas/ext/base/ndarray/gsorthp' );
 var pkg = require( './../package.json' ).name;
@@ -60,9 +59,7 @@ function createBenchmark( len ) {
 		'dtype': 'float64'
 	});
 	x = new ndarray( 'float64', x, [ len ], [ 1 ], 0, 'row-major' );
-	o = scalar2ndarray( 1.0, {
-		'dtype': 'generic'
-	});
+	o = new ndarray( 'generic', [ 1 ], [], [ 1 ], 0, 'row-major' );
 
 	return benchmark;
 
@@ -73,18 +70,18 @@ function createBenchmark( len ) {
 	* @param {Benchmark} b - benchmark instance
 	*/
 	function benchmark( b ) {
-		var o;
+		var out;
 		var i;
 
 		b.tic();
 		for ( i = 0; i < b.iterations; i++ ) {
-			o = nullary.assign( x, o );
-			if ( typeof o !== 'object' ) {
+			out = nullary.assign( x, o );
+			if ( typeof out !== 'object' ) {
 				b.fail( 'should return an ndarray' );
 			}
 		}
 		b.toc();
-		if ( isnan( o.get( i%len ) ) ) {
+		if ( isnan( out.get( i%len ) ) ) {
 			b.fail( 'should not return NaN' );
 		}
 		b.pass( 'benchmark finished' );