refactor: cleanup & fixes

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/ndarray/concat/docs/repl.txt

@@ -49,7 +49,7 @@
     --------
     > var x = {{alias:@stdlib/ndarray/array}}( [ [ 1.0 ], [ 2.0 ] ] );
     > var y = {{alias:@stdlib/ndarray/array}}( [ [ 3.0 ], [ 4.0 ] ] );
-    > var z = {{alias:@stdlib/ndarra/array}}( [ [ 0.0, 0.0 ], [ 0.0, 0.0 ] ] );
+    > var z = {{alias:@stdlib/ndarray/array}}( [ [ 0.0, 0.0 ], [ 0.0, 0.0 ] ] );
     > var out = {{alias}}.assign( [ x, y ], z, -1 )
     <ndarray>
     > var bool = ( out === z )

lib/node_modules/@stdlib/ndarray/concat/lib/assign.js

@@ -48,8 +48,8 @@ var output = require( './output.js' );
 * @param {ndarray} out - output ndarray
 * @param {NegativeInteger} dim - dimension along which the ndarrays are concatenated
 * @throws {TypeError} first argument must be an array of ndarray-like objects
-* @throws {RangeError} first argument must have more than one ndarray
-* @throws {TypeError} second argument must be an array of ndarray-like objects
+* @throws {RangeError} first argument must have one or more ndarrays
+* @throws {TypeError} second argument must be an ndarray-like object
 * @returns {ndarray} output ndarray
 *
 * @example
@@ -96,10 +96,10 @@ function assign( arrays, out, dim ) {
 
 	if ( arguments.length > 1 ) {
 		if ( !isInteger( dim ) ) {
-			throw new TypeError( format( 'invalid argument. Second argument must be a negative integer. Value: `%s`.', dim ) );
+			throw new TypeError( format( 'invalid argument. Third argument must be a negative integer. Value: `%s`.', dim ) );
 		}
 		if ( isNonNegativeInteger( dim ) ) {
-			throw new TypeError( format( 'invalid argument. Second argument must be a negative integer. Value: `%s`.', dim ) );
+			throw new TypeError( format( 'invalid argument. Third argument must be a negative integer. Value: `%s`.', dim ) );
 		}
 	}
 

lib/node_modules/@stdlib/ndarray/concat/test/test.assign.js

@@ -38,7 +38,7 @@ tape( 'main export is a function', function test( t ) {
 	t.end();
 });
 
-tape( 'the function throws an error if provided a first argument which is not an array of ndarrays', function test( t ) {
+tape( 'the function throws an error if provided a first argument which is not an array of ndarrays or an empty array', function test( t ) {
 	var values;
 	var out;
 	var i;
@@ -54,13 +54,18 @@ tape( 'the function throws an error if provided a first argument which is not an
 		null,
 		void 0,
 		{},
+		[],
 		[ 'beep', 'boop' ],
 		[ 1, 2, 3 ],
 		[ null ]
 	];
 
 	for ( i = 0; i < values.length; i++ ) {
-		t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] );
+		if ( i === 8 ) {
+			t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+		} else {
+			t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] );
+		}
 	}
 	t.end();
 
@@ -71,12 +76,14 @@ tape( 'the function throws an error if provided a first argument which is not an
 	}
 });
 
-tape( 'the function throws an error if provided a second argument which is not an ndarray', function test( t ) {
+tape( 'the function throws an error if provided a second argument which is not an ndarray or has incompatible shape', function test( t ) {
 	var values;
 	var x;
+	var y;
 	var i;
 
 	x = zeros( [ 2, 2 ] );
+	y = zeros( [ 2, 2 ] );
 
 	values = [
 		'5',
@@ -88,17 +95,22 @@ tape( 'the function throws an error if provided a second argument which is not a
 		void 0,
 		[],
 		{},
-		function noop() {}
+		function noop() {},
+		zeros( [ 3, 4 ] )
 	];
 
 	for ( i = 0; i < values.length; i++ ) {
-		t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] );
+		if ( i === 10 ) {
+			t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+		} else {
+			t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] );
+		}
 	}
 	t.end();
 
 	function badValue( value ) {
 		return function badValue() {
-			assign( [ x ], value, -1 );
+			assign( [ x, y ], value, -1 );
 		};
 	}
 });

lib/node_modules/@stdlib/ndarray/concat/test/test.main.js

@@ -39,7 +39,7 @@ tape( 'main export is a function', function test( t ) {
 	t.end();
 });
 
-tape( 'the function throws an error if provided a first argument which is not an array of ndarrays', function test( t ) {
+tape( 'the function throws an error if provided a first argument which is not an array of ndarrays or an empty array', function test( t ) {
 	var values;
 	var i;
 
@@ -52,13 +52,18 @@ tape( 'the function throws an error if provided a first argument which is not an
 		null,
 		void 0,
 		{},
+		[],
 		[ 'beep', 'boop' ],
 		[ 1, 2, 3 ],
 		[ null ]
 	];
 
 	for ( i = 0; i < values.length; i++ ) {
-		t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] );
+		if ( i === 8 ) {
+			t.throws( badValue( values[ i ] ), RangeError, 'throws an error when provided ' + values[ i ] );
+		} else {
+			t.throws( badValue( values[ i ] ), TypeError, 'throws an error when provided ' + values[ i ] );
+		}
 	}
 	t.end();
 
@@ -152,6 +157,21 @@ tape( 'the function concatenates ndarrays along a specified dimension', function
 	t.deepEqual( getShape( out ), [ 2, 5 ], 'returns expected value' );
 	t.deepEqual( actual, expected, 'returns expected value' );
 
+	xbuf = new Float64Array( [ 1.0, 2.0, 3.0, 4.0 ] );
+	x = new ndarray( 'float64', xbuf, [ 2, 2 ], [ 2, 1 ], 0, 'row-major' );
+
+	out = concat( [ x ], -1 );
+
+	actual = ndarray2array( out );
+	expected = [
+		[ 1.0, 2.0 ],
+		[ 3.0, 4.0 ]
+	];
+
+	t.strictEqual( getDtype( out ), 'float64', 'returns expected value' );
+	t.deepEqual( getShape( out ), [ 2, 2 ], 'returns expected value' );
+	t.deepEqual( actual, expected, 'returns expected value' );
+
 	t.end();
 });