Skip to content

Commit 21149c5

Browse files
chore: minor clean up
1 parent 591b3dc commit 21149c5

File tree

9 files changed

+65
-27
lines changed

9 files changed

+65
-27
lines changed

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/README.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,15 +196,20 @@ double stdlib_base_dists_bernoulli_cdf( const double x, const double p );
196196
#include <stdlib.h>
197197
#include <stdio.h>
198198
199+
static double random_uniform( const double min, const double max ) {
200+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
201+
return min + ( v*(max-min) );
202+
}
203+
199204
int main( void ) {
200205
double p;
201206
double x;
202207
double y;
203208
int i;
204209
205-
for ( i = 0; i < 25; i++ ) {
206-
x = ( (double)rand() / (double)RAND_MAX ) * 5.0;
207-
p = ( (double)rand() / (double)RAND_MAX ) ;
210+
for ( i = 0; i < 10; i++ ) {
211+
x = random_uniform( 0.0, 5.0 );
212+
p = random_uniform( 0.0, 1.0 );
208213
y = stdlib_base_dists_bernoulli_cdf( x, p );
209214
printf( "x: %lf , p: %1f, F(X;p): %lf\n", x, p , y );
210215
}

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/benchmark/benchmark.js

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222

2323
var bench = require( '@stdlib/bench' );
2424
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
26+
var Float64Array = require( '@stdlib/array/float64' );
2527
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2628
var pkg = require( './../package.json' ).name;
2729
var cdf = require( './../lib' );
@@ -30,16 +32,25 @@ var cdf = require( './../lib' );
3032
// MAIN //
3133

3234
bench( pkg, function benchmark( b ) {
35+
var len;
3336
var p;
3437
var x;
3538
var y;
3639
var i;
3740

41+
len = 100;
42+
x = new Float64Array( len );
43+
for ( i = 0; i < len; i++ ) {
44+
x[ i ] = uniform( 2.0, 3.0 );
45+
}
46+
p = new Float64Array( len );
47+
for ( i = 0; i < len; i++ ) {
48+
p[ i ] = uniform( 0.0, 1.0 );
49+
}
50+
3851
b.tic();
3952
for ( i = 0; i < b.iterations; i++ ) {
40-
x = ( randu()*3.0 ) - 1.0;
41-
p = randu();
42-
y = cdf( x, p );
53+
y = cdf( x[ i%100 ], p[ i%100 ] );
4354
if ( isnan( y ) ) {
4455
b.fail( 'should not return NaN' );
4556
}

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/benchmark/benchmark.native.js

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/base/uniform' );
26+
var Float64Array = require( '@stdlib/array/float64' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var tryRequire = require( '@stdlib/utils/try-require' );
2829
var pkg = require( './../package.json' ).name;
@@ -39,16 +40,25 @@ var opts = {
3940
// MAIN //
4041

4142
bench( pkg+'::native', opts, function benchmark( b ) {
43+
var len;
4244
var p;
4345
var x;
4446
var y;
4547
var i;
4648

49+
len = 100;
50+
x = new Float64Array( len );
51+
for ( i = 0; i < len; i++ ) {
52+
x[ i ] = uniform( 2.0, 3.0 );
53+
}
54+
p = new Float64Array( len );
55+
for ( i = 0; i < len; i++ ) {
56+
p[ i ] = uniform( 0.0, 1.0 );
57+
}
58+
4759
b.tic();
4860
for ( i = 0; i < b.iterations; i++ ) {
49-
x = ( randu()*3.0 ) - 1.0;
50-
p = randu();
51-
y = cdf( x, p );
61+
y = cdf( x[ i%100 ], p[ i%100 ] );
5262
if ( isnan( y ) ) {
5363
b.fail( 'should not return NaN' );
5464
}

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/benchmark/c/benchmark.c

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,15 @@ static double tic( void ) {
7575
}
7676

7777
/**
78-
* Generates a random number on the interval [0,1).
78+
* Generates a random number on the interval [min,max).
7979
*
80-
* @return random number
80+
* @param min minimum value (inclusive)
81+
* @param max maximum value (exclusive)
82+
* @return random number
8183
*/
82-
static double rand_double( void ) {
83-
int r = rand();
84-
return (double)r / ( (double)RAND_MAX + 1.0 );
84+
static double random_uniform( const double min, const double max ) {
85+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
86+
return min + ( v * ( max - min ) );
8587
}
8688

8789
/**
@@ -91,17 +93,22 @@ static double rand_double( void ) {
9193
*/
9294
static double benchmark( void ) {
9395
double elapsed;
94-
double p;
95-
double x;
96+
double p[ 100 ];
97+
double x[ 100 ];
9698
double y;
9799
double t;
98100
int i;
99101

102+
for ( i = 0; i < 100; i++ ) {
103+
p[ i ] = random_uniform( 0.1, 10.0 );
104+
}
105+
for ( i = 0; i < 100; i++ ) {
106+
x[ i ] = random_uniform( 2.0, 3.0 );
107+
}
108+
100109
t = tic();
101110
for ( i = 0; i < ITERATIONS; i++ ) {
102-
x = ( (double)rand() / (double)RAND_MAX )*3.0 - 1.0;
103-
p = ( (double)rand() / (double)RAND_MAX ) ;
104-
y = stdlib_base_dists_bernoulli_cdf( x, p );
111+
y = stdlib_base_dists_bernoulli_cdf( x[ i%100 ], p[ i%100 ] );
105112
if ( y != y ) {
106113
printf( "should not return NaN\n" );
107114
break;

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/docs/repl.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

22
{{alias}}( x, p )
33
Evaluates the cumulative distribution function (CDF) for a Bernoulli
4-
distribution with success probability `p` at a value `x`.
4+
distribution with success probability `p`.
55

66
If provided `NaN` as any argument, the function returns `NaN`.
77

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/examples/c/example.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,20 @@
2020
#include <stdlib.h>
2121
#include <stdio.h>
2222

23+
static double random_uniform( const double min, const double max ) {
24+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
25+
return min + ( v*(max-min) );
26+
}
27+
2328
int main( void ) {
2429
double p;
2530
double x;
2631
double y;
2732
int i;
2833

29-
for ( i = 0; i < 25; i++ ) {
30-
x = ( (double)rand() / (double)RAND_MAX ) * 5.0;
31-
p = ( (double)rand() / (double)RAND_MAX ) ;
34+
for ( i = 0; i < 10; i++ ) {
35+
x = random_uniform( 0.0, 5.0 );
36+
p = random_uniform( 0.0, 1.0 );
3237
y = stdlib_base_dists_bernoulli_cdf( x, p );
3338
printf( "x: %lf , p: %1f, F(X;p): %lf\n", x, p , y );
3439
}

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/lib/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
// MAIN //
2727

2828
/**
29-
* Evaluates the cumulative distribution function (CDF) for a Bernoulli distribution with success probability `p` at a value `x`.
29+
* Evaluates the cumulative distribution function (CDF) for a Bernoulli distribution with success probability `p`.
3030
*
3131
* @param {number} x - input value
3232
* @param {Probability} p - success probability

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/lib/native.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var addon = require( './../src/addon.node' );
2626
// MAIN //
2727

2828
/**
29-
* Evaluates the cumulative distribution function (CDF) for a Bernoulli distribution with success probability `p` at a value `x`.
29+
* Evaluates the cumulative distribution function (CDF) for a Bernoulli distribution with success probability `p`.
3030
*
3131
* @param {number} x - input value
3232
* @param {Probability} p - success probability

lib/node_modules/@stdlib/stats/base/dists/bernoulli/cdf/src/main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "stdlib/math/base/assert/is_nan.h"
2121

2222
/**
23-
* Evaluates the cumulative distribution function (CDF) for a Bernoulli distribution with success probability `p` at a value `x`.
23+
* Evaluates the cumulative distribution function (CDF) for a Bernoulli distribution with success probability `p`.
2424
*
2525
* @param x input value
2626
* @param p success probability

0 commit comments

Comments
 (0)