fix: apply review suggestions

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/ndarray/base/some-by/README.md

@@ -44,7 +44,7 @@ Tests whether at least `n` elements in an ndarray pass a test implemented by a p
 
 ```javascript
 var Float64Array = require( '@stdlib/array/float64' );
-var scalar2ndarray = require( '@stdlib/ndarray/base/from-scalar' );
+var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
 
 function predicate( value ) {
     return value > 0.0;
@@ -72,15 +72,17 @@ var x = {
     'order': 'row-major'
 };
 
-var n = scalar2ndarray( 3.0, 'generic', 'row-major' );
+var n = scalar2ndarray( 3, {
+    'dtype': 'generic'
+});
 
 var out = someBy( [ x, n ], predicate );
 // returns true
 ```
 
 The function accepts the following arguments:
 
--   **arrays**: array-like object containing an input ndarray and a zero-dimensional ndarray.
+-   **arrays**: array-like object containing an input ndarray and a zero-dimensional ndarray specifying the minimum number of elements in the input ndarray that must satisfy the predicate function.
 -   **predicate**: predicate function.
 -   **thisArg**: predicate function execution context (_optional_).
 
@@ -105,7 +107,7 @@ To set the predicate function execution context, provide a `thisArg`.
 
 ```javascript
 var Float64Array = require( '@stdlib/array/float64' );
-var scalar2ndarray = require( '@stdlib/ndarray/base/from-scalar' );
+var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
 
 function predicate( value ) {
     this.count += 1;
@@ -134,7 +136,9 @@ var x = {
     'order': 'row-major'
 };
 
-var n = scalar2ndarray( 6.0, 'generic', 'row-major' );
+var n = scalar2ndarray( 6, {
+    'dtype': 'generic'
+});
 
 var ctx = {
     'count': 0
@@ -189,7 +193,7 @@ var x = {
 };
 console.log( ndarray2array( x.data, x.shape, x.strides, x.offset, x.order ) );
 
-var n = scalar2ndarray( 5.0, {
+var n = scalar2ndarray( 5, {
     'dtype': 'generic'
 });
 

lib/node_modules/@stdlib/ndarray/base/some-by/benchmark/benchmark.1d_rowmajor.js

@@ -70,7 +70,7 @@ function createBenchmark( len, shape, xtype ) {
 		'offset': 0,
 		'order': order
 	};
-	n = scalar2ndarray( 5.0, {
+	n = scalar2ndarray( 5, {
 		'dtype': 'generic',
 		'order': order
 	});

lib/node_modules/@stdlib/ndarray/base/some-by/docs/repl.txt

@@ -22,8 +22,9 @@
     Parameters
     ----------
     arrays: ArrayLikeObject<ndarray>
-        Array-like object containing an input ndarray and a 0-dimensional
-        ndarray containing number of elements.
+        Array-like object containing an input ndarray and a zero-dimensional
+        ndarray specifying the minimum number of elements in the input ndarray
+        that must satisfy the predicate function.
 
     predicate: Function
         Predicate function.
@@ -52,7 +53,7 @@
 
     // Using an ndarray...
     > var x = {{alias:@stdlib/ndarray/ctor}}( dt, xbuf, sh, sx, ox, ord );
-    > var n = {{alias:@stdlib/ndarray/from-scalar}}( 3, { 'dtype': 'generic' });
+    > var n = {{alias:@stdlib/ndarray/from-scalar}}( 3 );
     > {{alias}}( [ x, n ], clbk )
     true
 

lib/node_modules/@stdlib/ndarray/base/some-by/docs/types/index.d.ts

@@ -20,7 +20,6 @@
 
 /// <reference types="@stdlib/types"/>
 
-import { ArrayLike } from '@stdlib/types/array';
 import { typedndarray } from '@stdlib/types/ndarray';
 
 /**
@@ -70,10 +69,10 @@ type Predicate<T, U> = Nullary<U> | Unary<T, U> | Binary<T, U> | Ternary<T, U>;
 /**
 * Tests whether at least `n` elements in an ndarray pass a test implemented by a predicate function.
 *
-* @param arrays - array-like object containing an input ndarray and a 0-dimensional ndarray containing the number of elements
+* @param arrays - array-like object containing an input ndarray and a zero-dimensional ndarray specifying the minimum number of elements in the input ndarray that must satisfy the predicate function
 * @param predicate - predicate function
 * @param thisArg - predicate function execution context
-* @returns boolean indicating whether all elements pass a test
+* @returns boolean indicating whether `n` elements pass a test
 *
 * @example
 * var scalar2ndarray = require( '@stdlib/ndarray/from-scalar' );
@@ -97,13 +96,13 @@ type Predicate<T, U> = Nullary<U> | Unary<T, U> | Binary<T, U> | Ternary<T, U>;
 *
 * // Create the input ndarray:
 * var x = ndarray( 'float64', xbuf, shape, sx, ox, 'row-major' );
-* var n = scalar2ndarray( 3.0, { 'dtype': 'generic' } );
+* var n = scalar2ndarray( 3, { 'dtype': 'generic' } );
 *
 * // Test elements:
 * var out = someBy( [ x, n ], predicate );
 * // returns true
 */
-declare function someBy<T = unknown, U = unknown>( arrays: ArrayLike<typedndarray<T>>, predicate: Predicate<T, U>, thisArg?: ThisParameterType<Predicate<T, U>> ): boolean;
+declare function someBy<T = unknown, U = unknown>( arrays: [ typedndarray<T>, typedndarray<number>], predicate: Predicate<T, U>, thisArg?: ThisParameterType<Predicate<T, U>> ): boolean;
 
 
 // EXPORTS //

lib/node_modules/@stdlib/ndarray/base/some-by/examples/index.js

@@ -39,7 +39,7 @@ var x = {
 };
 console.log( ndarray2array( x.data, x.shape, x.strides, x.offset, x.order ) );
 
-var n = scalar2ndarray( 5.0, {
+var n = scalar2ndarray( 5, {
 	'dtype': 'generic'
 });
 

lib/node_modules/@stdlib/ndarray/base/some-by/lib/0d.js

@@ -35,7 +35,7 @@
 * @param {PositiveInteger} n - number of elements
 * @param {Function} predicate - predicate function
 * @param {*} thisArg - predicate function execution context
-* @returns {boolean} boolean indicating whether all elements pass a test
+* @returns {boolean} boolean indicating whether at least `n` elements pass a test
 *
 * @example
 * var Float64Array = require( '@stdlib/array/float64' );
@@ -72,6 +72,9 @@
 * // returns true
 */
 function some0d( x, n, predicate, thisArg ) {
+	if ( n > 1 ) {
+		return false;
+	}
 	if ( predicate.call( thisArg, x.data[ x.offset ], [], x.ref ) ) {
 		return true;
 	}

lib/node_modules/@stdlib/ndarray/base/some-by/lib/0d_accessors.js

@@ -36,7 +36,7 @@
 * @param {PositiveInteger} n - number of elements
 * @param {Function} predicate - predicate function
 * @param {*} thisArg - predicate function execution context
-* @returns {boolean} boolean indicating whether all elements pass a test
+* @returns {boolean} boolean indicating whether at least `n` elements pass a test
 *
 * @example
 * var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
@@ -75,6 +75,9 @@
 * // returns true
 */
 function every0d( x, n, predicate, thisArg ) {
+	if ( n > 1 ) {
+		return false;
+	}
 	if ( predicate.call( thisArg, x.accessors[ 0 ]( x.data, x.offset ), [], x.ref ) ) { // eslint-disable-line max-len
 		return true;
 	}

lib/node_modules/@stdlib/ndarray/base/some-by/lib/1d.js

@@ -35,7 +35,7 @@
 * @param {PositiveInteger} n - number of elements
 * @param {Function} predicate - predicate function
 * @param {*} thisArg - predicate function execution context
-* @returns {boolean} boolean indicating whether all elements pass a test
+* @returns {boolean} boolean indicating whether at least `n` elements pass a test
 *
 * @example
 * var Float64Array = require( '@stdlib/array/float64' );

lib/node_modules/@stdlib/ndarray/base/some-by/lib/1d_accessors.js

@@ -36,7 +36,7 @@
 * @param {PositiveInteger} n - number of elements
 * @param {Function} predicate - predicate function
 * @param {*} thisArg - predicate function execution context
-* @returns {boolean} boolean indicating whether all elements pass a test
+* @returns {boolean} boolean indicating whether at least `n` elements pass a test
 *
 * @example
 * var toAccessorArray = require( '@stdlib/array/base/to-accessor-array' );
@@ -103,7 +103,7 @@ function some1d( x, n, predicate, thisArg ) {
 
 	// Iterate over the ndarray dimensions...
 	for ( i0 = 0; i0 < S0; i0++ ) {
-		if ( predicate.call( thisArg, get( xbuf, ix ), [ i0 ], x.ref) ) {
+		if ( predicate.call( thisArg, get( xbuf, ix ), [ i0 ], x.ref ) ) {
 			count += 1;
 			if ( count === n ) {
 				return true;

lib/node_modules/@stdlib/ndarray/base/some-by/lib/2d.js

@@ -43,7 +43,7 @@ var take = require( '@stdlib/array/base/take-indexed' );
 * @param {PositiveInteger} n - number of elements
 * @param {Function} predicate - predicate function
 * @param {*} thisArg - predicate function execution context
-* @returns {boolean} boolean indicating whether all elements pass a test
+* @returns {boolean} boolean indicating whether at least `n` elements pass a test
 *
 * @example
 * var Float64Array = require( '@stdlib/array/float64' );