refactor: remove redundant exponent check and replace magic number with constant

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: anandkaranubc

lib/node_modules/@stdlib/math/base/special/modff/lib/assign.js

@@ -26,6 +26,7 @@ var fromWord = require( '@stdlib/number/float32/base/from-word' );
 var f32 = require( '@stdlib/number/float64/base/to-float32' );
 var PINF = require( '@stdlib/constants/float32/pinf' );
 var FLOAT32_EXPONENT_BIAS = require( '@stdlib/constants/float32/exponent-bias' );
+var FLOAT32_NUM_SIGNIFICAND_BITS = require( '@stdlib/constants/float32/num-significand-bits' ); // eslint-disable-line id-length
 var FLOAT32_HIGH_WORD_EXPONENT_MASK = require( '@stdlib/constants/float32/exponent-mask' ); // eslint-disable-line id-length
 var FLOAT32_HIGH_WORD_SIGNIFICAND_MASK = require( '@stdlib/constants/float32/significand-mask' ); // eslint-disable-line id-length
 
@@ -92,11 +93,11 @@ function modff( x, out, stride, offset ) {
 	word = toWord( x );
 
 	// Extract the unbiased exponent:
-	exp = ((word & FLOAT32_HIGH_WORD_EXPONENT_MASK) >> 23)|0; // asm type annotation
+	exp = ((word & FLOAT32_HIGH_WORD_EXPONENT_MASK) >> FLOAT32_NUM_SIGNIFICAND_BITS)|0; // asm type annotation
 	exp -= FLOAT32_EXPONENT_BIAS|0; // asm type annotation
 
 	// Handle smaller values (x < 2**23 = 8388608)...
-	if ( exp < 23 ) {
+	if ( exp < FLOAT32_NUM_SIGNIFICAND_BITS ) {
 		i = (FLOAT32_HIGH_WORD_SIGNIFICAND_MASK >> exp)|0; // asm type annotation
 
 		// Determine if `x` is integral by checking for significand bits which cannot be exponentiated away...
@@ -116,13 +117,10 @@ function modff( x, out, stride, offset ) {
 		out[ offset + stride ] = f32( x - i );
 		return out;
 	}
-	// Check if `x` can even have a fractional part...
-	if ( exp >= 23 ) {
-		// `x` is integral:
-		out[ offset ] = x;
-		out[ offset + stride ] = ZERO;
-		return out;
-	}
+	// `x` is integral:
+	out[ offset ] = x;
+	out[ offset + stride ] = ZERO;
+	return out;
 }
 
 

lib/node_modules/@stdlib/math/base/special/modff/manifest.json

@@ -46,7 +46,8 @@
         "@stdlib/constants/float32/pinf",
         "@stdlib/constants/float32/exponent-bias",
         "@stdlib/constants/float32/exponent-mask",
-        "@stdlib/constants/float32/significand-mask"
+        "@stdlib/constants/float32/significand-mask",
+        "@stdlib/constants/float32/num-significand-bits"
       ]
     },
     {
@@ -66,7 +67,8 @@
         "@stdlib/constants/float32/pinf",
         "@stdlib/constants/float32/exponent-bias",
         "@stdlib/constants/float32/exponent-mask",
-        "@stdlib/constants/float32/significand-mask"
+        "@stdlib/constants/float32/significand-mask",
+        "@stdlib/constants/float32/num-significand-bits"
       ]
     },
     {
@@ -86,7 +88,8 @@
         "@stdlib/constants/float32/pinf",
         "@stdlib/constants/float32/exponent-bias",
         "@stdlib/constants/float32/exponent-mask",
-        "@stdlib/constants/float32/significand-mask"
+        "@stdlib/constants/float32/significand-mask",
+        "@stdlib/constants/float32/num-significand-bits"
       ]
     }
   ]

lib/node_modules/@stdlib/math/base/special/modff/src/main.c

@@ -24,9 +24,10 @@
 #include "stdlib/constants/float32/exponent_bias.h"
 #include "stdlib/constants/float32/exponent_mask.h"
 #include "stdlib/constants/float32/significand_mask.h"
+#include "stdlib/constants/float32/num_significand_bits.h"
 
 /**
-* Decomposes a single-precision floating-point number into integral and fractional parts, each having the same type and sign as the input value, and assigns results to a provided output array.
+* Decomposes a single-precision floating-point number into integral and fractional parts, each having the same type and sign as the input value.
 *
 * @param x           input value
 * @param integral    destination pointer for the integral part
@@ -78,11 +79,11 @@ void stdlib_base_modff( const float x, float* integral, float* frac ) {
 	stdlib_base_float32_to_word( x, &word );
 
 	// Extract the unbiased exponent:
-	exp = ( ( word & STDLIB_CONSTANT_FLOAT32_EXPONENT_MASK ) >> 23 );
+	exp = ( ( word & STDLIB_CONSTANT_FLOAT32_EXPONENT_MASK ) >> STDLIB_CONSTANT_FLOAT32_NUM_SIGNIFICAND_BITS );
 	exp -= ( STDLIB_CONSTANT_FLOAT32_EXPONENT_BIAS );
 
 	// Handle smaller values (x < 2**23 = 8388608)...
-	if( exp < 23 ) {
+	if( exp < STDLIB_CONSTANT_FLOAT32_NUM_SIGNIFICAND_BITS ) {
 		i = ( STDLIB_CONSTANT_FLOAT32_SIGNIFICAND_MASK >> exp );
 
 		// Determine if `x` is integral by checking for significand bits which cannot be exponentiated away...
@@ -100,11 +101,8 @@ void stdlib_base_modff( const float x, float* integral, float* frac ) {
 		*frac = x - j;
 		return;
 	}
-	// Check if `x` can even have a fractional part...
-	else {
-		// `x` is integral:
-		*integral = x;
-		*frac = 0.0f;
-		return;
-	}
+	// `x` is integral:
+	*integral = x;
+	*frac = 0.0f;
+	return;
 }