Skip to content

Commit 2a46bc7

Browse files
committed
refactor: avoid unnecessary computation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent aec0e88 commit 2a46bc7

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

lib/node_modules/@stdlib/stats/base/dists/triangular/quantile/lib/factory.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ function factory( a, b, c ) {
5959
}
6060

6161
pInflection = ( c - a ) / ( b - a );
62-
fact1 = ( b - a ) * ( c - a);
62+
fact1 = ( b - a ) * ( c - a );
6363
fact2 = ( b - a ) * ( b - c );
6464
return quantile;
6565

lib/node_modules/@stdlib/stats/base/dists/triangular/quantile/lib/main.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,6 @@ var sqrt = require( '@stdlib/math/base/special/sqrt' );
8181
*/
8282
function quantile( p, a, b, c ) {
8383
var pInflection;
84-
var fact1;
85-
var fact2;
86-
8784
if (
8885
isnan( p ) ||
8986
isnan( a ) ||
@@ -97,13 +94,11 @@ function quantile( p, a, b, c ) {
9794
return NaN;
9895
}
9996
pInflection = ( c - a ) / ( b - a );
100-
fact1 = ( b - a ) * ( c - a);
101-
fact2 = ( b - a ) * ( b - c );
10297
if ( p < pInflection ) {
103-
return a + sqrt( fact1 * p );
98+
return a + sqrt( ( b - a ) * ( c - a ) * p );
10499
}
105100
if ( p > pInflection ) {
106-
return b - sqrt( fact2 * ( 1.0 - p ) );
101+
return b - sqrt( ( b - a ) * ( b - c ) * ( 1.0 - p ) );
107102
}
108103
// Case: p = pInflection
109104
return c;

0 commit comments

Comments
 (0)