Skip to content

Commit 2acdae4

Browse files
committed
chore: changes from code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 4a74634 commit 2acdae4

File tree

2 files changed

+21
-6
lines changed

2 files changed

+21
-6
lines changed

lib/node_modules/@stdlib/stats/base/dmax/manifest.json

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,25 @@
4343
"@stdlib/napi/export",
4444
"@stdlib/napi/argv",
4545
"@stdlib/napi/argv-int64",
46-
"@stdlib/napi/argv-strided-float64array"
46+
"@stdlib/napi/argv-strided-float64array",
47+
"@stdlib/napi/create-double"
48+
]
49+
},
50+
{
51+
"task": "benchmark",
52+
"src": [
53+
"./src/dmax.c"
54+
],
55+
"include": [
56+
"./include"
57+
],
58+
"libraries": [
59+
"-lm"
60+
],
61+
"libpath": [],
62+
"dependencies": [
63+
"@stdlib/math/base/assert/is-positive-zero",
64+
"@stdlib/math/base/assert/is-nan"
4765
]
4866
},
4967
{

lib/node_modules/@stdlib/stats/base/dmax/src/addon.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include "stdlib/napi/argv.h"
2222
#include "stdlib/napi/argv_int64.h"
2323
#include "stdlib/napi/argv_strided_float64array.h"
24+
#include "stdlib/napi/create_double.h"
2425
#include <node_api.h>
2526

2627
/**
@@ -35,11 +36,7 @@ static napi_value addon( napi_env env, napi_callback_info info ) {
3536
STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );
3637
STDLIB_NAPI_ARGV_INT64( env, stride, argv, 2 );
3738
STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, stride, argv, 1 );
38-
39-
napi_value v;
40-
napi_status status = napi_create_double( env, stdlib_strided_dmax( N, X, stride ), &v );
41-
assert( status == napi_ok );
42-
39+
STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_strided_dmax( N, X, stride ), v );
4340
return v;
4441
}
4542

0 commit comments

Comments
 (0)