Skip to content

Commit 2ee7f60

Browse files
0PrashantYadav00PrashantYadav0
committed
fix: remove eps and changes intendation
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent c371f29 commit 2ee7f60

File tree

8 files changed

+103
-130
lines changed

8 files changed

+103
-130
lines changed

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/README.md‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ for ( i = 0; i < 10; i++ ) {
165165

166166
#### stdlib_base_dists_geometric_pmf( x, p )
167167

168-
Evaluates evaluating the [probability mass function][pmf] (PMF) of a [geometric][geometric-distribution] distribution with success probability `0 <= p <= 1`.
168+
Evaluates the [probability mass function][pmf] (PMF) of a [geometric][geometric-distribution] distribution with success probability `0 <= p <= 1`.
169169

170170
```c
171171
double out = stdlib_base_dists_geometric_pmf( 4.0, 0.3 );
@@ -202,7 +202,6 @@ double stdlib_base_dists_geometric_pmf( const double x, const double p );
202202
```c
203203
#include "stdlib/stats/base/dists/geometric/pmf.h"
204204
#include "stdlib/math/base/special/round.h"
205-
#include "stdlib/constants/float64/eps.h"
206205
#include <stdlib.h>
207206
#include <stdio.h>
208207
#include <math.h>
@@ -220,7 +219,7 @@ int main( void ) {
220219
221220
for ( i = 0; i < 25; i++ ) {
222221
x = stdlib_base_round( random_uniform( 0, 40 ) );
223-
p = random_uniform( 0.0, 1.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;
222+
p = random_uniform( 0.0, 1.0 );
224223
y = stdlib_base_dists_geometric_pmf( x, p );
225224
printf( "x: %lf, p: %lf, P(X=x;p): %lf\n", x, p, y );
226225
}

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/benchmark/benchmark.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ var Float64Array = require( '@stdlib/array/float64' );
2525
var randu = require( '@stdlib/random/base/randu' );
2626
var round = require( '@stdlib/math/base/special/round' );
2727
var isnan = require( '@stdlib/math/base/assert/is-nan' );
28-
var EPS = require( '@stdlib/constants/float64/eps' );
2928
var pkg = require( './../package.json' ).name;
3029
var pmf = require( './../lib' );
3130

@@ -44,7 +43,7 @@ bench( pkg, function benchmark( b ) {
4443
p = new Float64Array( len );
4544
for ( i = 0; i < len; i++ ) {
4645
x[ i ] = round( randu()*40.0 );
47-
p[ i ] = ( randu()*1.0 ) + EPS;
46+
p[ i ] = ( randu()*1.0 );
4847
}
4948

5049
b.tic();

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/benchmark/benchmark.native.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ var Float64Array = require( '@stdlib/array/float64' );
2626
var randu = require( '@stdlib/random/base/randu' );
2727
var round = require( '@stdlib/math/base/special/round' );
2828
var isnan = require( '@stdlib/math/base/assert/is-nan' );
29-
var EPS = require( '@stdlib/constants/float64/eps' );
3029
var tryRequire = require( '@stdlib/utils/try-require' );
3130
var pkg = require( './../package.json' ).name;
3231

@@ -53,7 +52,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
5352
p = new Float64Array( len );
5453
for ( i = 0; i < len; i++ ) {
5554
x[ i ] = round( randu()*40.0 );
56-
p[ i ] = ( randu()*1.0 ) + EPS;
55+
p[ i ] = ( randu()*1.0 );
5756
}
5857

5958
b.tic();

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/benchmark/c/benchmark.c‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
#include "stdlib/stats/base/dists/geometric/pmf.h"
2020
#include "stdlib/math/base/special/round.h"
21-
#include "stdlib/constants/float64/eps.h"
2221
#include <stdlib.h>
2322
#include <stdio.h>
2423
#include <math.h>
@@ -103,7 +102,7 @@ static double benchmark( void ) {
103102

104103
for ( i = 0; i < 100; i++ ) {
105104
x[ i ] = stdlib_base_round( random_uniform( 0.0, 40.0 ) );
106-
p[ i ] = random_uniform( 0.0, 1.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;
105+
p[ i ] = random_uniform( 0.0, 1.0 );
107106
}
108107

109108
t = tic();

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/examples/c/example.c‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
#include "stdlib/stats/base/dists/geometric/pmf.h"
2020
#include "stdlib/math/base/special/round.h"
21-
#include "stdlib/constants/float64/eps.h"
2221
#include <stdlib.h>
2322
#include <stdio.h>
2423
#include <math.h>
@@ -36,7 +35,7 @@ int main( void ) {
3635

3736
for ( i = 0; i < 25; i++ ) {
3837
x = stdlib_base_round( random_uniform( 0, 40 ) );
39-
p = random_uniform( 0.0, 1.0 ) + STDLIB_CONSTANT_FLOAT64_EPS;
38+
p = random_uniform( 0.0, 1.0 );
4039
y = stdlib_base_dists_geometric_pmf( x, p );
4140
printf( "x: %lf, p: %lf, P(X=x;p): %lf\n", x, p, y );
4241
}

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/include/stdlib/stats/base/dists/geometric/pmf.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extern "C" {
2727
#endif
2828

2929
/**
30-
* Evaluates the probability mass function (PMF) for the geometric distribution with probability parameter p.
30+
* Evaluates the probability mass function (PMF) for a geometric distribution with success probability `p` at a value `x`.
3131
*/
3232
double stdlib_base_dists_geometric_pmf( const double x, const double p );
3333

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/manifest.json‎

Lines changed: 82 additions & 82 deletions
Original file line numberDiff line numberDiff line change
@@ -1,86 +1,86 @@
11
{
2-
"options": {
2+
"options": {
3+
"task": "build",
4+
"wasm": false
5+
},
6+
"fields": [
7+
{
8+
"field": "src",
9+
"resolve": true,
10+
"relative": true
11+
},
12+
{
13+
"field": "include",
14+
"resolve": true,
15+
"relative": true
16+
},
17+
{
18+
"field": "libraries",
19+
"resolve": false,
20+
"relative": false
21+
},
22+
{
23+
"field": "libpath",
24+
"resolve": true,
25+
"relative": false
26+
}
27+
],
28+
"confs": [
29+
{
330
"task": "build",
4-
"wasm": false
31+
"wasm": false,
32+
"src": [
33+
"./src/main.c"
34+
],
35+
"include": [
36+
"./include"
37+
],
38+
"libraries": [],
39+
"libpath": [],
40+
"dependencies": [
41+
"@stdlib/math/base/napi/binary",
42+
"@stdlib/math/base/assert/is-nonnegative-integer",
43+
"@stdlib/math/base/assert/is-nan",
44+
"@stdlib/math/base/special/pow"
45+
]
46+
},
47+
{
48+
"task": "benchmark",
49+
"wasm": false,
50+
"src": [
51+
"./src/main.c"
52+
],
53+
"include": [
54+
"./include"
55+
],
56+
"libraries": [],
57+
"libpath": [],
58+
"dependencies": [
59+
"@stdlib/math/base/assert/is-nonnegative-integer",
60+
"@stdlib/math/base/assert/is-nan",
61+
"@stdlib/math/base/special/pow",
62+
"@stdlib/math/base/special/round",
63+
"@stdlib/constants/float64/eps"
64+
]
565
},
6-
"fields": [
7-
{
8-
"field": "src",
9-
"resolve": true,
10-
"relative": true
11-
},
12-
{
13-
"field": "include",
14-
"resolve": true,
15-
"relative": true
16-
},
17-
{
18-
"field": "libraries",
19-
"resolve": false,
20-
"relative": false
21-
},
22-
{
23-
"field": "libpath",
24-
"resolve": true,
25-
"relative": false
26-
}
27-
],
28-
"confs": [
29-
{
30-
"task": "build",
31-
"wasm": false,
32-
"src": [
33-
"./src/main.c"
34-
],
35-
"include": [
36-
"./include"
37-
],
38-
"libraries": [],
39-
"libpath": [],
40-
"dependencies": [
41-
"@stdlib/math/base/napi/binary",
42-
"@stdlib/math/base/assert/is-nonnegative-integer",
43-
"@stdlib/math/base/assert/is-nan",
44-
"@stdlib/math/base/special/pow"
45-
]
46-
},
47-
{
48-
"task": "benchmark",
49-
"wasm": false,
50-
"src": [
51-
"./src/main.c"
52-
],
53-
"include": [
54-
"./include"
55-
],
56-
"libraries": [],
57-
"libpath": [],
58-
"dependencies": [
59-
"@stdlib/math/base/assert/is-nonnegative-integer",
60-
"@stdlib/math/base/assert/is-nan",
61-
"@stdlib/math/base/special/pow",
62-
"@stdlib/math/base/special/round",
63-
"@stdlib/constants/float64/eps"
64-
]
65-
},
66-
{
67-
"task": "examples",
68-
"wasm": false,
69-
"src": [
70-
"./src/main.c"
71-
],
72-
"include": [
73-
"./include"
74-
],
75-
"libraries": [],
76-
"libpath": [],
77-
"dependencies": [
78-
"@stdlib/math/base/assert/is-nonnegative-integer",
79-
"@stdlib/math/base/assert/is-nan",
80-
"@stdlib/math/base/special/pow",
81-
"@stdlib/math/base/special/round",
82-
"@stdlib/constants/float64/eps"
83-
]
84-
}
85-
]
66+
{
67+
"task": "examples",
68+
"wasm": false,
69+
"src": [
70+
"./src/main.c"
71+
],
72+
"include": [
73+
"./include"
74+
],
75+
"libraries": [],
76+
"libpath": [],
77+
"dependencies": [
78+
"@stdlib/math/base/assert/is-nonnegative-integer",
79+
"@stdlib/math/base/assert/is-nan",
80+
"@stdlib/math/base/special/pow",
81+
"@stdlib/math/base/special/round",
82+
"@stdlib/constants/float64/eps"
83+
]
84+
}
85+
]
8686
}

‎lib/node_modules/@stdlib/stats/base/dists/geometric/pmf/src/main.c‎

Lines changed: 14 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -20,51 +20,29 @@
2020
#include "stdlib/math/base/assert/is_nonnegative_integer.h"
2121
#include "stdlib/math/base/assert/is_nan.h"
2222
#include "stdlib/math/base/special/pow.h"
23-
#include <math.h>
2423

2524
/**
26-
* Evaluates the probability mass function (PMF) for a geometric distribution with success probability `p` at a value `x`.
25+
* Returns the probability mass function of a geometric distribution.
2726
*
28-
* @param {number} x - input value
29-
* @param {Probability} p - success probability
30-
* @returns {Probability} evaluated PMF
27+
* @param x input value
28+
* @param p success probability
29+
* @return evaluated PMF
3130
*
3231
* @example
33-
* var y = pmf( 4.0, 0.3 );
32+
* double y = stdlib_base_dists_geometric_pmf( 4.0, 0.3 );
3433
* // returns ~0.072
35-
*
36-
* @example
37-
* var y = pmf( 2.0, 0.7 );
38-
* // returns ~0.063
39-
*
40-
* @example
41-
* var y = pmf( -1.0, 0.5 );
42-
* // returns 0.0
43-
*
44-
* @example
45-
* var y = pmf( 0.0, NaN );
46-
* // returns NaN
47-
*
48-
* @example
49-
* var y = pmf( NaN, 0.5 );
50-
* // returns NaN
51-
*
52-
* @example
53-
* // Invalid success probability:
54-
* var y = pmf( 2.0, 1.5 );
55-
* // returns NaN
5634
*/
5735
double stdlib_base_dists_geometric_pmf( const double x, const double p ) {
58-
if (
59-
stdlib_base_is_nan( x ) ||
60-
stdlib_base_is_nan( p ) ||
61-
p < 0.0 ||
62-
p > 1.0
63-
) {
64-
return 0.0/0.0; // NaN
65-
}
36+
if (
37+
stdlib_base_is_nan( x ) ||
38+
stdlib_base_is_nan( p ) ||
39+
p < 0.0 ||
40+
p > 1.0
41+
) {
42+
return 0.0/0.0; // NaN
43+
}
6644
if( stdlib_base_is_nonnegative_integer( x ) ){
6745
return p * stdlib_base_pow( ( 1.0 - p ), x );
6846
}
69-
return 0.0;
47+
return 0.0;
7048
}

0 commit comments

Comments
 (0)