refactor: apply suggestions from code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/ndarray/concat/lib/main.js

@@ -25,6 +25,7 @@ var normalizeIndex = require( '@stdlib/ndarray/base/normalize-index' );
 var isndarrayLike = require( '@stdlib/assert/is-ndarray-like' );
 var indicesComplement = require( '@stdlib/array/base/indices-complement' );
 var nditerStacks = require( '@stdlib/ndarray/iter/stacks' );
+var isNonNegativeInteger = require( '@stdlib/assert/is-nonnegative-integer' );
 var getShape = require( '@stdlib/ndarray/shape' );
 var getStrides = require( '@stdlib/ndarray/strides' );
 var getDtype = require( '@stdlib/ndarray/dtype' );
@@ -40,9 +41,10 @@ var output = require( './output.js' );
 * Concatenates a list of ndarrays along a specified ndarray dimension.
 *
 * @param {ArrayLikeObject<Object>} arrays - array-like object containing input ndarrays
-* @param {integer} dim - dimension along which the arrays are concatenated
+* @param {NegativeInteger} dim - dimension along which the arrays are concatenated
 * @throws {TypeError} first argument must be an array of ndarray-like objects
-* @throws {RangeError} first argument must have more than one ndarray
+* @throws {RangeError} first argument must have one or more ndarrays
+* @throws {TypeError} second argument must be a negative integer
 * @returns {ndarray} output ndarray
 *
 * @example
@@ -56,11 +58,11 @@ var output = require( './output.js' );
 * var ybuf = new Float64Array( [ -5.0, 6.0, -7.0, 8.0, -9.0, 10.0 ] );
 * var y = new ndarray( 'float64', ybuf, [ 2, 3 ], [ 3, 1 ], 0, 'row-major' );
 *
-* var out = concat( [ x, y ] );
+* var out = concat( [ x, y ], -1 );
 * // returns <ndarray>
 *
 * var arr = ndarray2array( out );
-* // returns [ [ -1.0, 2.0, -5.0, 6.0, 7.0 ], [ -3.0, 4.0, 8.0, 9.0, 10.0 ] ]
+* // returns [ [ -1.0, 2.0, -5.0, 6.0, -7.0 ], [ -3.0, 4.0, 8.0, -9.0, 10.0 ] ]
 */
 function concat( arrays, dim ) {
 	var istacks;
@@ -69,6 +71,7 @@ function concat( arrays, dim ) {
 	var shapes;
 	var dtypes;
 	var orders;
+	var nargs;
 	var arrs;
 	var out;
 	var mi;
@@ -77,10 +80,14 @@ function concat( arrays, dim ) {
 	var s;
 	var i;
 
+	nargs = arguments.length;
+	if ( nargs === 2 && isNonNegativeInteger( dim ) ) {
+		throw new TypeError( format( 'invalid argument. Second argument must be a negative integer. Value: `%s`.', dim ) );
+	}
 	N = arrays.length;
 	arrs = [];
 	if ( N < 1 ) {
-		throw new RangeError( format( 'invalid argument. First argument must have more than one ndarray. Value: `%s`.', N ) );
+		throw new RangeError( format( 'invalid argument. First argument must have one or more ndarrays. Value: `%s`.', N ) );
 	}
 	// Unpack the ndarrays and standardize ndarray meta data:
 	shapes = [];
@@ -89,7 +96,7 @@ function concat( arrays, dim ) {
 	orders = [];
 	for ( i = 0; i < N; i++ ) {
 		if ( !isndarrayLike( arrays[ i ] ) ) {
-			throw new TypeError( format( 'invalid argument. First argument must be an array of ndarray-like objects. Value: `%s`.', arrays[ i ] ) );
+			throw new TypeError( format( 'invalid argument. First argument must be an array of ndarrays. Value: `%s`.', arrays[ i ] ) );
 		}
 		arrs[ i ] = arrays[ i ];
 		shapes.push( getShape( arrs[ i ] ) );

lib/node_modules/@stdlib/ndarray/concat/lib/output.js

@@ -26,7 +26,6 @@ var empty = require( '@stdlib/ndarray/empty' );
 var slice = require( '@stdlib/array/slice' );
 var getShape = require( '@stdlib/ndarray/shape' );
 var getDtype = require( '@stdlib/ndarray/dtype' );
-var getOrder = require( '@stdlib/ndarray/order' );
 var format = require( '@stdlib/string/format' );
 
 
@@ -73,6 +72,7 @@ function resolveOutputOrder( orders ) {
 */
 function output( shapes, dtypes, orders, dim, out ) {
 	var ord;
+	var osh;
 	var sh;
 	var dt;
 	var s;
@@ -89,14 +89,12 @@ function output( shapes, dtypes, orders, dim, out ) {
 		if ( getDtype( out ) !== dt ) {
 			throw new TypeError( format( 'invalid argument. Output ndarray must have a dtype of `%s`. Value: `%s`.', dt, getDtype( out ) ) );
 		}
-		if ( getOrder( out ) !== ord ) {
-			throw new TypeError( format( 'invalid argument. Output ndarray must have an order of `%s`. Value: `%s`.', ord, getOrder( out ) ) );
-		}
-		if ( getShape( out ).length !== sh.length ) {
+		osh = getShape( out );
+		if ( osh.length !== sh.length ) {
 			throw new RangeError( format( 'invalid argument. Output ndarray must have %d dimensions. Value: %d.', sh.length, getShape( out ).length ) );
 		}
 		for ( i = 0; i < sh.length; i++ ) {
-			if ( getShape( out )[ i ] !== sh[ i ] ) {
+			if ( osh[ i ] !== sh[ i ] ) {
 				throw new RangeError( format( 'invalid argument. Output ndarray dimension %d must have size %d. Value: %d.', i, sh[ i ], getShape( out )[ i ] ) );
 			}
 		}