Skip to content

Commit 33e74d7

Browse files
DhruvArvindSinghDhruvArvindSingh
committed
refactor: refactored stats/base/dmeanvarpn
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---
1 parent a0e7465 commit 33e74d7

File tree

18 files changed

+86
-161
lines changed

18 files changed

+86
-161
lines changed

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/benchmark/benchmark.js‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,20 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float64Array = require( '@stdlib/array/float64' );
2827
var pkg = require( './../package.json' ).name;
2928
var dmeanvarpn = require( './../lib/dmeanvarpn.js' );
3029

3130

31+
// VARIABLES //
32+
33+
var options = {
34+
'dtype': 'float64'
35+
};
36+
37+
3238
// FUNCTIONS //
3339

3440
/**
@@ -39,15 +45,8 @@ var dmeanvarpn = require( './../lib/dmeanvarpn.js' );
3945
* @returns {Function} benchmark function
4046
*/
4147
function createBenchmark( len ) {
42-
var out;
43-
var x;
44-
var i;
45-
46-
x = new Float64Array( len );
47-
for ( i = 0; i < x.length; i++ ) {
48-
x[ i ] = ( randu()*20.0 ) - 10.0;
49-
}
50-
out = new Float64Array( 2 );
48+
var out = uniform( 2, 0.0, 0.0, options );
49+
var x = uniform( len, -10.0, 10.0, options );
5150
return benchmark;
5251

5352
function benchmark( b ) {

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/benchmark/benchmark.native.js‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float64Array = require( '@stdlib/array/float64' );
2928
var tryRequire = require( '@stdlib/utils/try-require' );
3029
var pkg = require( './../package.json' ).name;
3130

@@ -36,6 +35,9 @@ var dmeanvarpn = tryRequire( resolve( __dirname, './../lib/dmeanvarpn.native.js'
3635
var opts = {
3736
'skip': ( dmeanvarpn instanceof Error )
3837
};
38+
var options = {
39+
'dtype': 'float64'
40+
};
3941

4042

4143
// FUNCTIONS //
@@ -48,15 +50,8 @@ var opts = {
4850
* @returns {Function} benchmark function
4951
*/
5052
function createBenchmark( len ) {
51-
var out;
52-
var x;
53-
var i;
54-
55-
x = new Float64Array( len );
56-
for ( i = 0; i < x.length; i++ ) {
57-
x[ i ] = ( randu()*20.0 ) - 10.0;
58-
}
59-
out = new Float64Array( 2 );
53+
var out = uniform( 2, 0.0, 0.0, options );
54+
var x = uniform( len, -10.0, 10.0, options );
6055
return benchmark;
6156

6257
function benchmark( b ) {

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/benchmark/benchmark.ndarray.js‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,20 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var pow = require( '@stdlib/math/base/special/pow' );
27-
var Float64Array = require( '@stdlib/array/float64' );
2827
var pkg = require( './../package.json' ).name;
2928
var dmeanvarpn = require( './../lib/ndarray.js' );
3029

3130

31+
// VARIABLES //
32+
33+
var options = {
34+
'dtype': 'float64'
35+
};
36+
37+
3238
// FUNCTIONS //
3339

3440
/**
@@ -39,15 +45,8 @@ var dmeanvarpn = require( './../lib/ndarray.js' );
3945
* @returns {Function} benchmark function
4046
*/
4147
function createBenchmark( len ) {
42-
var out;
43-
var x;
44-
var i;
45-
46-
x = new Float64Array( len );
47-
for ( i = 0; i < x.length; i++ ) {
48-
x[ i ] = ( randu()*20.0 ) - 10.0;
49-
}
50-
out = new Float64Array( 2 );
48+
var out = uniform( 2, 0.0, 0.0, options );
49+
var x = uniform( len, -10.0, 10.0, options );
5150
return benchmark;
5251

5352
function benchmark( b ) {

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/benchmark/benchmark.ndarray.native.js‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var pow = require( '@stdlib/math/base/special/pow' );
28-
var Float64Array = require( '@stdlib/array/float64' );
2928
var tryRequire = require( '@stdlib/utils/try-require' );
3029
var pkg = require( './../package.json' ).name;
3130

@@ -36,6 +35,9 @@ var dmeanvarpn = tryRequire( resolve( __dirname, './../lib/ndarray.native.js' )
3635
var opts = {
3736
'skip': ( dmeanvarpn instanceof Error )
3837
};
38+
var options = {
39+
'dtype': 'float64'
40+
};
3941

4042

4143
// FUNCTIONS //
@@ -48,15 +50,8 @@ var opts = {
4850
* @returns {Function} benchmark function
4951
*/
5052
function createBenchmark( len ) {
51-
var out;
52-
var x;
53-
var i;
54-
55-
x = new Float64Array( len );
56-
for ( i = 0; i < x.length; i++ ) {
57-
x[ i ] = ( randu()*20.0 ) - 10.0;
58-
}
59-
out = new Float64Array( 2 );
53+
var out = uniform( 2, 0.0, 0.0, options );
54+
var x = uniform( len, -10.0, 10.0, options );
6055
return benchmark;
6156

6257
function benchmark( b ) {

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/docs/repl.txt‎

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Computes the mean and variance of a double-precision floating-point strided
44
array using a two-pass algorithm.
55

6-
The `N` and `stride` parameters determine which elements are accessed at
6+
The `N` and stride parameters determine which elements are accessed at
77
runtime.
88

99
Indexing is relative to the first index. To introduce an offset, use a typed
@@ -32,13 +32,13 @@
3232
Input array.
3333

3434
strideX: integer
35-
Index increment for `x`.
35+
Stride Lenght for `x`.
3636

3737
out: Float64Array
3838
Output array.
3939

4040
strideOut: integer
41-
Index increment for `out`.
41+
Stride Lenght for `out`.
4242

4343
Returns
4444
-------
@@ -53,27 +53,26 @@
5353
> {{alias}}( x.length, 1, x, 1, out, 1 )
5454
<Float64Array>[ ~0.3333, ~4.3333 ]
5555

56-
// Using `N` and `stride` parameters:
56+
// Using `N` and stride parameters:
5757
> x = new {{alias:@stdlib/array/float64}}( [ -2.0, 1.0, 1.0, -5.0, 2.0, -1.0 ] );
5858
> out = new {{alias:@stdlib/array/float64}}( 2 );
59-
> var N = {{alias:@stdlib/math/base/special/floor}}( x.length / 2 );
60-
> {{alias}}( N, 1, x, 2, out, 1 )
59+
> {{alias}}( 3, 1, x, 2, out, 1 )
6160
<Float64Array>[ ~0.3333, ~4.3333 ]
6261

6362
// Using view offsets:
6463
> var x0 = new {{alias:@stdlib/array/float64}}( [ 1.0, -2.0, 3.0, 2.0, 5.0, 1.0 ] );
6564
> var x1 = new {{alias:@stdlib/array/float64}}( x0.buffer, x0.BYTES_PER_ELEMENT*1 );
66-
> N = {{alias:@stdlib/math/base/special/floor}}( x0.length / 2 );
6765
> out = new {{alias:@stdlib/array/float64}}( 2 );
68-
> {{alias}}( N, 1, x1, 2, out, 1 )
66+
> {{alias}}( 3, 1, x1, 2, out, 1 )
6967
<Float64Array>[ ~0.3333, ~4.3333 ]
7068

69+
7170
{{alias}}.ndarray( N, c, x, strideX, offsetX, out, strideOut, offsetOut )
7271
Computes the mean and variance of a double-precision floating-point strided
7372
array using a two-pass algorithm and alternative indexing semantics.
7473

7574
While typed array views mandate a view offset based on the underlying
76-
buffer, the `offset` parameter supports indexing semantics based on a
75+
buffer, the offset parameter supports indexing semantics based on a
7776
starting index.
7877

7978
Parameters
@@ -97,7 +96,7 @@
9796
Input array.
9897

9998
strideX: integer
100-
Index increment for `x`.
99+
Stride Length for `x`.
101100

102101
offsetX: integer
103102
Starting index for `x`.
@@ -106,7 +105,7 @@
106105
Output array.
107106

108107
strideOut: integer
109-
Index increment for `out`.
108+
Stride Length for `out`.
110109

111110
offsetOut: integer
112111
Starting index for `out`.

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/docs/types/index.d.ts‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ interface Routine {
2828
* @param N - number of indexed elements
2929
* @param correction - degrees of freedom adjustment
3030
* @param x - input array
31-
* @param strideX - `x` stride length
31+
* @param strideX - stride length for `x`
3232
* @param out - output array
33-
* @param strideOut - `out` stride length
33+
* @param strideOut - stride length for `out`
3434
* @returns output array
3535
*
3636
* @example
@@ -50,11 +50,11 @@ interface Routine {
5050
* @param N - number of indexed elements
5151
* @param correction - degrees of freedom adjustment
5252
* @param x - input array
53-
* @param strideX - `x` stride length
54-
* @param offsetX - `x` starting index
53+
* @param strideX - stride length for `x`
54+
* @param offsetX - starting index for `x`
5555
* @param out - output array
56-
* @param strideOut - `out` stride length
57-
* @param offsetOut - `out` starting index
56+
* @param strideOut - stride length for `out`
57+
* @param offsetOut - starting index for `out`
5858
* @returns output array
5959
*
6060
* @example

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/examples/c/example.c‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,21 @@
1717
*/
1818

1919
#include "stdlib/stats/base/dmeanvarpn.h"
20-
#include <stdint.h>
2120
#include <stdio.h>
2221

2322
int main( void ) {
2423
// Create a strided array:
25-
double x[] = { 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0 };
24+
const double x[] = { 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0 };
2625

2726
// Create an output array:
2827
double out[] = { 0.0, 0.0 };
2928

3029
// Specify the number of elements:
31-
int64_t N = 4;
30+
int N = 4;
3231

3332
// Specify the stride lengths:
34-
int64_t strideX = 2;
35-
int64_t strideOut = 1;
33+
int strideX = 2;
34+
int strideOut = 1;
3635

3736
// Compute the mean and variance:
3837
stdlib_strided_dmeanvarpn( N, 1, x, strideX, out, strideOut );

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/examples/index.js‎

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,16 @@
1818

1919
'use strict';
2020

21-
var randu = require( '@stdlib/random/base/randu' );
22-
var round = require( '@stdlib/math/base/special/round' );
23-
var Float64Array = require( '@stdlib/array/float64' );
21+
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
2422
var dmeanvarpn = require( './../lib' );
2523

26-
var out;
27-
var x;
28-
var i;
29-
30-
x = new Float64Array( 10 );
31-
for ( i = 0; i < x.length; i++ ) {
32-
x[ i ] = round( (randu()*100.0) - 50.0 );
33-
}
24+
var x = discreteUniform( 10, -50, 50, {
25+
'dtype': 'float64'
26+
});
3427
console.log( x );
3528

36-
out = new Float64Array( 2 );
29+
var out = discreteUniform( 10, 0, 0, {
30+
'dtype': 'float64'
31+
});
3732
dmeanvarpn( x.length, 1, x, 1, out, 1 );
3833
console.log( out );

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/include/stdlib/stats/base/dmeanvarpn.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ extern "C" {
3333
*/
3434
void API_SUFFIX( stdlib_strided_dmeanvarpn )( const CBLAS_INT N, const double correction, const double *X, const CBLAS_INT strideX, double *Out, const CBLAS_INT strideOut );
3535
/**
36-
* Computes the mean and variance of a double-precision floating-point strided array using a two-pass algorithm.
36+
* Computes the mean and variance of a double-precision floating-point strided array using a two-pass algorithm and alternative indexing semantics.
3737
*/
3838
void API_SUFFIX( stdlib_strided_dmeanvarpn_ndarray )( const CBLAS_INT N, const double correction, const double *X, const CBLAS_INT strideX, const CBLAS_INT offsetX, double *Out, const CBLAS_INT strideOut, const CBLAS_INT offsetOut );
3939

‎lib/node_modules/@stdlib/stats/base/dmeanvarpn/lib/index.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,12 @@
3535
*
3636
* @example
3737
* var Float64Array = require( '@stdlib/array/float64' );
38-
* var floor = require( '@stdlib/math/base/special/floor' );
3938
* var dmeanvarpn = require( '@stdlib/stats/base/dmeanvarpn' );
4039
*
4140
* var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
4241
* var out = new Float64Array( 2 );
4342
*
44-
* var N = floor( x.length / 2 );
45-
*
46-
* var v = dmeanvarpn.ndarray( N, 1, x, 2, 1, out, 1, 0 );
43+
* var v = dmeanvarpn.ndarray( 4, 1, x, 2, 1, out, 1, 0 );
4744
* // returns <Float64Array>[ 1.25, 6.25 ]
4845
*/
4946

0 commit comments

Comments
 (0)