Skip to content

Commit 38cc4dd

Browse files
committed
bench: move random number generation outside the benchmarking loops
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent 4441aa5 commit 38cc4dd

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

lib/node_modules/@stdlib/stats/base/dists/arcsine/mean/benchmark/benchmark.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var Float64Array = require( '@stdlib/array/float64' );
2525
var uniform = require( '@stdlib/random/base/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var pkg = require( './../package.json' ).name;
@@ -31,16 +31,23 @@ var mean = require( './../lib' );
3131
// MAIN //
3232

3333
bench( pkg, function benchmark( b ) {
34+
var len;
3435
var min;
3536
var max;
3637
var y;
3738
var i;
3839

40+
len = 100;
41+
min = new Float64Array( len );
42+
max = new Float64Array( len );
43+
for ( i = 0; i < len; i++ ) {
44+
min[ i ] = uniform( 0.0, 10.0 );
45+
max[ i ] = uniform( min[ i ], min[ i ] + 10.0 );
46+
}
47+
3948
b.tic();
4049
for ( i = 0; i < b.iterations; i++ ) {
41-
min = ( randu()*10.0 );
42-
max = uniform( min, min + 10.0 );
43-
y = mean( min, max );
50+
y = mean( min[ i % len ], max[ i % len ] );
4451
if ( isnan( y ) ) {
4552
b.fail( 'should not return NaN' );
4653
}

lib/node_modules/@stdlib/stats/base/dists/arcsine/mean/benchmark/benchmark.native.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
2525
var Float64Array = require( '@stdlib/array/float64' );
26-
var randu = require( '@stdlib/random/base/randu' );
2726
var uniform = require( '@stdlib/random/base/uniform' );
2827
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2928
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -51,7 +50,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
5150
min = new Float64Array( len );
5251
max = new Float64Array( len );
5352
for ( i = 0; i < len; i++ ) {
54-
min[ i ] = ( randu()*10.0 );
53+
min[ i ] = uniform( 0.0, 10.0 );
5554
max[ i ] = uniform( min[ i ], min[ i ] + 10.0 );
5655
}
5756

0 commit comments

Comments
 (0)