Skip to content

Commit 39187d3

Browse files
committed
chore: stuff from code review
1 parent f423985 commit 39187d3

File tree

7 files changed

+58
-26
lines changed

7 files changed

+58
-26
lines changed

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/README.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ for ( i = 0; i < 10; i++ ) {
175175

176176
#### stdlib_base_dists_betaprime_kurtosis( alpha, beta )
177177

178-
Returns the excess kurtosis of an betaprime distribution.
178+
Returns the excess kurtosis of a beta prime distribution.
179179

180180
```c
181181
double out = stdlib_base_dists_betaprime_kurtosis( 2.0, 6.0 );
@@ -184,8 +184,8 @@ double out = stdlib_base_dists_betaprime_kurtosis( 2.0, 6.0 );
184184

185185
The function accepts the following arguments:
186186

187-
- **alpha**: `[in] double` first shape parameter
188-
- **beta**: `[in] double` second shape parameter
187+
- **alpha**: `[in] double` first shape parameter.
188+
- **beta**: `[in] double` second shape parameter.
189189

190190
```c
191191
double stdlib_base_dists_betaprime_kurtosis( const double alpha, const double beta );
@@ -220,9 +220,14 @@ int main( void ) {
220220
double y;
221221
int i;
222222
223+
static double random_uniform( const double min, const double max ) {
224+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
225+
return min + ( v*(max-min) );
226+
}
227+
223228
for ( i = 0; i < 25; i++ ) {
224-
a = ( (double)rand() / (double)RAND_MAX ) * 20.0;
225-
b = ( (double)rand() / (double)RAND_MAX ) * 20.0 + 4.0;
229+
a = random_uniform( 0, 20 );
230+
b = random_uniform( 0, 20 ) + 4.0;
226231
y = stdlib_base_dists_betaprime_kurtosis( a, b );
227232
printf( "α: %lf, β: %lf, Kurt(X;α,β): %lf", a, b, y );
228233
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/benchmark/benchmark.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24+
var Float64Array = require( '@stdlib/array/float64' );
2425
var randu = require( '@stdlib/random/base/randu' );
2526
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2627
var EPS = require( '@stdlib/constants/float64/eps' );
@@ -33,14 +34,21 @@ var kurtosis = require( './../lib' );
3334
bench( pkg, function benchmark( b ) {
3435
var alpha;
3536
var beta;
37+
var len;
3638
var y;
3739
var i;
3840

41+
len = 100;
42+
alpha = new Float64Array( len );
43+
beta = new Float64Array( len );
44+
for ( i = 0; i < len; i++ ) {
45+
alpha[ i ] = ( randu() * 20.0 ) + EPS;
46+
beta[ i ] = ( randu() * 20.0 ) + 4.0 + EPS;
47+
}
48+
3949
b.tic();
4050
for ( i = 0; i < b.iterations; i++ ) {
41-
alpha = ( randu()*10.0 ) + EPS;
42-
beta = ( randu()*10.0 ) + 4.0 + EPS;
43-
y = kurtosis( alpha, beta );
51+
y = kurtosis( alpha[ i % len ], beta[ i % len ] );
4452
if ( isnan( y ) ) {
4553
b.fail( 'should not return NaN' );
4654
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/benchmark/benchmark.native.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25+
var Float64Array = require( '@stdlib/array/float64' );
2526
var randu = require( '@stdlib/random/base/randu' );
2627
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2728
var tryRequire = require( '@stdlib/utils/try-require' );
@@ -42,14 +43,21 @@ var opts = {
4243
bench( pkg, opts, function benchmark( b ) {
4344
var alpha;
4445
var beta;
46+
var len;
4547
var y;
4648
var i;
4749

50+
len = 100;
51+
alpha = new Float64Array( len );
52+
beta = new Float64Array( len );
53+
for ( i = 0; i < len; i++ ) {
54+
alpha[ i ] = ( randu() * 20.0 ) + EPS;
55+
beta[ i ] = ( randu() * 20.0 ) + 4.0 + EPS;
56+
}
57+
4858
b.tic();
4959
for ( i = 0; i < b.iterations; i++ ) {
50-
alpha = ( randu()*10.0 ) + EPS;
51-
beta = ( randu()*10.0 ) + 4.0 + EPS;
52-
y = kurtosis( alpha, beta );
60+
y = kurtosis( alpha[ i % 100 ], beta[ i % 100 ] );
5361
if ( isnan( y ) ) {
5462
b.fail( 'should not return NaN' );
5563
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/benchmark/c/benchmark.c

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,15 @@ static double tic( void ) {
7575
}
7676

7777
/**
78-
* Generates a random number on the interval [0,1).
78+
* Generates a random number on the interval [min,max).
7979
*
80-
* @return random number
80+
* @param min minimum value (inclusive)
81+
* @param max maximum value (exclusive)
82+
* @return random number
8183
*/
82-
static double rand_double( void ) {
83-
int r = rand();
84-
return (double)r / ( (double)RAND_MAX + 1.0 );
84+
static double random_uniform( const double min, const double max ) {
85+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
86+
return min + ( v*(max-min) );
8587
}
8688

8789
/**
@@ -91,17 +93,20 @@ static double rand_double( void ) {
9193
*/
9294
static double benchmark( void ) {
9395
double elapsed;
94-
double alpha;
95-
double beta;
96+
double alpha[ 100 ];
97+
double beta[ 100 ];
9698
double y;
9799
double t;
98100
int i;
99101

102+
for ( i = 0; i < 100; i++ ) {
103+
alpha[ i ] = random_uniform( 0, 20 );
104+
beta[ i ] = random_uniform( 0, 20 ) + 4.0;
105+
}
106+
100107
t = tic();
101108
for ( i = 0; i < ITERATIONS; i++ ) {
102-
alpha = 20.0 * rand_double();
103-
beta = 20 * rand_double() + 4.0;
104-
y = stdlib_base_dists_betaprime_kurtosis( alpha, beta );
109+
y = stdlib_base_dists_betaprime_kurtosis( alpha[ i % 100 ], beta[ i % 100 ] );
105110
if ( y != y ) {
106111
printf( "should not return NaN\n" );
107112
break;

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/examples/c/example.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,20 @@
2020
#include <stdlib.h>
2121
#include <stdio.h>
2222

23+
static double random_uniform( const double min, const double max ) {
24+
double v = (double)rand() / ( (double)RAND_MAX + 1.0 );
25+
return min + ( v*(max-min) );
26+
}
27+
2328
int main( void ) {
2429
double alpha;
2530
double beta;
2631
double y;
2732
int i;
2833

2934
for ( i = 0; i < 25; i++ ) {
30-
alpha = ( (double)rand() / (double)RAND_MAX ) * 20.0;
31-
beta = ( (double)rand() / (double)RAND_MAX ) * 20.0 + 4.0;
35+
alpha = random_uniform( 0, 20 );
36+
beta = random_uniform( 0, 20 ) + 4.0;
3237
y = stdlib_base_dists_betaprime_kurtosis( alpha, beta );
3338
printf( "α: %lf, β: %lf, Kurt(X;α,β): %lf\n", alpha, beta, y );
3439
}

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/lib/native.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ var addon = require( './../src/addon.node' );
2828
/**
2929
* Returns the excess kurtosis of a beta prime distribution.
3030
*
31+
* @private
3132
* @param {PositiveNumber} alpha - first shape parameter
3233
* @param {PositiveNumber} beta - second shape parameter
3334
* @returns {number} kurtosis

lib/node_modules/@stdlib/stats/base/dists/betaprime/kurtosis/src/main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
#include "stdlib/math/base/assert/is_nan.h"
2121

2222
/**
23-
* Returns the excess kurtosis of an beta prime distribution.
23+
* Returns the excess kurtosis of a beta prime distribution.
2424
*
2525
* @param alpha first shape parameter
26-
* @param beta second shape paramter
27-
* @return excess kurtosis
26+
* @param beta second shape paramter
27+
* @return excess kurtosis
2828
*
2929
* @example
3030
* double y = stdlib_base_betaprime_kurtosis( 2.0, 6.0 );

0 commit comments

Comments
 (0)