fix: apply suggestions from code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: headlessNode

lib/node_modules/@stdlib/blas/ext/base/sindex-of/README.md

@@ -56,11 +56,11 @@ var idx = sindexOf( x.length, 3.0, x, 1 );
 The function has the following parameters:
 
 -   **N**: number of indexed elements.
--   **searchElement**: element to search the index of.
+-   **searchElement**: search element.
 -   **x**: input [`Float32Array`][@stdlib/array/float32].
--   **strideX**: index increment.
+-   **strideX**: stride length.
 
-If the function is unable to find an element which equals a provided search element, the function returns `-1`.
+If the function is unable to find a search element, the function returns `-1`.
 
 ```javascript
 var Float32Array = require( '@stdlib/array/float32' );
@@ -79,7 +79,7 @@ var Float32Array = require( '@stdlib/array/float32' );
 var x = new Float32Array( [ -2.0, 1.0, 3.0, -5.0, 4.0, 0.0, -1.0, 3.0 ] );
 
 var idx = sindexOf( 4, -1.0, x, 2 );
-// returns 6
+// returns 3
 ```
 
 Note that indexing is relative to the first index. To introduce an offset, use [`typed array`][mdn-typed-array] views.
@@ -95,7 +95,7 @@ var x1 = new Float32Array( x0.buffer, x0.BYTES_PER_ELEMENT*1 ); // start at 2nd
 
 // Find index...
 var idx = sindexOf( 3, -6.0, x1, 2 );
-// returns 4
+// returns 2
 ```
 
 #### sindexOf.ndarray( N, searchElement, x, strideX, offsetX )
@@ -123,7 +123,7 @@ var Float32Array = require( '@stdlib/array/float32' );
 var x = new Float32Array( [ -2.0, 1.0, 3.0, -5.0, 4.0, 0.0, -1.0, 3.0 ] );
 
 var idx = sindexOf.ndarray( 3, 3.0, x, 1, x.length-3 );
-// returns 7
+// returns 2
 ```
 
 </section>

lib/node_modules/@stdlib/blas/ext/base/sindex-of/benchmark/benchmark.length.js

@@ -53,7 +53,7 @@ function createBenchmark( len ) {
 
 		b.tic();
 		for ( i = 0; i < b.iterations; i++ ) {
-			out = sindexOf( x.length, 2.0, x, 1 );
+			out = sindexOf( x.length, len+1, x, 1 );
 			if ( out !== out ) {
 				b.fail( 'should return an integer' );
 			}
@@ -89,7 +89,7 @@ function main() {
 		len = pow( 10, i );
 
 		f = createBenchmark( len );
-		bench( pkg+':dtype=float32,len='+len, f );
+		bench( pkg+':len='+len, f );
 	}
 }
 

lib/node_modules/@stdlib/blas/ext/base/sindex-of/benchmark/benchmark.ndarray.js

@@ -53,7 +53,7 @@ function createBenchmark( len ) {
 
 		b.tic();
 		for ( i = 0; i < b.iterations; i++ ) {
-			out = sindexOf( x.length, 2.0, x, 1, 0 );
+			out = sindexOf( x.length, len+1, x, 1, 0 );
 			if ( out !== out ) {
 				b.fail( 'should return an integer' );
 			}
@@ -89,7 +89,7 @@ function main() {
 		len = pow( 10, i );
 
 		f = createBenchmark( len );
-		bench( pkg+':dtype=float32,len='+len, f );
+		bench( pkg+':len='+len, f );
 	}
 }
 

lib/node_modules/@stdlib/blas/ext/base/sindex-of/docs/repl.txt

@@ -23,7 +23,7 @@
         Input array.
 
     strideX: integer
-        Index increment.
+        Stride length.
 
     Returns
     -------
@@ -57,7 +57,7 @@
         Input array.
 
     strideX: integer
-        Index increment.
+        Stride length.
 
     offsetX: integer
         Starting index.

lib/node_modules/@stdlib/blas/ext/base/sindex-of/lib/main.js

@@ -30,9 +30,9 @@ var ndarray = require( './ndarray.js' );
 * Returns the index of a specified search element in a single-precision floating-point strided array.
 *
 * @param {PositiveInteger} N - number of indexed elements
-* @param {Number} searchElement - number to search index of
+* @param {number} searchElement - search element
 * @param {Float32Array} x - input array
-* @param {integer} strideX - index increment
+* @param {integer} strideX - stride length
 * @returns {integer} index
 *
 * @example

lib/node_modules/@stdlib/blas/ext/base/sindex-of/lib/ndarray.js

@@ -24,9 +24,9 @@
 * Returns the index of a specified search element in a single-precision floating-point strided array.
 *
 * @param {PositiveInteger} N - number of indexed elements
-* @param {Number} searchElement - number to search index of
+* @param {number} searchElement - search element
 * @param {Float32Array} x - input array
-* @param {integer} strideX - index increment
+* @param {integer} strideX - stride length
 * @param {NonNegativeInteger} offsetX - starting index
 * @returns {integer} index
 *
@@ -42,14 +42,14 @@ function sindexOf( N, searchElement, x, strideX, offsetX ) {
 	var ix;
 	var i;
 
-	if ( N <= 0 || x.length === 0 ) {
+	if ( N <= 0 ) {
 		return -1;
 	}
 
 	ix = offsetX;
 	for ( i = 0; i < N; i++ ) {
 		if ( x[ ix ] === searchElement ) {
-			return ix;
+			return i;
 		}
 		ix += strideX;
 	}

lib/node_modules/@stdlib/blas/ext/base/sindex-of/test/test.main.js

@@ -51,13 +51,13 @@ tape( 'the function returns the first index of an element which equals a provide
 
 	// Negative stride...
 	actual = sindexOf( x.length, 1.0, x, -1 );
-	t.strictEqual( actual, 1, 'returns expected value' );
+	t.strictEqual( actual, 4, 'returns expected value' );
 
 	actual = sindexOf( x.length, 2.0, x, -1 );
-	t.strictEqual( actual, 3, 'returns expected value' );
+	t.strictEqual( actual, 2, 'returns expected value' );
 
 	actual = sindexOf( x.length, 3.0, x, -1 );
-	t.strictEqual( actual, 5, 'returns expected value' );
+	t.strictEqual( actual, 0, 'returns expected value' );
 
 	t.end();
 });

lib/node_modules/@stdlib/blas/ext/base/sindex-of/test/test.ndarray.js

@@ -44,20 +44,20 @@ tape( 'the function returns the first index of an element which equals a provide
 	t.strictEqual( actual, 0, 'returns expected value' );
 
 	actual = sindexOf( x.length, 2.0, x, 1, 1 );
-	t.strictEqual( actual, 2, 'returns expected value' );
+	t.strictEqual( actual, 1, 'returns expected value' );
 
 	actual = sindexOf( x.length, 3.0, x, 1, 2 );
-	t.strictEqual( actual, 4, 'returns expected value' );
+	t.strictEqual( actual, 2, 'returns expected value' );
 
 	// Negative stride...
 	actual = sindexOf( x.length, 1.0, x, -1, x.length-1 );
-	t.strictEqual( actual, 1, 'returns expected value' );
+	t.strictEqual( actual, 4, 'returns expected value' );
 
 	actual = sindexOf( x.length, 2.0, x, -2, x.length-1 );
-	t.strictEqual( actual, 3, 'returns expected value' );
+	t.strictEqual( actual, 1, 'returns expected value' );
 
 	actual = sindexOf( x.length, 1.0, x, -2, x.length-2 );
-	t.strictEqual( actual, 0, 'returns expected value' );
+	t.strictEqual( actual, 2, 'returns expected value' );
 
 	t.end();
 });
@@ -91,12 +91,3 @@ tape( 'the function returns `-1` if provided a search element equal to `NaN`', f
 
 	t.end();
 });
-
-tape( 'the function returns `-1` if provided an offset which exceeds the maximum array index', function test( t ) {
-	var actual;
-
-	actual = sindexOf( 3, 2.0, new Float32Array( [ 1.0, 2.0, 3.0 ] ), 1, 20 );
-	t.strictEqual( actual, -1, 'returns expected value' );
-
-	t.end();
-});