Skip to content

Commit 3af0a09

Browse files
Apply suggestions from code review
Co-authored-by: Aayush Khanna <[email protected]> Signed-off-by: Vinit Pandit <[email protected]>
1 parent cfdf1a7 commit 3af0a09

File tree

10 files changed

+7
-15
lines changed

10 files changed

+7
-15
lines changed

lib/node_modules/@stdlib/stats/base/svariancewd/README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ The function has the following parameters:
118118
- **x**: input [`Float32Array`][@stdlib/array/float32].
119119
- **strideX**: stride length for `x`.
120120

121-
The `N` and `stride` parameters determine which elements in `x` are accessed at runtime. For example, to compute the [variance][variance] of every other element in `x`,
121+
The `N` and stride parameters determine which elements in the strided array are accessed at runtime. For example, to compute the [variance][variance] of every other element in `x`,
122122

123123
```javascript
124124
var Float32Array = require( '@stdlib/array/float32' );
@@ -164,7 +164,6 @@ While [`typed array`][mdn-typed-array] views mandate a view offset based on the
164164

165165
```javascript
166166
var Float32Array = require( '@stdlib/array/float32' );
167-
var floor = require( '@stdlib/math/base/special/floor' );
168167

169168
var x = new Float32Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
170169

@@ -254,7 +253,6 @@ The function accepts the following arguments:
254253
- **X**: `[in] float*` input array.
255254
- **strideX**: `[in] CBLAS_INT` stride length for `X`.
256255
257-
The `N` and stride parameters determine which elements in `x` are accessed at runtime. For example, to compute the [variance][variance] of every other element in `x`,
258256
259257
```c
260258
float stdlib_strided_svariancewd( const CBLAS_INT N, const float correction, const float *X, const CBLAS_INT strideX );

lib/node_modules/@stdlib/stats/base/svariancewd/benchmark/benchmark.ndarray.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ var svariancewd = require( './../lib/ndarray.js' );
3030

3131
// VARIABLES //
3232

33-
var option = {
33+
var options = {
3434
'dtype': 'float32'
3535
};
3636

lib/node_modules/@stdlib/stats/base/svariancewd/docs/repl.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
Input array.
3333

3434
strideX: integer
35-
Index increment.
35+
Stride Length.
3636

3737
Returns
3838
-------

lib/node_modules/@stdlib/stats/base/svariancewd/examples/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ var svariancewd = require( './../lib' );
2323

2424
var x;
2525

26-
x = discreteUniform( 10, -50, 50, {
26+
var x = discreteUniform( 10, -50, 50, {
2727
'dtype': 'float32'
2828
});
2929
console.log( x );

lib/node_modules/@stdlib/stats/base/svariancewd/include/stdlib/stats/base/svariancewd.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ extern "C" {
3434
float API_SUFFIX(stdlib_strided_svariancewd)( const CBLAS_INT N, const float correction, const float *X, const CBLAS_INT strideX );
3535

3636
/**
37-
* Computes the variance of a single-precision floating-point strided array using Welford's algorithm and using alternative indexing semantics..
37+
* Computes the variance of a single-precision floating-point strided array using Welford's algorithm and using alternative indexing semantics.
3838
*/
3939
float API_SUFFIX(stdlib_strided_svariancewd_ndarray)( const CBLAS_INT N, const float correction, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX );
4040

lib/node_modules/@stdlib/stats/base/svariancewd/lib/ndarray.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
7676
*
7777
* @example
7878
* var Float32Array = require( '@stdlib/array/float32' );
79-
* var floor = require( '@stdlib/math/base/special/floor' );
8079
*
8180
* var x = new Float32Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
8281
*

lib/node_modules/@stdlib/stats/base/svariancewd/lib/ndarray.native.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ var addon = require( './../src/addon.node' );
3737
*
3838
* @example
3939
* var Float32Array = require( '@stdlib/array/float32' );
40-
* var floor = require( '@stdlib/math/base/special/floor' );
4140
*
4241
* var x = new Float32Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] );
4342
*

lib/node_modules/@stdlib/stats/base/svariancewd/manifest.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@
9292
"include": [
9393
"./include"
9494
],
95-
"libraries": [
96-
"-lm"
97-
],
95+
"libraries": [],
9896
"libpath": [],
9997
"dependencies": [
10098
"@stdlib/blas/base/shared"

lib/node_modules/@stdlib/stats/base/svariancewd/src/addon.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
* @param info callback data
3333
* @return Node-API value
3434
*/
35-
float API_SUFFIX(stdlib_strided_svariancewd)( const CBLAS_INT N, const float correction, const float *X, const CBLAS_INT strideX );
3635
static napi_value addon( napi_env env, napi_callback_info info ) {
3736
STDLIB_NAPI_ARGV( env, info, argv, argc, 4 );
3837
STDLIB_NAPI_ARGV_INT64( env, N, argv, 0 );

lib/node_modules/@stdlib/stats/base/svariancewd/src/main.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
#include "stdlib/stats/base/svariancewd.h"
2020
#include "stdlib/blas/base/shared.h"
21-
#include <stdint.h>
2221

2322
/**
2423
* Computes the variance of a single-precision floating-point strided array using Welford's algorithm.
@@ -103,7 +102,7 @@ float API_SUFFIX(stdlib_strided_svariancewd)( const CBLAS_INT N, const float cor
103102

104103

105104
/**
106-
* Computes the variance of a single-precision floating-point strided array using Welford's algorithm.
105+
* Computes the variance of a single-precision floating-point strided array using Welford's algorithm using alternative indexing semantics.
107106
*
108107
* @param N number of indexed elements
109108
* @param correction degrees of freedom adjustment

0 commit comments

Comments
 (0)