Skip to content

Commit 3f04604

Browse files
committed
chore: apply suggestions from review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---
1 parent 538b70f commit 3f04604

File tree

4 files changed

+7
-10
lines changed

4 files changed

+7
-10
lines changed

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ The function accepts the following arguments:
189189
- **n**: `[in] int32_t` number of draws.
190190

191191
```c
192-
double stdlib_base_dists_hypergeometric_skewness ( const int32_t N, const int32_t K, const int32_t n );
192+
double stdlib_base_dists_hypergeometric_skewness( const int32_t N, const int32_t K, const int32_t n );
193193
```
194194
195195
</section>

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/benchmark/c/benchmark.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,10 @@ static double random_uniform( const double min, const double max ) {
9393
* @return elapsed time in seconds
9494
*/
9595
static double benchmark( void ) {
96-
double elapsed;
9796
int32_t N[ 100 ];
9897
int32_t K[ 100 ];
9998
int32_t n[ 100 ];
99+
double elapsed;
100100
double y;
101101
double t;
102102
int i;
@@ -109,7 +109,7 @@ static double benchmark( void ) {
109109

110110
t = tic();
111111
for ( i = 0; i < ITERATIONS; i++ ) {
112-
y = stdlib_base_dists_hypergeometric_skewness( N[ i % 100 ], K[ i % 100 ], n[ i % 100 ] );
112+
y = stdlib_base_dists_hypergeometric_skewness( N[ i%100 ], K[ i%100 ], n[ i%100 ] );
113113
if ( y != y ) {
114114
printf( "should not return NaN\n" );
115115
break;

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/manifest.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
"libpath": [],
4040
"dependencies": [
4141
"@stdlib/math/base/napi/ternary",
42-
"@stdlib/constants/float64/pinf",
4342
"@stdlib/math/base/special/sqrt"
4443
]
4544
},
@@ -55,7 +54,6 @@
5554
"libraries": [],
5655
"libpath": [],
5756
"dependencies": [
58-
"@stdlib/constants/float64/pinf",
5957
"@stdlib/math/base/special/sqrt",
6058
"@stdlib/math/base/special/ceil"
6159
]
@@ -73,7 +71,6 @@
7371
"libpath": [],
7472
"dependencies": [
7573
"@stdlib/math/base/special/sqrt",
76-
"@stdlib/constants/float64/pinf",
7774
"@stdlib/math/base/special/ceil"
7875
]
7976
}

lib/node_modules/@stdlib/stats/base/dists/hypergeometric/skewness/src/main.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
#include "stdlib/stats/base/dists/hypergeometric/skewness.h"
2020
#include "stdlib/math/base/special/sqrt.h"
21-
#include "stdlib/constants/float64/pinf.h"
21+
#include <stdint.h>
2222

2323
/**
2424
* Returns the skewness of a hypergeometric distribution.
@@ -39,13 +39,13 @@ double stdlib_base_dists_hypergeometric_skewness( const int32_t N, const int32_t
3939
double p;
4040
double q;
4141

42-
if ( N < 0 || K < 0 || n < 0 || N == STDLIB_CONSTANT_FLOAT64_PINF || K == STDLIB_CONSTANT_FLOAT64_PINF || K > N || n > N ) {
42+
if ( N < 0 || K < 0 || n < 0 || K > N || n > N ) {
4343
return 0.0/0.0; // NaN
4444
}
4545
N_d = (double)N;
4646
K_d = (double)K;
4747
n_d = (double)n;
48-
p = ( N_d - ( 2.0 * K_d ) ) * stdlib_base_sqrt( N_d - 1.0 ) * ( N_d - ( 2.0 * n_d ) );
49-
q = stdlib_base_sqrt( n_d * K_d * ( N_d - K_d ) * ( N_d - n_d ) ) * ( N_d - 2.0 );
48+
p = ( N_d - ( 2.0*K_d ) ) * stdlib_base_sqrt( N_d-1.0 ) * ( N_d - ( 2.0*n_d ) );
49+
q = stdlib_base_sqrt( n_d * K_d * ( N_d-K_d ) * ( N_d-n_d ) ) * ( N_d-2.0 );
5050
return p / q;
5151
}

0 commit comments

Comments
 (0)