Skip to content

Commit 4340425

Browse files
anandkaranubcanandkaranubc
authored
bench: update random value generation
PR-URL: #5367 Reviewed-by: Athan Reines <[email protected]>
1 parent 6e79eff commit 4340425

File tree

16 files changed

+68
-44
lines changed

16 files changed

+68
-44
lines changed

‎lib/node_modules/@stdlib/math/base/special/acovercos/benchmark/benchmark.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var pkg = require( './../package.json' ).name;
2727
var acovercos = require( './../lib' );
@@ -34,10 +34,11 @@ bench( pkg, function benchmark( b ) {
3434
var y;
3535
var i;
3636

37+
x = uniform( 100, -2.0, 0.0 );
38+
3739
b.tic();
3840
for ( i = 0; i < b.iterations; i++ ) {
39-
x = ( -2.0*randu() ) + 0.0;
40-
y = acovercos( x );
41+
y = acovercos( x[ i % x.length ] );
4142
if ( isnan( y ) ) {
4243
b.fail( 'should not return NaN' );
4344
}

‎lib/node_modules/@stdlib/math/base/special/acovercos/benchmark/benchmark.native.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828
var pkg = require( './../package.json' ).name;
@@ -43,10 +43,11 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4343
var y;
4444
var i;
4545

46+
x = uniform( 100, -2.0, 0.0 );
47+
4648
b.tic();
4749
for ( i = 0; i < b.iterations; i++ ) {
48-
x = ( -2.0*randu() ) + 0.0;
49-
y = acovercos( x );
50+
y = acovercos( x[ i % x.length ] );
5051
if ( isnan( y ) ) {
5152
b.fail( 'should not return NaN' );
5253
}

‎lib/node_modules/@stdlib/math/base/special/acovercos/benchmark/c/benchmark.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,19 @@ static double rand_double( void ) {
8989
* @return elapsed time in seconds
9090
*/
9191
static double benchmark( void ) {
92+
double x[ 100 ];
9293
double elapsed;
93-
double x;
9494
double y;
9595
double t;
9696
int i;
9797

98+
for ( i = 0; i < 100; i++ ) {
99+
x[ i ] = ( -2.0*rand_double() ) + 0.0;
100+
}
101+
98102
t = tic();
99103
for ( i = 0; i < ITERATIONS; i++ ) {
100-
x = ( -2.0*rand_double() ) + 0.0;
101-
y = asin( 1.0 + x );
104+
y = asin( 1.0 + x[ i%100 ] );
102105
if ( y != y ) {
103106
printf( "should not return NaN\n" );
104107
break;

‎lib/node_modules/@stdlib/math/base/special/acovercos/benchmark/c/native/benchmark.c

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,19 @@ static double rand_double( void ) {
9090
* @return elapsed time in seconds
9191
*/
9292
static double benchmark( void ) {
93+
double x[ 100 ];
9394
double elapsed;
94-
double x;
9595
double y;
9696
double t;
9797
int i;
9898

99+
for ( i = 0; i < 100; i++ ) {
100+
x[ i ] = ( -2.0*rand_double() );
101+
}
102+
99103
t = tic();
100104
for ( i = 0; i < ITERATIONS; i++ ) {
101-
x = ( -2.0*rand_double() );
102-
y = stdlib_base_acovercos( x );
105+
y = stdlib_base_acovercos( x[ i%100 ] );
103106
if ( y != y ) {
104107
printf( "should not return NaN\n" );
105108
break;

‎lib/node_modules/@stdlib/math/base/special/acovercos/test/test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ tape( 'the function computes the inverse coversed cosine (small negative numbers
9292

9393
tape( 'the function returns `NaN` if provided a `NaN`', function test( t ) {
9494
var v = acovercos( NaN );
95-
t.strictEqual( isnan( v ), true, 'returns NaN' );
95+
t.strictEqual( isnan( v ), true, 'returns expected value' );
9696
t.end();
9797
});
9898

@@ -101,7 +101,7 @@ tape( 'the function returns `NaN` if provided a value less than `-2`', function
101101
var i;
102102
for ( i = 0; i < 1e4; i++ ) {
103103
v = -(randu()*1.0e6) - (2.0+EPS);
104-
t.strictEqual( isnan( acovercos( v ) ), true, 'returns NaN when provided '+v );
104+
t.strictEqual( isnan( acovercos( v ) ), true, 'returns expected value when provided '+v );
105105
}
106106
t.end();
107107
});
@@ -111,7 +111,7 @@ tape( 'the function returns `NaN` if provided a value greater than `0`', functio
111111
var i;
112112
for ( i = 0; i < 1e4; i++ ) {
113113
v = (randu()*1.0e6) + 0.0 + EPS;
114-
t.strictEqual( isnan( acovercos( v ) ), true, 'returns NaN when provided '+v );
114+
t.strictEqual( isnan( acovercos( v ) ), true, 'returns expected value when provided '+v );
115115
}
116116
t.end();
117117
});

‎lib/node_modules/@stdlib/math/base/special/acovercos/test/test.native.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ tape( 'the function computes the inverse coversed cosine (small negative numbers
101101

102102
tape( 'the function returns `NaN` if provided a `NaN`', opts, function test( t ) {
103103
var v = acovercos( NaN );
104-
t.strictEqual( isnan( v ), true, 'returns NaN' );
104+
t.strictEqual( isnan( v ), true, 'returns expected value' );
105105
t.end();
106106
});
107107

@@ -110,7 +110,7 @@ tape( 'the function returns `NaN` if provided a value less than `-2`', opts, fun
110110
var i;
111111
for ( i = 0; i < 1e4; i++ ) {
112112
v = -(randu()*1.0e6) - (2.0+EPS);
113-
t.strictEqual( isnan( acovercos( v ) ), true, 'returns NaN when provided '+v );
113+
t.strictEqual( isnan( acovercos( v ) ), true, 'returns expected value when provided '+v );
114114
}
115115
t.end();
116116
});
@@ -120,7 +120,7 @@ tape( 'the function returns `NaN` if provided a value greater than `0`', opts, f
120120
var i;
121121
for ( i = 0; i < 1e4; i++ ) {
122122
v = (randu()*1.0e6) + 0.0 + EPS;
123-
t.strictEqual( isnan( acovercos( v ) ), true, 'returns NaN when provided '+v );
123+
t.strictEqual( isnan( acovercos( v ) ), true, 'returns expected value when provided '+v );
124124
}
125125
t.end();
126126
});

‎lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/benchmark.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/array/uniform' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2626
var pkg = require( './../package.json' ).name;
2727
var acovercosf = require( './../lib' );
@@ -34,7 +34,9 @@ bench( pkg, function benchmark( b ) {
3434
var y;
3535
var i;
3636

37-
x = randu( 100, -2.0, 0.0 );
37+
x = uniform( 100, -2.0, 0.0, {
38+
'dtype': 'float32'
39+
});
3840

3941
b.tic();
4042
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/math/base/special/acovercosf/benchmark/benchmark.native.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/array/uniform' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828
var pkg = require( './../package.json' ).name;
@@ -43,7 +43,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4343
var y;
4444
var i;
4545

46-
x = randu( 100, -2.0, 0.0 );
46+
x = uniform( 100, -2.0, 0.0, {
47+
'dtype': 'float32'
48+
});
4749

4850
b.tic();
4951
for ( i = 0; i < b.iterations; i++ ) {

‎lib/node_modules/@stdlib/math/base/special/acoversin/benchmark/benchmark.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var bench = require( '@stdlib/bench' );
24-
var randu = require( '@stdlib/random/base/randu' );
24+
var uniform = require( '@stdlib/random/array/uniform' );
2525
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2626
var pkg = require( './../package.json' ).name;
2727
var acoversin = require( './../lib' );
@@ -34,10 +34,11 @@ bench( pkg, function benchmark( b ) {
3434
var y;
3535
var i;
3636

37+
x = uniform( 100, 0.0, 2.0 );
38+
3739
b.tic();
3840
for ( i = 0; i < b.iterations; i++ ) {
39-
x = ( 2.0*randu() ) - 0.0;
40-
y = acoversin( x );
41+
y = acoversin( x[ i % x.length ] );
4142
if ( isnan( y ) ) {
4243
b.fail( 'should not return NaN' );
4344
}

‎lib/node_modules/@stdlib/math/base/special/acoversin/benchmark/benchmark.native.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var bench = require( '@stdlib/bench' );
25-
var randu = require( '@stdlib/random/base/randu' );
25+
var uniform = require( '@stdlib/random/array/uniform' );
2626
var isnan = require( '@stdlib/math/base/assert/is-nan' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828
var pkg = require( './../package.json' ).name;
@@ -43,10 +43,11 @@ bench( pkg+'::native', opts, function benchmark( b ) {
4343
var y;
4444
var i;
4545

46+
x = uniform( 100, 0.0, 2.0 );
47+
4648
b.tic();
4749
for ( i = 0; i < b.iterations; i++ ) {
48-
x = ( randu()*2.0 );
49-
y = acoversin( x );
50+
y = acoversin( x[ i % x.length ] );
5051
if ( isnan( y ) ) {
5152
b.fail( 'should not return NaN' );
5253
}

0 commit comments

Comments
 (0)