Skip to content

Commit 4438919

Browse files
kgrytekgryte
committed
fix: update implementation to preserve signed zeros
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent bcd9ff7 commit 4438919

File tree

6 files changed

+45
-18
lines changed

6 files changed

+45
-18
lines changed

‎lib/node_modules/@stdlib/blas/ext/base/ssumors/lib/ndarray.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
// MODULES //
2222

23-
var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' );
23+
var f32 = require( '@stdlib/number/float64/base/to-float32' );
2424

2525

2626
// MAIN //
@@ -47,16 +47,17 @@ function ssumors( N, x, strideX, offsetX ) {
4747
var ix;
4848
var i;
4949

50-
sum = 0.0;
5150
if ( N <= 0 ) {
52-
return sum;
51+
return 0.0;
5352
}
5453
ix = offsetX;
5554
if ( strideX === 0 ) {
5655
return N * x[ ix ];
5756
}
58-
for ( i = 0; i < N; i++ ) {
59-
sum = float64ToFloat32( sum + x[ ix ] );
57+
sum = x[ ix ];
58+
ix += strideX;
59+
for ( i = 1; i < N; i++ ) {
60+
sum = f32( sum + x[ ix ] );
6061
ix += strideX;
6162
}
6263
return sum;

‎lib/node_modules/@stdlib/blas/ext/base/ssumors/src/main.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,33 +48,35 @@ float API_SUFFIX(stdlib_strided_ssumors_ndarray)( const CBLAS_INT N, const float
4848
CBLAS_INT i;
4949
float sum;
5050

51-
sum = 0.0f;
5251
if ( N <= 0 ) {
53-
return sum;
52+
return 0.0f;
5453
}
5554
ix = offsetX;
5655
if ( strideX == 0 ) {
5756
return N * X[ ix ];
5857
}
58+
sum = X[ ix ];
59+
ix += strideX;
60+
5961
// If the stride is equal to `1`, use unrolled loops...
6062
if ( strideX == 1 ) {
61-
m = N % 6;
63+
m = ( N-1 ) % 6;
6264

6365
// If we have a remainder, run a clean-up loop...
6466
if ( m > 0 ) {
6567
for ( i = 0; i < m; i++ ) {
6668
sum += X[ ix + i ];
6769
}
6870
}
69-
if ( N < 6 ) {
71+
if ( N-1 < 6 ) {
7072
return sum;
7173
}
7274
for ( i = m; i < N; i += 6 ) {
7375
sum += X[ix+i] + X[ix+i+1] + X[ix+i+2] + X[ix+i+3] + X[ix+i+4] + X[ix+i+5];
7476
}
7577
return sum;
7678
}
77-
for ( i = 0; i < N; i++ ) {
79+
for ( i = 1; i < N; i++ ) {
7880
sum += X[ ix ];
7981
ix += strideX;
8082
}

‎lib/node_modules/@stdlib/blas/ext/base/ssumors/test/test.ndarray.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
24+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
25+
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
2526
var Float32Array = require( '@stdlib/array/float32' );
2627
var ssumors = require( './../lib/ndarray.js' );
2728

@@ -57,7 +58,7 @@ tape( 'the function calculates the sum of all strided array elements', function
5758

5859
x = new Float32Array( [ NaN, 4.0 ] );
5960
v = ssumors( x.length, x, 1, 0 );
60-
t.strictEqual( isnan( v ), true, 'returns expected value' );
61+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
6162

6263
x = new Float32Array( [ 1.0, 1.0e38, 1.0, -1.0e38 ] );
6364
v = ssumors( x.length, x, 1, 0 );
@@ -66,6 +67,17 @@ tape( 'the function calculates the sum of all strided array elements', function
6667
t.end();
6768
});
6869

70+
tape( 'the function preserves the sign of zero', function test( t ) {
71+
var x;
72+
var v;
73+
74+
x = new Float32Array( [ -0.0, -0.0, -0.0, -0.0, -0.0 ] );
75+
v = ssumors( x.length, x, 1, 0 );
76+
t.strictEqual( isNegativeZerof( v ), true, 'returns expected value' );
77+
78+
t.end();
79+
});
80+
6981
tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', function test( t ) {
7082
var x;
7183
var v;

‎lib/node_modules/@stdlib/blas/ext/base/ssumors/test/test.ndarray.native.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
25-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
25+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
26+
var isNegativeZerof = require( '@stdlib/math/base/assert/is-negative-zerof' );
2627
var Float32Array = require( '@stdlib/array/float32' );
2728
var tryRequire = require( '@stdlib/utils/try-require' );
2829

@@ -66,7 +67,7 @@ tape( 'the function calculates the sum of all strided array elements', opts, fun
6667

6768
x = new Float32Array( [ NaN, 4.0 ] );
6869
v = ssumors( x.length, x, 1, 0 );
69-
t.strictEqual( isnan( v ), true, 'returns expected value' );
70+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
7071

7172
x = new Float32Array( [ 1.0, 1.0e38, 1.0, -1.0e38 ] );
7273
v = ssumors( x.length, x, 1, 0 );
@@ -75,6 +76,17 @@ tape( 'the function calculates the sum of all strided array elements', opts, fun
7576
t.end();
7677
});
7778

79+
tape( 'the function preserves the sign of zero', opts, function test( t ) {
80+
var x;
81+
var v;
82+
83+
x = new Float32Array( [ -0.0, -0.0, -0.0, -0.0, -0.0 ] );
84+
v = ssumors( x.length, x, 1, 0 );
85+
t.strictEqual( isNegativeZerof( v ), true, 'returns expected value' );
86+
87+
t.end();
88+
});
89+
7890
tape( 'if provided an `N` parameter less than or equal to `0`, the function returns `0.0`', opts, function test( t ) {
7991
var x;
8092
var v;

‎lib/node_modules/@stdlib/blas/ext/base/ssumors/test/test.ssumors.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
// MODULES //
2222

2323
var tape = require( 'tape' );
24-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
24+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2525
var Float32Array = require( '@stdlib/array/float32' );
2626
var ssumors = require( './../lib/ssumors.js' );
2727

@@ -57,7 +57,7 @@ tape( 'the function calculates the sum of all strided array elements', function
5757

5858
x = new Float32Array( [ NaN, 4.0 ] );
5959
v = ssumors( x.length, x, 1 );
60-
t.strictEqual( isnan( v ), true, 'returns expected value' );
60+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
6161

6262
x = new Float32Array( [ 1.0, 1.0e38, 1.0, -1.0e38 ] );
6363
v = ssumors( x.length, x, 1 );

‎lib/node_modules/@stdlib/blas/ext/base/ssumors/test/test.ssumors.native.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
25-
var isnan = require( '@stdlib/math/base/assert/is-nan' );
25+
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2626
var Float32Array = require( '@stdlib/array/float32' );
2727
var tryRequire = require( '@stdlib/utils/try-require' );
2828

@@ -148,7 +148,7 @@ tape( 'the function calculates the sum of all strided array elements', opts, fun
148148

149149
x = new Float32Array( [ NaN, 4.0 ] );
150150
v = ssumors( x.length, x, 1 );
151-
t.strictEqual( isnan( v ), true, 'returns expected value' );
151+
t.strictEqual( isnanf( v ), true, 'returns expected value' );
152152

153153
x = new Float32Array( [ 1.0, 1.0e38, 1.0, -1.0e38 ] );
154154
v = ssumors( x.length, x, 1 );

0 commit comments

Comments
 (0)