Skip to content

Commit 49016b4

Browse files
chore: update according to code review
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent 3ed0ac8 commit 49016b4

File tree

1 file changed

+9
-7
lines changed
  • lib/node_modules/@stdlib/math/base/special/fast/minf/benchmark/c/native

1 file changed

+9
-7
lines changed

lib/node_modules/@stdlib/math/base/special/fast/minf/benchmark/c/native/benchmark.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,13 +75,15 @@ static double tic( void ) {
7575
}
7676

7777
/**
78-
* Generates a random number on the interval [0,1).
78+
* Generates a random number on the interval [min,max).
7979
*
80-
* @return random number
80+
* @param min minimum value (inclusive)
81+
* @param max maximum value (exclusive)
82+
* @return random number
8183
*/
82-
static float rand_float( void ) {
83-
int r = rand();
84-
return (float)r / ( (float)RAND_MAX + 1.0f );
84+
static float random_uniform( const float min, const float max ) {
85+
float v = (float)rand() / ( (float)RAND_MAX + 1.0f );
86+
return min + ( v*( max - min ) );
8587
}
8688

8789
/**
@@ -98,8 +100,8 @@ static double benchmark( void ) {
98100
int i;
99101

100102
for ( i = 0; i < 100; i++ ) {
101-
x[ i ] = ( 200.0f * rand_float() ) - 100.0f;
102-
y[ i ] = ( 200.0f * rand_float() ) - 100.0f;
103+
x[ i ] = random_uniform( -10.0f, 10.0f );
104+
y[ i ] = random_uniform( -10.0f, 10.0f );
103105
}
104106

105107
t = tic();

0 commit comments

Comments
 (0)